Re: [PATCH 5/7] uprobes: Introduce filter_chain()

2012-12-10 Thread Srikar Dronamraju
* Oleg Nesterov [2012-11-23 21:28:12]: > Add the new helper filter_chain(). Currently it is only placeholder, > the comment explains what is should do. We will change it later to > consult every consumer to decide whether we need to install the swbp. > Until then it works as if any consumer

Re: [PATCH 5/7] uprobes: Introduce filter_chain()

2012-12-10 Thread Srikar Dronamraju
* Oleg Nesterov o...@redhat.com [2012-11-23 21:28:12]: Add the new helper filter_chain(). Currently it is only placeholder, the comment explains what is should do. We will change it later to consult every consumer to decide whether we need to install the swbp. Until then it works as if any

Re: [PATCH 5/7] uprobes: Introduce filter_chain()

2012-11-24 Thread Oleg Nesterov
On 11/23, Oleg Nesterov wrote: > > Change install_breakpoint() to call filter_chain() instead of checking > uprobe->consumers != NULL. We obviously need this, and this equally > closes the race with _unregister(). > > Change remove_breakpoint() to call this helper too. Currently this is >

Re: [PATCH 5/7] uprobes: Introduce filter_chain()

2012-11-24 Thread Oleg Nesterov
On 11/23, Oleg Nesterov wrote: Change install_breakpoint() to call filter_chain() instead of checking uprobe-consumers != NULL. We obviously need this, and this equally closes the race with _unregister(). Change remove_breakpoint() to call this helper too. Currently this is pointless

[PATCH 5/7] uprobes: Introduce filter_chain()

2012-11-23 Thread Oleg Nesterov
Add the new helper filter_chain(). Currently it is only placeholder, the comment explains what is should do. We will change it later to consult every consumer to decide whether we need to install the swbp. Until then it works as if any consumer returns true, this matches the current behavior.

[PATCH 5/7] uprobes: Introduce filter_chain()

2012-11-23 Thread Oleg Nesterov
Add the new helper filter_chain(). Currently it is only placeholder, the comment explains what is should do. We will change it later to consult every consumer to decide whether we need to install the swbp. Until then it works as if any consumer returns true, this matches the current behavior.