Re: [PATCH 5.3 112/112] ASoC: sgtl5000: add ADC mute control

2019-10-18 Thread Oleksandr Suvorov
On Thu, 2019-10-17 at 17:39 +0100, Mark Brown wrote: > > All versions of driver sgtl5000 (since creating in 2011) has a bug in > > sgtl5000_probe(): > > ... > >snd_soc_write(codec, SGTL5000_CHIP_ANA_CTRL, > >SGTL5000_HP_ZCD_EN | > >

Re: [PATCH 5.3 112/112] ASoC: sgtl5000: add ADC mute control

2019-10-17 Thread Mark Brown
On Thu, Oct 17, 2019 at 02:16:09PM +, Oleksandr Suvorov wrote: > All versions of driver sgtl5000 (since creating in 2011) has a bug in > sgtl5000_probe(): > ... >snd_soc_write(codec, SGTL5000_CHIP_ANA_CTRL, >SGTL5000_HP_ZCD_EN | >

Re: [PATCH 5.3 112/112] ASoC: sgtl5000: add ADC mute control

2019-10-17 Thread Oleksandr Suvorov
On Thu, 2019-10-17 at 12:11 +0100, Mark Brown wrote: > On Thu, Oct 17, 2019 at 09:49:27AM +, Oleksandr Suvorov wrote: > > > Mark, obviously this is not a NEW feature. This patch adds LOST > > standard control. > > It's a new feature for this CODEC to have control over the capture > mute, >

Re: [PATCH 5.3 112/112] ASoC: sgtl5000: add ADC mute control

2019-10-17 Thread Greg Kroah-Hartman
On Thu, Oct 17, 2019 at 11:20:32AM +0200, Richard Leitner wrote: > > On 17/10/2019 01:23, Greg Kroah-Hartman wrote: > > On Wed, Oct 16, 2019 at 11:35:18PM +0100, Mark Brown wrote: > > > On Wed, Oct 16, 2019 at 03:10:25PM -0700, Greg Kroah-Hartman wrote: > > > > On Wed, Oct 16, 2019 at 11:00:44PM

Re: Fw: [PATCH 5.3 112/112] ASoC: sgtl5000: add ADC mute control

2019-10-17 Thread Mark Brown
On Thu, Oct 17, 2019 at 09:49:27AM +, Oleksandr Suvorov wrote: > Mark, obviously this is not a NEW feature. This patch adds LOST > standard control. It's a new feature for this CODEC to have control over the capture mute, other devices have of course had control over it for a long time but

Re: Fw: [PATCH 5.3 112/112] ASoC: sgtl5000: add ADC mute control

2019-10-17 Thread Oleksandr Suvorov
> On 17/10/2019 01:23, Greg Kroah-Hartman wrote: > > On Wed, Oct 16, 2019 at 11:35:18PM +0100, Mark Brown wrote: > >> On Wed, Oct 16, 2019 at 03:10:25PM -0700, Greg Kroah-Hartman wrote: > >>> On Wed, Oct 16, 2019 at 11:00:44PM +0100, Mark Brown wrote: > On Wed, Oct 16, 2019 at 02:51:44PM

Re: [PATCH 5.3 112/112] ASoC: sgtl5000: add ADC mute control

2019-10-17 Thread Richard Leitner
On 17/10/2019 01:23, Greg Kroah-Hartman wrote: On Wed, Oct 16, 2019 at 11:35:18PM +0100, Mark Brown wrote: On Wed, Oct 16, 2019 at 03:10:25PM -0700, Greg Kroah-Hartman wrote: On Wed, Oct 16, 2019 at 11:00:44PM +0100, Mark Brown wrote: On Wed, Oct 16, 2019 at 02:51:44PM -0700, Greg

Re: [PATCH 5.3 112/112] ASoC: sgtl5000: add ADC mute control

2019-10-16 Thread Greg Kroah-Hartman
On Wed, Oct 16, 2019 at 11:35:18PM +0100, Mark Brown wrote: > On Wed, Oct 16, 2019 at 03:10:25PM -0700, Greg Kroah-Hartman wrote: > > On Wed, Oct 16, 2019 at 11:00:44PM +0100, Mark Brown wrote: > > > On Wed, Oct 16, 2019 at 02:51:44PM -0700, Greg Kroah-Hartman wrote: > > > > From: Oleksandr

Re: [PATCH 5.3 112/112] ASoC: sgtl5000: add ADC mute control

2019-10-16 Thread Mark Brown
On Wed, Oct 16, 2019 at 03:10:25PM -0700, Greg Kroah-Hartman wrote: > On Wed, Oct 16, 2019 at 11:00:44PM +0100, Mark Brown wrote: > > On Wed, Oct 16, 2019 at 02:51:44PM -0700, Greg Kroah-Hartman wrote: > > > From: Oleksandr Suvorov > > > commit 694b14554d75f2a1ae111202e71860d58b434a21 upstream.

Re: [PATCH 5.3 112/112] ASoC: sgtl5000: add ADC mute control

2019-10-16 Thread Greg Kroah-Hartman
On Wed, Oct 16, 2019 at 11:00:44PM +0100, Mark Brown wrote: > On Wed, Oct 16, 2019 at 02:51:44PM -0700, Greg Kroah-Hartman wrote: > > From: Oleksandr Suvorov > > > > commit 694b14554d75f2a1ae111202e71860d58b434a21 upstream. > > > > This control mute/unmute the ADC input of SGTL5000 > > using

Re: [PATCH 5.3 112/112] ASoC: sgtl5000: add ADC mute control

2019-10-16 Thread Mark Brown
On Wed, Oct 16, 2019 at 02:51:44PM -0700, Greg Kroah-Hartman wrote: > From: Oleksandr Suvorov > > commit 694b14554d75f2a1ae111202e71860d58b434a21 upstream. > > This control mute/unmute the ADC input of SGTL5000 > using its CHIP_ANA_CTRL register. This seems like a new feature and not an

[PATCH 5.3 112/112] ASoC: sgtl5000: add ADC mute control

2019-10-16 Thread Greg Kroah-Hartman
From: Oleksandr Suvorov commit 694b14554d75f2a1ae111202e71860d58b434a21 upstream. This control mute/unmute the ADC input of SGTL5000 using its CHIP_ANA_CTRL register. Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler Reviewed-by: Igor Opaniuk Reviewed-by: Fabio Estevam Link: