Re: [PATCH 8/8] modules: inherit TAINT_PROPRIETARY_MODULE

2020-08-04 Thread daniel
On Thu, Jul 30, 2020 at 08:10:27AM +0200, Christoph Hellwig wrote: > If a TAINT_PROPRIETARY_MODULE exports symbol, inherit the taint flag > for all modules importing these symbols, and don't allow loading > symbols from TAINT_PROPRIETARY_MODULE modules if the module previously > imported gplonly

Re: [PATCH 8/8] modules: inherit TAINT_PROPRIETARY_MODULE

2020-07-31 Thread Jessica Yu
+++ Christoph Hellwig [31/07/20 11:00 +0200]: On Fri, Jul 31, 2020 at 10:51:30AM +0200, Jessica Yu wrote: + if (mod->using_gplonly_symbols) { + pr_info("%s: module using GPL-only symbols uses symbols from proprietary module %s.\n", + mod->name,

Re: [PATCH 8/8] modules: inherit TAINT_PROPRIETARY_MODULE

2020-07-31 Thread Christoph Hellwig
On Fri, Jul 31, 2020 at 10:51:30AM +0200, Jessica Yu wrote: >> +if (mod->using_gplonly_symbols) { >> +pr_info("%s: module using GPL-only symbols uses symbols from >> proprietary module %s.\n", >> +mod->name, owner->name); > > pr_err() maybe? > >> +

Re: [PATCH 8/8] modules: inherit TAINT_PROPRIETARY_MODULE

2020-07-31 Thread Jessica Yu
+++ Christoph Hellwig [30/07/20 18:29 +0200]: On Thu, Jul 30, 2020 at 04:12:32PM +0200, Jessica Yu wrote: + if (owner && test_bit(TAINT_PROPRIETARY_MODULE, >taints)) { + if (mod->using_gplonly_symbols) { + sym = NULL; + goto

Re: [PATCH 8/8] modules: inherit TAINT_PROPRIETARY_MODULE

2020-07-30 Thread Christoph Hellwig
On Thu, Jul 30, 2020 at 04:12:32PM +0200, Jessica Yu wrote: >> +if (owner && test_bit(TAINT_PROPRIETARY_MODULE, >taints)) { >> +if (mod->using_gplonly_symbols) { >> +sym = NULL; >> +goto getname; >> +} >> +

Re: [PATCH 8/8] modules: inherit TAINT_PROPRIETARY_MODULE

2020-07-30 Thread Jessica Yu
+++ Christoph Hellwig [30/07/20 08:10 +0200]: If a TAINT_PROPRIETARY_MODULE exports symbol, inherit the taint flag for all modules importing these symbols, and don't allow loading symbols from TAINT_PROPRIETARY_MODULE modules if the module previously imported gplonly symbols. Add a

[PATCH 8/8] modules: inherit TAINT_PROPRIETARY_MODULE

2020-07-30 Thread Christoph Hellwig
If a TAINT_PROPRIETARY_MODULE exports symbol, inherit the taint flag for all modules importing these symbols, and don't allow loading symbols from TAINT_PROPRIETARY_MODULE modules if the module previously imported gplonly symbols. Add a anti-circumvention devices so people don't accidentally get