Re: [PATCH 8/9] [HACK] ARM: imx: work around v7_cpu_resume link error

2013-02-18 Thread Shawn Guo
On Mon, Feb 18, 2013 at 11:11:30PM -0500, Nicolas Pitre wrote: > On Tue, 19 Feb 2013, Shawn Guo wrote: > > > On Mon, Feb 18, 2013 at 12:06:32PM -0500, Nicolas Pitre wrote: > > > Try the following instead. It makes the code simpler and easier to > > > debug. > > > > > It works now. Thanks,

Re: [PATCH 8/9] [HACK] ARM: imx: work around v7_cpu_resume link error

2013-02-18 Thread Nicolas Pitre
On Tue, 19 Feb 2013, Shawn Guo wrote: > On Mon, Feb 18, 2013 at 12:06:32PM -0500, Nicolas Pitre wrote: > > Try the following instead. It makes the code simpler and easier to > > debug. > > > It works now. Thanks, Nico. Care to send a patch for it? I'd like > to apply it. - >8 FRom:

Re: [PATCH 8/9] [HACK] ARM: imx: work around v7_cpu_resume link error

2013-02-18 Thread Shawn Guo
On Mon, Feb 18, 2013 at 12:06:32PM -0500, Nicolas Pitre wrote: > Try the following instead. It makes the code simpler and easier to > debug. > It works now. Thanks, Nico. Care to send a patch for it? I'd like to apply it. Shawn > diff --git a/arch/arm/mach-imx/headsmp.S

Re: [PATCH 8/9] [HACK] ARM: imx: work around v7_cpu_resume link error

2013-02-18 Thread Nicolas Pitre
On Mon, 18 Feb 2013, Shawn Guo wrote: > On Sat, Feb 16, 2013 at 12:14:49AM -0500, Nicolas Pitre wrote: > > Something like this should work: > > > > diff --git a/arch/arm/mach-imx/headsmp.S b/arch/arm/mach-imx/headsmp.S > > index 7e49deb128..9de26f3edb 100644 > > --- a/arch/arm/mach-imx/headsmp.S

Re: [PATCH 8/9] [HACK] ARM: imx: work around v7_cpu_resume link error

2013-02-18 Thread Nicolas Pitre
On Mon, 18 Feb 2013, Shawn Guo wrote: On Sat, Feb 16, 2013 at 12:14:49AM -0500, Nicolas Pitre wrote: Something like this should work: diff --git a/arch/arm/mach-imx/headsmp.S b/arch/arm/mach-imx/headsmp.S index 7e49deb128..9de26f3edb 100644 --- a/arch/arm/mach-imx/headsmp.S +++

Re: [PATCH 8/9] [HACK] ARM: imx: work around v7_cpu_resume link error

2013-02-18 Thread Shawn Guo
On Mon, Feb 18, 2013 at 12:06:32PM -0500, Nicolas Pitre wrote: Try the following instead. It makes the code simpler and easier to debug. It works now. Thanks, Nico. Care to send a patch for it? I'd like to apply it. Shawn diff --git a/arch/arm/mach-imx/headsmp.S

Re: [PATCH 8/9] [HACK] ARM: imx: work around v7_cpu_resume link error

2013-02-18 Thread Nicolas Pitre
On Tue, 19 Feb 2013, Shawn Guo wrote: On Mon, Feb 18, 2013 at 12:06:32PM -0500, Nicolas Pitre wrote: Try the following instead. It makes the code simpler and easier to debug. It works now. Thanks, Nico. Care to send a patch for it? I'd like to apply it. - 8 FRom: Nicolas

Re: [PATCH 8/9] [HACK] ARM: imx: work around v7_cpu_resume link error

2013-02-18 Thread Shawn Guo
On Mon, Feb 18, 2013 at 11:11:30PM -0500, Nicolas Pitre wrote: On Tue, 19 Feb 2013, Shawn Guo wrote: On Mon, Feb 18, 2013 at 12:06:32PM -0500, Nicolas Pitre wrote: Try the following instead. It makes the code simpler and easier to debug. It works now. Thanks, Nico. Care to

Re: [PATCH 8/9] [HACK] ARM: imx: work around v7_cpu_resume link error

2013-02-17 Thread Shawn Guo
On Sat, Feb 16, 2013 at 12:14:49AM -0500, Nicolas Pitre wrote: > On Fri, 15 Feb 2013, Russell King - ARM Linux wrote: > > > On Thu, Feb 14, 2013 at 11:47:50PM +0100, Arnd Bergmann wrote: > > > Patch c08e20d24 "arm: Add v7_invalidate_l1 to cache-v7.S" > > > moves the v7_invalidate_l1 symbol out of

Re: [PATCH 8/9] [HACK] ARM: imx: work around v7_cpu_resume link error

2013-02-17 Thread Shawn Guo
On Sat, Feb 16, 2013 at 12:14:49AM -0500, Nicolas Pitre wrote: On Fri, 15 Feb 2013, Russell King - ARM Linux wrote: On Thu, Feb 14, 2013 at 11:47:50PM +0100, Arnd Bergmann wrote: Patch c08e20d24 arm: Add v7_invalidate_l1 to cache-v7.S moves the v7_invalidate_l1 symbol out of

Re: [PATCH 8/9] [HACK] ARM: imx: work around v7_cpu_resume link error

2013-02-15 Thread Nicolas Pitre
On Fri, 15 Feb 2013, Russell King - ARM Linux wrote: > On Thu, Feb 14, 2013 at 11:47:50PM +0100, Arnd Bergmann wrote: > > Patch c08e20d24 "arm: Add v7_invalidate_l1 to cache-v7.S" > > moves the v7_invalidate_l1 symbol out of imx/headsmp.S, > > which seems to cause a link error because it is now >

Re: [PATCH 8/9] [HACK] ARM: imx: work around v7_cpu_resume link error

2013-02-15 Thread Arnd Bergmann
On Friday 15 February 2013, Russell King - ARM Linux wrote: > > The .text section alone is just short of 32MB. > > I suspect when it does go over that, we'll see a lot more link time > failures due to the 'bl' instructions failing to encode their PC relative > jumps. The only solution then will

Re: [PATCH 8/9] [HACK] ARM: imx: work around v7_cpu_resume link error

2013-02-15 Thread Russell King - ARM Linux
On Fri, Feb 15, 2013 at 11:05:14AM +, Arnd Bergmann wrote: > $ size obj-tmp/vmlinux -A > obj-tmp/vmlinux : > section size addr > .head.text504 3221258240 > .text32707336 3221258752 > .text.head 8 3253966088

Re: [PATCH 8/9] [HACK] ARM: imx: work around v7_cpu_resume link error

2013-02-15 Thread Russell King - ARM Linux
On Thu, Feb 14, 2013 at 11:47:50PM +0100, Arnd Bergmann wrote: > Patch c08e20d24 "arm: Add v7_invalidate_l1 to cache-v7.S" > moves the v7_invalidate_l1 symbol out of imx/headsmp.S, > which seems to cause a link error because it is now > too far away from v7_cpu_resume when building an >

Re: [PATCH 8/9] [HACK] ARM: imx: work around v7_cpu_resume link error

2013-02-15 Thread Arnd Bergmann
On Thursday 14 February 2013, Stephen Warren wrote: > On 02/14/2013 03:47 PM, Arnd Bergmann wrote: > > Patch c08e20d24 "arm: Add v7_invalidate_l1 to cache-v7.S" > > moves the v7_invalidate_l1 symbol out of imx/headsmp.S, > > which seems to cause a link error because it is now > > too far away from

Re: [PATCH 8/9] [HACK] ARM: imx: work around v7_cpu_resume link error

2013-02-15 Thread Arnd Bergmann
On Thursday 14 February 2013, Stephen Warren wrote: On 02/14/2013 03:47 PM, Arnd Bergmann wrote: Patch c08e20d24 arm: Add v7_invalidate_l1 to cache-v7.S moves the v7_invalidate_l1 symbol out of imx/headsmp.S, which seems to cause a link error because it is now too far away from

Re: [PATCH 8/9] [HACK] ARM: imx: work around v7_cpu_resume link error

2013-02-15 Thread Russell King - ARM Linux
On Thu, Feb 14, 2013 at 11:47:50PM +0100, Arnd Bergmann wrote: Patch c08e20d24 arm: Add v7_invalidate_l1 to cache-v7.S moves the v7_invalidate_l1 symbol out of imx/headsmp.S, which seems to cause a link error because it is now too far away from v7_cpu_resume when building an allyesconfig

Re: [PATCH 8/9] [HACK] ARM: imx: work around v7_cpu_resume link error

2013-02-15 Thread Russell King - ARM Linux
On Fri, Feb 15, 2013 at 11:05:14AM +, Arnd Bergmann wrote: $ size obj-tmp/vmlinux -A obj-tmp/vmlinux : section size addr .head.text504 3221258240 .text32707336 3221258752 .text.head 8 3253966088

Re: [PATCH 8/9] [HACK] ARM: imx: work around v7_cpu_resume link error

2013-02-15 Thread Arnd Bergmann
On Friday 15 February 2013, Russell King - ARM Linux wrote: The .text section alone is just short of 32MB. I suspect when it does go over that, we'll see a lot more link time failures due to the 'bl' instructions failing to encode their PC relative jumps. The only solution then will be to

Re: [PATCH 8/9] [HACK] ARM: imx: work around v7_cpu_resume link error

2013-02-15 Thread Nicolas Pitre
On Fri, 15 Feb 2013, Russell King - ARM Linux wrote: On Thu, Feb 14, 2013 at 11:47:50PM +0100, Arnd Bergmann wrote: Patch c08e20d24 arm: Add v7_invalidate_l1 to cache-v7.S moves the v7_invalidate_l1 symbol out of imx/headsmp.S, which seems to cause a link error because it is now too far

Re: [PATCH 8/9] [HACK] ARM: imx: work around v7_cpu_resume link error

2013-02-14 Thread Stephen Warren
On 02/14/2013 03:47 PM, Arnd Bergmann wrote: > Patch c08e20d24 "arm: Add v7_invalidate_l1 to cache-v7.S" > moves the v7_invalidate_l1 symbol out of imx/headsmp.S, > which seems to cause a link error because it is now > too far away from v7_cpu_resume when building an > allyesconfig kernel. Is the

[PATCH 8/9] [HACK] ARM: imx: work around v7_cpu_resume link error

2013-02-14 Thread Arnd Bergmann
Patch c08e20d24 "arm: Add v7_invalidate_l1 to cache-v7.S" moves the v7_invalidate_l1 symbol out of imx/headsmp.S, which seems to cause a link error because it is now too far away from v7_cpu_resume when building an allyesconfig kernel. If we move the v7_cpu_resume function from the .data section

[PATCH 8/9] [HACK] ARM: imx: work around v7_cpu_resume link error

2013-02-14 Thread Arnd Bergmann
Patch c08e20d24 arm: Add v7_invalidate_l1 to cache-v7.S moves the v7_invalidate_l1 symbol out of imx/headsmp.S, which seems to cause a link error because it is now too far away from v7_cpu_resume when building an allyesconfig kernel. If we move the v7_cpu_resume function from the .data section to

Re: [PATCH 8/9] [HACK] ARM: imx: work around v7_cpu_resume link error

2013-02-14 Thread Stephen Warren
On 02/14/2013 03:47 PM, Arnd Bergmann wrote: Patch c08e20d24 arm: Add v7_invalidate_l1 to cache-v7.S moves the v7_invalidate_l1 symbol out of imx/headsmp.S, which seems to cause a link error because it is now too far away from v7_cpu_resume when building an allyesconfig kernel. Is the