On 22/06/17 08:09, Zhi Mao wrote:
Hi John,
Thanks for your review the code and feedback.
There are 3 issues in this patch:
1.adds PWM_CLK_DIV_MAX which really should go into its own patch
2.adds mtk_pwm_com_reg which should also go into its own patch
3.remove comments inline /*===*/
for #1
On 22/06/17 08:09, Zhi Mao wrote:
Hi John,
Thanks for your review the code and feedback.
There are 3 issues in this patch:
1.adds PWM_CLK_DIV_MAX which really should go into its own patch
2.adds mtk_pwm_com_reg which should also go into its own patch
3.remove comments inline /*===*/
for #1
On 22/06/17 08:09, Zhi Mao wrote:
Hi John,
Thanks for your review the code and feedback.
There are 3 issues in this patch:
1.adds PWM_CLK_DIV_MAX which really should go into its own patch
2.adds mtk_pwm_com_reg which should also go into its own patch
3.remove comments inline /*===*/
for #1
On 22/06/17 08:09, Zhi Mao wrote:
Hi John,
Thanks for your review the code and feedback.
There are 3 issues in this patch:
1.adds PWM_CLK_DIV_MAX which really should go into its own patch
2.adds mtk_pwm_com_reg which should also go into its own patch
3.remove comments inline /*===*/
for #1
On 21/06/17 10:11, Zhi Mao wrote:
support multiple chip(MT2712, MT7622, MT7623)
This patch does more than add extra SoC support. It also
* adds PWM_CLK_DIV_MAX which really should go into its own patch
* adds mtk_pwm_com_reg which should also go into its own patch
more comments inline
On 21/06/17 10:11, Zhi Mao wrote:
support multiple chip(MT2712, MT7622, MT7623)
This patch does more than add extra SoC support. It also
* adds PWM_CLK_DIV_MAX which really should go into its own patch
* adds mtk_pwm_com_reg which should also go into its own patch
more comments inline
support multiple chip(MT2712, MT7622, MT7623)
Signed-off-by: Zhi Mao
---
drivers/pwm/pwm-mediatek.c | 63 +++-
1 file changed, 51 insertions(+), 12 deletions(-)
diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c
support multiple chip(MT2712, MT7622, MT7623)
Signed-off-by: Zhi Mao
---
drivers/pwm/pwm-mediatek.c | 63 +++-
1 file changed, 51 insertions(+), 12 deletions(-)
diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c
index c803ff6..d520356
8 matches
Mail list logo