Re: [PATCH RFC] setns: return 0 directly if try to reassociate with current namespace

2014-10-08 Thread Eric W. Biederman
"Chen, Hanxiao" writes: >> -Original Message- >> From: Eric W. Biederman [mailto:ebied...@xmission.com] >> Sent: Thursday, October 09, 2014 1:56 AM >> >> Serge Hallyn writes: >> >> > Quoting Chen Hanxiao (chenhanx...@cn.fujitsu.com): >> >> We could use setns to join the current ns, >>

RE: [PATCH RFC] setns: return 0 directly if try to reassociate with current namespace

2014-10-08 Thread Chen, Hanxiao
> -Original Message- > From: Eric W. Biederman [mailto:ebied...@xmission.com] > Sent: Thursday, October 09, 2014 1:56 AM > > Serge Hallyn writes: > > > Quoting Chen Hanxiao (chenhanx...@cn.fujitsu.com): > >> We could use setns to join the current ns, > >> which did a lot of

Re: [PATCH RFC] setns: return 0 directly if try to reassociate with current namespace

2014-10-08 Thread Serge Hallyn
Quoting Eric W. Biederman (ebied...@xmission.com): > Serge Hallyn writes: > > > Quoting Chen Hanxiao (chenhanx...@cn.fujitsu.com): > >> We could use setns to join the current ns, > >> which did a lot of unnecessary work. > >> This patch will check this senario and > >> return 0 directly. > >> >

Re: [PATCH RFC] setns: return 0 directly if try to reassociate with current namespace

2014-10-08 Thread Eric W. Biederman
Serge Hallyn writes: > Quoting Chen Hanxiao (chenhanx...@cn.fujitsu.com): >> We could use setns to join the current ns, >> which did a lot of unnecessary work. >> This patch will check this senario and >> return 0 directly. >> >> Signed-off-by: Chen Hanxiao > > Plus it's just asking for

Re: [PATCH RFC] setns: return 0 directly if try to reassociate with current namespace

2014-10-08 Thread Serge Hallyn
Quoting Chen Hanxiao (chenhanx...@cn.fujitsu.com): > We could use setns to join the current ns, > which did a lot of unnecessary work. > This patch will check this senario and > return 0 directly. > > Signed-off-by: Chen Hanxiao Plus it's just asking for trouble. I would ack this, except you

[PATCH RFC] setns: return 0 directly if try to reassociate with current namespace

2014-10-08 Thread Chen Hanxiao
We could use setns to join the current ns, which did a lot of unnecessary work. This patch will check this senario and return 0 directly. Signed-off-by: Chen Hanxiao --- kernel/nsproxy.c | 28 1 file changed, 28 insertions(+) diff --git a/kernel/nsproxy.c

[PATCH RFC] setns: return 0 directly if try to reassociate with current namespace

2014-10-08 Thread Chen Hanxiao
We could use setns to join the current ns, which did a lot of unnecessary work. This patch will check this senario and return 0 directly. Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- kernel/nsproxy.c | 28 1 file changed, 28 insertions(+) diff --git

Re: [PATCH RFC] setns: return 0 directly if try to reassociate with current namespace

2014-10-08 Thread Serge Hallyn
Quoting Chen Hanxiao (chenhanx...@cn.fujitsu.com): We could use setns to join the current ns, which did a lot of unnecessary work. This patch will check this senario and return 0 directly. Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com Plus it's just asking for trouble. I would

Re: [PATCH RFC] setns: return 0 directly if try to reassociate with current namespace

2014-10-08 Thread Eric W. Biederman
Serge Hallyn serge.hal...@ubuntu.com writes: Quoting Chen Hanxiao (chenhanx...@cn.fujitsu.com): We could use setns to join the current ns, which did a lot of unnecessary work. This patch will check this senario and return 0 directly. Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com

Re: [PATCH RFC] setns: return 0 directly if try to reassociate with current namespace

2014-10-08 Thread Serge Hallyn
Quoting Eric W. Biederman (ebied...@xmission.com): Serge Hallyn serge.hal...@ubuntu.com writes: Quoting Chen Hanxiao (chenhanx...@cn.fujitsu.com): We could use setns to join the current ns, which did a lot of unnecessary work. This patch will check this senario and return 0 directly.

RE: [PATCH RFC] setns: return 0 directly if try to reassociate with current namespace

2014-10-08 Thread Chen, Hanxiao
-Original Message- From: Eric W. Biederman [mailto:ebied...@xmission.com] Sent: Thursday, October 09, 2014 1:56 AM Serge Hallyn serge.hal...@ubuntu.com writes: Quoting Chen Hanxiao (chenhanx...@cn.fujitsu.com): We could use setns to join the current ns, which did a lot of

Re: [PATCH RFC] setns: return 0 directly if try to reassociate with current namespace

2014-10-08 Thread Eric W. Biederman
Chen, Hanxiao chenhanx...@cn.fujitsu.com writes: -Original Message- From: Eric W. Biederman [mailto:ebied...@xmission.com] Sent: Thursday, October 09, 2014 1:56 AM Serge Hallyn serge.hal...@ubuntu.com writes: Quoting Chen Hanxiao (chenhanx...@cn.fujitsu.com): We could use