Re: [PATCH RFC - TAKE TWO - 11/12] block, bfq: boost the throughput on NCQ-capable flash-based devices

2014-06-18 Thread Tejun Heo
Hello, On Mon, Jun 16, 2014 at 12:46:36PM +0200, Paolo Valente wrote: > To preserve the desired distribution of the device throughput (or time), this > scheme entails updating weights every time the set of active queues changes. > For example (sorry for the trivial example, but I just want to

Re: [PATCH RFC - TAKE TWO - 11/12] block, bfq: boost the throughput on NCQ-capable flash-based devices

2014-06-18 Thread Tejun Heo
Hello, On Mon, Jun 16, 2014 at 12:46:36PM +0200, Paolo Valente wrote: To preserve the desired distribution of the device throughput (or time), this scheme entails updating weights every time the set of active queues changes. For example (sorry for the trivial example, but I just want to make

Re: [PATCH RFC - TAKE TWO - 11/12] block, bfq: boost the throughput on NCQ-capable flash-based devices

2014-06-16 Thread Paolo Valente
Il giorno 04/giu/2014, alle ore 15:56, Tejun Heo ha scritto: > Hello, Paolo. Hello, and sorry for the late reply. > […] >> >> Actually we have been asked several times to improve random-I/O >> performance on HDDs over the last years, by people recording, for >> the typical tasks performed by

Re: [PATCH RFC - TAKE TWO - 11/12] block, bfq: boost the throughput on NCQ-capable flash-based devices

2014-06-16 Thread Paolo Valente
Il giorno 04/giu/2014, alle ore 15:56, Tejun Heo t...@kernel.org ha scritto: Hello, Paolo. Hello, and sorry for the late reply. […] Actually we have been asked several times to improve random-I/O performance on HDDs over the last years, by people recording, for the typical tasks

Re: [PATCH RFC - TAKE TWO - 11/12] block, bfq: boost the throughput on NCQ-capable flash-based devices

2014-06-04 Thread Tejun Heo
Hello, Paolo. On Wed, Jun 04, 2014 at 09:29:20AM +0200, Paolo Valente wrote: > > Shouldn't the comparison be against the benefit of "not idling > > selectively" vs "always idling" when blkcg is in use? > > > > Exactly. I’m sorry if I wrote things/sentences that did not let this > point be

Re: [PATCH RFC - TAKE TWO - 11/12] block, bfq: boost the throughput on NCQ-capable flash-based devices

2014-06-04 Thread Paolo Valente
Il giorno 03/giu/2014, alle ore 19:11, Tejun Heo ha scritto: > Hello, > > On Mon, Jun 02, 2014 at 11:26:07AM +0200, Paolo Valente wrote: #define cond_for_expiring_non_wr (bfqd->hw_tag && \ - bfqd->wr_busy_queues > 0) +

Re: [PATCH RFC - TAKE TWO - 11/12] block, bfq: boost the throughput on NCQ-capable flash-based devices

2014-06-04 Thread Paolo Valente
Il giorno 03/giu/2014, alle ore 19:11, Tejun Heo t...@kernel.org ha scritto: Hello, On Mon, Jun 02, 2014 at 11:26:07AM +0200, Paolo Valente wrote: #define cond_for_expiring_non_wr (bfqd-hw_tag \ - bfqd-wr_busy_queues 0) +

Re: [PATCH RFC - TAKE TWO - 11/12] block, bfq: boost the throughput on NCQ-capable flash-based devices

2014-06-04 Thread Tejun Heo
Hello, Paolo. On Wed, Jun 04, 2014 at 09:29:20AM +0200, Paolo Valente wrote: Shouldn't the comparison be against the benefit of not idling selectively vs always idling when blkcg is in use? Exactly. I’m sorry if I wrote things/sentences that did not let this point be clear. Maybe this

Re: [PATCH RFC - TAKE TWO - 11/12] block, bfq: boost the throughput on NCQ-capable flash-based devices

2014-06-03 Thread Tejun Heo
Hello, On Mon, Jun 02, 2014 at 11:26:07AM +0200, Paolo Valente wrote: > >> #define cond_for_expiring_non_wr (bfqd->hw_tag && \ > >> - bfqd->wr_busy_queues > 0) > >> + (bfqd->wr_busy_queues > 0 || \ > >> +

Re: [PATCH RFC - TAKE TWO - 11/12] block, bfq: boost the throughput on NCQ-capable flash-based devices

2014-06-03 Thread Tejun Heo
Hello, On Mon, Jun 02, 2014 at 11:26:07AM +0200, Paolo Valente wrote: #define cond_for_expiring_non_wr (bfqd-hw_tag \ - bfqd-wr_busy_queues 0) + (bfqd-wr_busy_queues 0 || \ + (symmetric_scenario \

Re: [PATCH RFC - TAKE TWO - 11/12] block, bfq: boost the throughput on NCQ-capable flash-based devices

2014-06-02 Thread Paolo Valente
Il giorno 31/mag/2014, alle ore 13:52, Tejun Heo ha scritto: > Hello, Paolo. > > So, I've actually looked at the code. Here are some questions. > > On Thu, May 29, 2014 at 11:05:42AM +0200, Paolo Valente wrote: >> + * 1) all active queues have the same weight, >> + * 2) all active groups at

Re: [PATCH RFC - TAKE TWO - 11/12] block, bfq: boost the throughput on NCQ-capable flash-based devices

2014-06-02 Thread Paolo Valente
Il giorno 31/mag/2014, alle ore 13:52, Tejun Heo t...@kernel.org ha scritto: Hello, Paolo. So, I've actually looked at the code. Here are some questions. On Thu, May 29, 2014 at 11:05:42AM +0200, Paolo Valente wrote: + * 1) all active queues have the same weight, + * 2) all active

Re: [PATCH RFC - TAKE TWO - 11/12] block, bfq: boost the throughput on NCQ-capable flash-based devices

2014-05-31 Thread Tejun Heo
Hello, Paolo. So, I've actually looked at the code. Here are some questions. On Thu, May 29, 2014 at 11:05:42AM +0200, Paolo Valente wrote: > + * 1) all active queues have the same weight, > + * 2) all active groups at the same level in the groups tree have the same > + *weight, > + * 3)

Re: [PATCH RFC - TAKE TWO - 11/12] block, bfq: boost the throughput on NCQ-capable flash-based devices

2014-05-31 Thread Tejun Heo
Hello, Paolo. So, I've actually looked at the code. Here are some questions. On Thu, May 29, 2014 at 11:05:42AM +0200, Paolo Valente wrote: + * 1) all active queues have the same weight, + * 2) all active groups at the same level in the groups tree have the same + *weight, + * 3) all

Re: [PATCH RFC - TAKE TWO - 11/12] block, bfq: boost the throughput on NCQ-capable flash-based devices

2014-05-30 Thread Paolo Valente
Il giorno 30/mag/2014, alle ore 17:46, Tejun Heo ha scritto: > On Thu, May 29, 2014 at 11:05:42AM +0200, Paolo Valente wrote: >> This patch boosts the throughput on NCQ-capable flash-based devices, >> while still preserving latency guarantees for interactive and soft >> real-time applications.

Re: [PATCH RFC - TAKE TWO - 11/12] block, bfq: boost the throughput on NCQ-capable flash-based devices

2014-05-30 Thread Tejun Heo
On Thu, May 29, 2014 at 11:05:42AM +0200, Paolo Valente wrote: > This patch boosts the throughput on NCQ-capable flash-based devices, > while still preserving latency guarantees for interactive and soft > real-time applications. The throughput is boosted by just not idling > the device when the

Re: [PATCH RFC - TAKE TWO - 11/12] block, bfq: boost the throughput on NCQ-capable flash-based devices

2014-05-30 Thread Tejun Heo
On Thu, May 29, 2014 at 11:05:42AM +0200, Paolo Valente wrote: This patch boosts the throughput on NCQ-capable flash-based devices, while still preserving latency guarantees for interactive and soft real-time applications. The throughput is boosted by just not idling the device when the

Re: [PATCH RFC - TAKE TWO - 11/12] block, bfq: boost the throughput on NCQ-capable flash-based devices

2014-05-30 Thread Paolo Valente
Il giorno 30/mag/2014, alle ore 17:46, Tejun Heo t...@kernel.org ha scritto: On Thu, May 29, 2014 at 11:05:42AM +0200, Paolo Valente wrote: This patch boosts the throughput on NCQ-capable flash-based devices, while still preserving latency guarantees for interactive and soft real-time

[PATCH RFC - TAKE TWO - 11/12] block, bfq: boost the throughput on NCQ-capable flash-based devices

2014-05-29 Thread Paolo Valente
This patch boosts the throughput on NCQ-capable flash-based devices, while still preserving latency guarantees for interactive and soft real-time applications. The throughput is boosted by just not idling the device when the in-service queue remains empty, even if the queue is sync and has a

[PATCH RFC - TAKE TWO - 11/12] block, bfq: boost the throughput on NCQ-capable flash-based devices

2014-05-29 Thread Paolo Valente
This patch boosts the throughput on NCQ-capable flash-based devices, while still preserving latency guarantees for interactive and soft real-time applications. The throughput is boosted by just not idling the device when the in-service queue remains empty, even if the queue is sync and has a