Re: [PATCH RFC 1/4] virtio_net: pass vi around

2014-10-27 Thread Rusty Russell
"Michael S. Tsirkin" writes: > Too many places poke at [rs]q->vq->vdev->priv just to get > the the vi structure. Let's just pass the pointer around: seems > cleaner, and might even be faster. Agreed, it's neater. Acked-by: Rusty Russell Thanks, Rusty. > > Signed-off-by: Michael S. Tsirkin

Re: [PATCH RFC 1/4] virtio_net: pass vi around

2014-10-27 Thread Rusty Russell
Michael S. Tsirkin m...@redhat.com writes: Too many places poke at [rs]q-vq-vdev-priv just to get the the vi structure. Let's just pass the pointer around: seems cleaner, and might even be faster. Agreed, it's neater. Acked-by: Rusty Russell ru...@rustcorp.com.au Thanks, Rusty.

Re: [PATCH RFC 1/4] virtio_net: pass vi around

2014-10-24 Thread Michael S. Tsirkin
On Fri, Oct 24, 2014 at 10:02:15AM +, David Laight wrote: > From: Michael S. Tsirkin > > > Too many places poke at [rs]q->vq->vdev->priv just to get > > the the vi structure. Let's just pass the pointer around: seems > > cleaner, and might even be faster. > > > > Signed-off-by: Michael S.

RE: [PATCH RFC 1/4] virtio_net: pass vi around

2014-10-24 Thread David Laight
From: Michael S. Tsirkin > Too many places poke at [rs]q->vq->vdev->priv just to get > the the vi structure. Let's just pass the pointer around: seems > cleaner, and might even be faster. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/net/virtio_net.c | 36

RE: [PATCH RFC 1/4] virtio_net: pass vi around

2014-10-24 Thread David Laight
From: Michael S. Tsirkin Too many places poke at [rs]q-vq-vdev-priv just to get the the vi structure. Let's just pass the pointer around: seems cleaner, and might even be faster. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/net/virtio_net.c | 36

Re: [PATCH RFC 1/4] virtio_net: pass vi around

2014-10-24 Thread Michael S. Tsirkin
On Fri, Oct 24, 2014 at 10:02:15AM +, David Laight wrote: From: Michael S. Tsirkin Too many places poke at [rs]q-vq-vdev-priv just to get the the vi structure. Let's just pass the pointer around: seems cleaner, and might even be faster. Signed-off-by: Michael S. Tsirkin

[PATCH RFC 1/4] virtio_net: pass vi around

2014-10-23 Thread Michael S. Tsirkin
Too many places poke at [rs]q->vq->vdev->priv just to get the the vi structure. Let's just pass the pointer around: seems cleaner, and might even be faster. Signed-off-by: Michael S. Tsirkin --- drivers/net/virtio_net.c | 36 +++- 1 file changed, 19

[PATCH RFC 1/4] virtio_net: pass vi around

2014-10-23 Thread Michael S. Tsirkin
Too many places poke at [rs]q-vq-vdev-priv just to get the the vi structure. Let's just pass the pointer around: seems cleaner, and might even be faster. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/net/virtio_net.c | 36 +++- 1 file changed, 19