Re: [PATCH RFC v2 01/16] ARM: call clk_of_init from time_init

2013-09-05 Thread Arnd Bergmann
On Wednesday 04 September 2013, Sören Brinkmann wrote: > On Wed, Sep 04, 2013 at 10:52:09PM +0200, Sebastian Hesselbarth wrote: > > On 09/04/2013 10:41 PM, Sören Brinkmann wrote: > > Anyways, having a custom .init_time gives you full control over > > of_clk_init and clocksource_of_init back again

Re: [PATCH RFC v2 01/16] ARM: call clk_of_init from time_init

2013-09-05 Thread Arnd Bergmann
On Wednesday 04 September 2013, Sören Brinkmann wrote: On Wed, Sep 04, 2013 at 10:52:09PM +0200, Sebastian Hesselbarth wrote: On 09/04/2013 10:41 PM, Sören Brinkmann wrote: Anyways, having a custom .init_time gives you full control over of_clk_init and clocksource_of_init back again thanks

Re: [PATCH RFC v2 01/16] ARM: call clk_of_init from time_init

2013-09-04 Thread Sören Brinkmann
Hi Sebastian, +Michal On Wed, Sep 04, 2013 at 09:32:24PM +0200, Sebastian Hesselbarth wrote: [ ... ] > For mach-zynq I prepared a patch set that brings it close to .init_time > removal. I have pushed it to > https://github.com/shesselba/linux-dove.git zynq-clk-init-v1 > and will maybe post a

Re: [PATCH RFC v2 01/16] ARM: call clk_of_init from time_init

2013-09-04 Thread Sören Brinkmann
Hi Sebastian, On Wed, Sep 04, 2013 at 10:52:09PM +0200, Sebastian Hesselbarth wrote: > On 09/04/2013 10:41 PM, Sören Brinkmann wrote: > >On Wed, Sep 04, 2013 at 09:32:24PM +0200, Sebastian Hesselbarth wrote: > >[ ... ] > >>For mach-zynq I prepared a patch set that brings it close to .init_time >

Re: [PATCH RFC v2 01/16] ARM: call clk_of_init from time_init

2013-09-04 Thread Sebastian Hesselbarth
On 09/04/2013 10:41 PM, Sören Brinkmann wrote: On Wed, Sep 04, 2013 at 09:32:24PM +0200, Sebastian Hesselbarth wrote: [ ... ] For mach-zynq I prepared a patch set that brings it close to .init_time removal. I have pushed it to https://github.com/shesselba/linux-dove.git zynq-clk-init-v1 and

Re: [PATCH RFC v2 01/16] ARM: call clk_of_init from time_init

2013-09-04 Thread Sebastian Hesselbarth
On 08/29/2013 03:45 PM, Arnd Bergmann wrote: Please be careful with the patch ordering here. The patch series should be bisectable, i.e. no patch should ever knowingly break any of the platforms, with the fix getting added in a later patch. You should be able to do that by cleaning up all

Re: [PATCH RFC v2 01/16] ARM: call clk_of_init from time_init

2013-09-04 Thread Sebastian Hesselbarth
On 08/29/2013 03:45 PM, Arnd Bergmann wrote: Please be careful with the patch ordering here. The patch series should be bisectable, i.e. no patch should ever knowingly break any of the platforms, with the fix getting added in a later patch. You should be able to do that by cleaning up all

Re: [PATCH RFC v2 01/16] ARM: call clk_of_init from time_init

2013-09-04 Thread Sebastian Hesselbarth
On 09/04/2013 10:41 PM, Sören Brinkmann wrote: On Wed, Sep 04, 2013 at 09:32:24PM +0200, Sebastian Hesselbarth wrote: [ ... ] For mach-zynq I prepared a patch set that brings it close to .init_time removal. I have pushed it to https://github.com/shesselba/linux-dove.git zynq-clk-init-v1 and

Re: [PATCH RFC v2 01/16] ARM: call clk_of_init from time_init

2013-09-04 Thread Sören Brinkmann
Hi Sebastian, +Michal On Wed, Sep 04, 2013 at 09:32:24PM +0200, Sebastian Hesselbarth wrote: [ ... ] For mach-zynq I prepared a patch set that brings it close to .init_time removal. I have pushed it to https://github.com/shesselba/linux-dove.git zynq-clk-init-v1 and will maybe post a

Re: [PATCH RFC v2 01/16] ARM: call clk_of_init from time_init

2013-09-04 Thread Sören Brinkmann
Hi Sebastian, On Wed, Sep 04, 2013 at 10:52:09PM +0200, Sebastian Hesselbarth wrote: On 09/04/2013 10:41 PM, Sören Brinkmann wrote: On Wed, Sep 04, 2013 at 09:32:24PM +0200, Sebastian Hesselbarth wrote: [ ... ] For mach-zynq I prepared a patch set that brings it close to .init_time removal.

Re: [PATCH RFC v2 01/16] ARM: call clk_of_init from time_init

2013-08-29 Thread Arnd Bergmann
On Wednesday 28 August 2013, Sebastian Hesselbarth wrote: > > > > This forces zynq to move some initialization our clock code relies on to > > init_irq(). Also, the current code already takes an approach of > > doing either common init or machine specific init. > > Soeren, > > you know that

Re: [PATCH RFC v2 01/16] ARM: call clk_of_init from time_init

2013-08-29 Thread Arnd Bergmann
On Wednesday 28 August 2013, Sebastian Hesselbarth wrote: This forces zynq to move some initialization our clock code relies on to init_irq(). Also, the current code already takes an approach of doing either common init or machine specific init. Soeren, you know that patch 16/16

Re: [PATCH RFC v2 01/16] ARM: call clk_of_init from time_init

2013-08-27 Thread Sören Brinkmann
On Wed, Aug 28, 2013 at 12:58:39AM +0200, Sebastian Hesselbarth wrote: > On 08/28/13 00:19, Sören Brinkmann wrote: > >On Tue, Aug 27, 2013 at 11:27:55PM +0200, Sebastian Hesselbarth wrote: > >>Most DT ARM machs require common clock providers initialized before timers. > >>Currently, arch/arm machs

Re: [PATCH RFC v2 01/16] ARM: call clk_of_init from time_init

2013-08-27 Thread Sebastian Hesselbarth
On 08/28/13 00:19, Sören Brinkmann wrote: On Tue, Aug 27, 2013 at 11:27:55PM +0200, Sebastian Hesselbarth wrote: Most DT ARM machs require common clock providers initialized before timers. Currently, arch/arm machs use .init_time to call clk_of_init right before clocksource_of_init. This

Re: [PATCH RFC v2 01/16] ARM: call clk_of_init from time_init

2013-08-27 Thread Sören Brinkmann
On Tue, Aug 27, 2013 at 11:27:55PM +0200, Sebastian Hesselbarth wrote: > Most DT ARM machs require common clock providers initialized before timers. > Currently, arch/arm machs use .init_time to call clk_of_init right before > clocksource_of_init. This prevents to remove that hook and use the

[PATCH RFC v2 01/16] ARM: call clk_of_init from time_init

2013-08-27 Thread Sebastian Hesselbarth
Most DT ARM machs require common clock providers initialized before timers. Currently, arch/arm machs use .init_time to call clk_of_init right before clocksource_of_init. This prevents to remove that hook and use the default hook instead. clk_of_init is safe to call for non-DT platforms, so add

[PATCH RFC v2 01/16] ARM: call clk_of_init from time_init

2013-08-27 Thread Sebastian Hesselbarth
Most DT ARM machs require common clock providers initialized before timers. Currently, arch/arm machs use .init_time to call clk_of_init right before clocksource_of_init. This prevents to remove that hook and use the default hook instead. clk_of_init is safe to call for non-DT platforms, so add

Re: [PATCH RFC v2 01/16] ARM: call clk_of_init from time_init

2013-08-27 Thread Sören Brinkmann
On Tue, Aug 27, 2013 at 11:27:55PM +0200, Sebastian Hesselbarth wrote: Most DT ARM machs require common clock providers initialized before timers. Currently, arch/arm machs use .init_time to call clk_of_init right before clocksource_of_init. This prevents to remove that hook and use the default

Re: [PATCH RFC v2 01/16] ARM: call clk_of_init from time_init

2013-08-27 Thread Sebastian Hesselbarth
On 08/28/13 00:19, Sören Brinkmann wrote: On Tue, Aug 27, 2013 at 11:27:55PM +0200, Sebastian Hesselbarth wrote: Most DT ARM machs require common clock providers initialized before timers. Currently, arch/arm machs use .init_time to call clk_of_init right before clocksource_of_init. This

Re: [PATCH RFC v2 01/16] ARM: call clk_of_init from time_init

2013-08-27 Thread Sören Brinkmann
On Wed, Aug 28, 2013 at 12:58:39AM +0200, Sebastian Hesselbarth wrote: On 08/28/13 00:19, Sören Brinkmann wrote: On Tue, Aug 27, 2013 at 11:27:55PM +0200, Sebastian Hesselbarth wrote: Most DT ARM machs require common clock providers initialized before timers. Currently, arch/arm machs use