Re: [PATCH RFC v2 08/16] ARM: mxs: remove custom .init_time hook

2013-08-29 Thread Shawn Guo
On Thu, Aug 29, 2013 at 01:32:33PM +0200, Sebastian Hesselbarth wrote: > Ok, will take care of it. I assume you are fine with having an extra > struct device_node pointer for the sake of readability instead of > reusing the same pointer. Yeah, something like np_digctl for digctl node. Thanks for

Re: [PATCH RFC v2 08/16] ARM: mxs: remove custom .init_time hook

2013-08-29 Thread Sebastian Hesselbarth
On 08/29/13 13:08, Shawn Guo wrote: On Tue, Aug 27, 2013 at 11:28:02PM +0200, Sebastian Hesselbarth wrote: @@ -100,19 +101,17 @@ static enum imx23_clk clks_init_on[] __initdata = { cpu, hbus, xbus, emi, uart, }; -int __init mx23_clocks_init(void) +static void __init

Re: [PATCH RFC v2 08/16] ARM: mxs: remove custom .init_time hook

2013-08-29 Thread Shawn Guo
On Tue, Aug 27, 2013 at 11:28:02PM +0200, Sebastian Hesselbarth wrote: > @@ -100,19 +101,17 @@ static enum imx23_clk clks_init_on[] __initdata = { > cpu, hbus, xbus, emi, uart, > }; > > -int __init mx23_clocks_init(void) > +static void __init mx23_clocks_init(struct device_node *np) > {

Re: [PATCH RFC v2 08/16] ARM: mxs: remove custom .init_time hook

2013-08-29 Thread Shawn Guo
On Tue, Aug 27, 2013 at 11:28:02PM +0200, Sebastian Hesselbarth wrote: @@ -100,19 +101,17 @@ static enum imx23_clk clks_init_on[] __initdata = { cpu, hbus, xbus, emi, uart, }; -int __init mx23_clocks_init(void) +static void __init mx23_clocks_init(struct device_node *np) { -

Re: [PATCH RFC v2 08/16] ARM: mxs: remove custom .init_time hook

2013-08-29 Thread Sebastian Hesselbarth
On 08/29/13 13:08, Shawn Guo wrote: On Tue, Aug 27, 2013 at 11:28:02PM +0200, Sebastian Hesselbarth wrote: @@ -100,19 +101,17 @@ static enum imx23_clk clks_init_on[] __initdata = { cpu, hbus, xbus, emi, uart, }; -int __init mx23_clocks_init(void) +static void __init

Re: [PATCH RFC v2 08/16] ARM: mxs: remove custom .init_time hook

2013-08-29 Thread Shawn Guo
On Thu, Aug 29, 2013 at 01:32:33PM +0200, Sebastian Hesselbarth wrote: Ok, will take care of it. I assume you are fine with having an extra struct device_node pointer for the sake of readability instead of reusing the same pointer. Yeah, something like np_digctl for digctl node. Thanks for

Re: [PATCH RFC v2 08/16] ARM: mxs: remove custom .init_time hook

2013-08-27 Thread Mike Turquette
Quoting Sebastian Hesselbarth (2013-08-27 14:28:02) > This patch converts clk-imx2[38] clocksource_of_init compatible init > associated with fsl,imx2[38]-clkctrl. With arch/arm calling > of_clk_init(NULL) from time_init(), we can now also remove custom > .init_time hooks. > > Signed-off-by:

[PATCH RFC v2 08/16] ARM: mxs: remove custom .init_time hook

2013-08-27 Thread Sebastian Hesselbarth
This patch converts clk-imx2[38] clocksource_of_init compatible init associated with fsl,imx2[38]-clkctrl. With arch/arm calling of_clk_init(NULL) from time_init(), we can now also remove custom .init_time hooks. Signed-off-by: Sebastian Hesselbarth --- Cc: Shawn Guo Cc: Mike Turquette Cc:

[PATCH RFC v2 08/16] ARM: mxs: remove custom .init_time hook

2013-08-27 Thread Sebastian Hesselbarth
This patch converts clk-imx2[38] clocksource_of_init compatible init associated with fsl,imx2[38]-clkctrl. With arch/arm calling of_clk_init(NULL) from time_init(), we can now also remove custom .init_time hooks. Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com --- Cc: Shawn

Re: [PATCH RFC v2 08/16] ARM: mxs: remove custom .init_time hook

2013-08-27 Thread Mike Turquette
Quoting Sebastian Hesselbarth (2013-08-27 14:28:02) This patch converts clk-imx2[38] clocksource_of_init compatible init associated with fsl,imx2[38]-clkctrl. With arch/arm calling of_clk_init(NULL) from time_init(), we can now also remove custom .init_time hooks. Signed-off-by: Sebastian