Re: [PATCH RFCv2] arm64: eBPF JIT compiler

2014-07-10 Thread Alexei Starovoitov
On Wed, Jul 9, 2014 at 3:00 PM, Will Deacon wrote: > On Tue, Jul 08, 2014 at 08:06:53AM +0100, Zi Shen Lim wrote: >> >> 1. Implement remaining classes of eBPF instructions: ST|MEM, STX|XADD >>which currently do not have corresponding test cases in test_bpf. > > I can help out with atomics, if

Re: [PATCH RFCv2] arm64: eBPF JIT compiler

2014-07-10 Thread Alexei Starovoitov
On Wed, Jul 9, 2014 at 3:00 PM, Will Deacon will.dea...@arm.com wrote: On Tue, Jul 08, 2014 at 08:06:53AM +0100, Zi Shen Lim wrote: 1. Implement remaining classes of eBPF instructions: ST|MEM, STX|XADD which currently do not have corresponding test cases in test_bpf. I can help out with

Re: [PATCH RFCv2] arm64: eBPF JIT compiler

2014-07-09 Thread Will Deacon
On Tue, Jul 08, 2014 at 08:06:53AM +0100, Zi Shen Lim wrote: > * Per discussion with Will, I'll also look into consolidating > bpf_jit.h into arch/arm64/kernel/insn.{c,h}. I'm happy to review this once you have something ready. > FUTURE WORK: > > 1. Implement remaining classes of eBPF

Re: [PATCH RFCv2] arm64: eBPF JIT compiler

2014-07-09 Thread Will Deacon
On Tue, Jul 08, 2014 at 08:06:53AM +0100, Zi Shen Lim wrote: * Per discussion with Will, I'll also look into consolidating bpf_jit.h into arch/arm64/kernel/insn.{c,h}. I'm happy to review this once you have something ready. FUTURE WORK: 1. Implement remaining classes of eBPF

Re: [PATCH RFCv2] arm64: eBPF JIT compiler

2014-07-08 Thread Z Lim
On Tue, Jul 8, 2014 at 2:24 AM, Alexei Starovoitov wrote: > On Tue, Jul 8, 2014 at 12:06 AM, Zi Shen Lim wrote: [...] >> Also, per discussion with Alexei, and additional suggestion from >> Daniel: >> - moved load_pointer() from net/core/filter.c into filter.h >> as bpf_load_pointer()

Re: [PATCH RFCv2] arm64: eBPF JIT compiler

2014-07-08 Thread Alexei Starovoitov
On Tue, Jul 8, 2014 at 12:06 AM, Zi Shen Lim wrote: > The JIT compiler emits A64 instructions. It supports eBPF only. > Legacy BPF is supported thanks to conversion by BPF core. > > JIT is enabled in the same way as for other architectures: > > echo 1 > /proc/sys/net/core/bpf_jit_enable >

[PATCH RFCv2] arm64: eBPF JIT compiler

2014-07-08 Thread Zi Shen Lim
The JIT compiler emits A64 instructions. It supports eBPF only. Legacy BPF is supported thanks to conversion by BPF core. JIT is enabled in the same way as for other architectures: echo 1 > /proc/sys/net/core/bpf_jit_enable Or for additional compiler output: echo 2 >

[PATCH RFCv2] arm64: eBPF JIT compiler

2014-07-08 Thread Zi Shen Lim
The JIT compiler emits A64 instructions. It supports eBPF only. Legacy BPF is supported thanks to conversion by BPF core. JIT is enabled in the same way as for other architectures: echo 1 /proc/sys/net/core/bpf_jit_enable Or for additional compiler output: echo 2

Re: [PATCH RFCv2] arm64: eBPF JIT compiler

2014-07-08 Thread Alexei Starovoitov
On Tue, Jul 8, 2014 at 12:06 AM, Zi Shen Lim zlim@gmail.com wrote: The JIT compiler emits A64 instructions. It supports eBPF only. Legacy BPF is supported thanks to conversion by BPF core. JIT is enabled in the same way as for other architectures: echo 1

Re: [PATCH RFCv2] arm64: eBPF JIT compiler

2014-07-08 Thread Z Lim
On Tue, Jul 8, 2014 at 2:24 AM, Alexei Starovoitov a...@plumgrid.com wrote: On Tue, Jul 8, 2014 at 12:06 AM, Zi Shen Lim zlim@gmail.com wrote: [...] Also, per discussion with Alexei, and additional suggestion from Daniel: - moved load_pointer() from net/core/filter.c into filter.h