Re: [PATCH RFT 1/2] pinctrl: dove: Fix dove_audio1_ctrl_set when BIT(0|1|2|3) of config is clear

2012-11-16 Thread Axel Lin
> pinctrl for Dove will not be enabled before DT clock support for Dove, > which will hopefully make it into 3.8. If you agree, I will test and push it > with the related patches for enabling pinctrl. Ok. Thanks. Axel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH RFT 1/2] pinctrl: dove: Fix dove_audio1_ctrl_set when BIT(0|1|2|3) of config is clear

2012-11-16 Thread Sebastian Hesselbarth
On 11/16/2012 10:12 AM, Axel Lin wrote: 2012/11/12 Sebastian Hesselbarth: On 11/11/2012 02:44 PM, Axel Lin wrote: Current implementation in dove_audio1_ctrl_set() does not clear corresponding register bit if BIT(0|1|2|3) of config is clear. Fix it. Signed-off-by: Axel Lin Axel, thanks

Re: [PATCH RFT 1/2] pinctrl: dove: Fix dove_audio1_ctrl_set when BIT(0|1|2|3) of config is clear

2012-11-16 Thread Axel Lin
2012/11/12 Sebastian Hesselbarth : > On 11/11/2012 02:44 PM, Axel Lin wrote: >> >> Current implementation in dove_audio1_ctrl_set() does not clear >> corresponding >> register bit if BIT(0|1|2|3) of config is clear. Fix it. >> >> Signed-off-by: Axel Lin > > > Axel, > > thanks for the hint on not

Re: [PATCH RFT 1/2] pinctrl: dove: Fix dove_audio1_ctrl_set when BIT(0|1|2|3) of config is clear

2012-11-16 Thread Axel Lin
2012/11/12 Sebastian Hesselbarth sebastian.hesselba...@gmail.com: On 11/11/2012 02:44 PM, Axel Lin wrote: Current implementation in dove_audio1_ctrl_set() does not clear corresponding register bit if BIT(0|1|2|3) of config is clear. Fix it. Signed-off-by: Axel Linaxel@ingics.com

Re: [PATCH RFT 1/2] pinctrl: dove: Fix dove_audio1_ctrl_set when BIT(0|1|2|3) of config is clear

2012-11-16 Thread Sebastian Hesselbarth
On 11/16/2012 10:12 AM, Axel Lin wrote: 2012/11/12 Sebastian Hesselbarthsebastian.hesselba...@gmail.com: On 11/11/2012 02:44 PM, Axel Lin wrote: Current implementation in dove_audio1_ctrl_set() does not clear corresponding register bit if BIT(0|1|2|3) of config is clear. Fix it.

Re: [PATCH RFT 1/2] pinctrl: dove: Fix dove_audio1_ctrl_set when BIT(0|1|2|3) of config is clear

2012-11-16 Thread Axel Lin
pinctrl for Dove will not be enabled before DT clock support for Dove, which will hopefully make it into 3.8. If you agree, I will test and push it with the related patches for enabling pinctrl. Ok. Thanks. Axel -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the

Re: [PATCH RFT 1/2] pinctrl: dove: Fix dove_audio1_ctrl_set when BIT(0|1|2|3) of config is clear

2012-11-12 Thread Sebastian Hesselbarth
On 11/11/2012 02:44 PM, Axel Lin wrote: Current implementation in dove_audio1_ctrl_set() does not clear corresponding register bit if BIT(0|1|2|3) of config is clear. Fix it. Signed-off-by: Axel Lin Axel, thanks for the hint on not clearing the audio1 bits before setting them. I will test

Re: [PATCH RFT 1/2] pinctrl: dove: Fix dove_audio1_ctrl_set when BIT(0|1|2|3) of config is clear

2012-11-12 Thread Sebastian Hesselbarth
On 11/11/2012 02:44 PM, Axel Lin wrote: Current implementation in dove_audio1_ctrl_set() does not clear corresponding register bit if BIT(0|1|2|3) of config is clear. Fix it. Signed-off-by: Axel Linaxel@ingics.com Axel, thanks for the hint on not clearing the audio1 bits before setting

[PATCH RFT 1/2] pinctrl: dove: Fix dove_audio1_ctrl_set when BIT(0|1|2|3) of config is clear

2012-11-11 Thread Axel Lin
Current implementation in dove_audio1_ctrl_set() does not clear corresponding register bit if BIT(0|1|2|3) of config is clear. Fix it. Signed-off-by: Axel Lin --- Hi, I don't have this hardware. I'd appreciate if someone can review and test this patch. This resend also CC Sebastian Hesselbarth

Re: [PATCH RFT 1/2] pinctrl: dove: Fix dove_audio1_ctrl_set when BIT(0|1|2|3) of config is clear

2012-11-11 Thread Thomas Petazzoni
Axel, On Sun, 11 Nov 2012 07:28:04 +0800, Axel Lin wrote: > Current implementation in dove_audio1_ctrl_set() does not clear corresponding > register bit if BIT(0|1|2|3) of config is clear. Fix it. > > Signed-off-by: Axel Lin > --- > Hi, > I don't have this hardware. > I'd appreciate if someone

Re: [PATCH RFT 1/2] pinctrl: dove: Fix dove_audio1_ctrl_set when BIT(0|1|2|3) of config is clear

2012-11-11 Thread Thomas Petazzoni
Axel, On Sun, 11 Nov 2012 07:28:04 +0800, Axel Lin wrote: Current implementation in dove_audio1_ctrl_set() does not clear corresponding register bit if BIT(0|1|2|3) of config is clear. Fix it. Signed-off-by: Axel Lin axel@ingics.com --- Hi, I don't have this hardware. I'd appreciate

[PATCH RFT 1/2] pinctrl: dove: Fix dove_audio1_ctrl_set when BIT(0|1|2|3) of config is clear

2012-11-11 Thread Axel Lin
Current implementation in dove_audio1_ctrl_set() does not clear corresponding register bit if BIT(0|1|2|3) of config is clear. Fix it. Signed-off-by: Axel Lin axel@ingics.com --- Hi, I don't have this hardware. I'd appreciate if someone can review and test this patch. This resend also CC

[PATCH RFT 1/2] pinctrl: dove: Fix dove_audio1_ctrl_set when BIT(0|1|2|3) of config is clear

2012-11-10 Thread Axel Lin
Current implementation in dove_audio1_ctrl_set() does not clear corresponding register bit if BIT(0|1|2|3) of config is clear. Fix it. Signed-off-by: Axel Lin --- Hi, I don't have this hardware. I'd appreciate if someone can review and test this patch. Thanks, Axel

[PATCH RFT 1/2] pinctrl: dove: Fix dove_audio1_ctrl_set when BIT(0|1|2|3) of config is clear

2012-11-10 Thread Axel Lin
Current implementation in dove_audio1_ctrl_set() does not clear corresponding register bit if BIT(0|1|2|3) of config is clear. Fix it. Signed-off-by: Axel Lin axel@ingics.com --- Hi, I don't have this hardware. I'd appreciate if someone can review and test this patch. Thanks, Axel