Re: [PATCH RFT 2/2] pinctrl: dove: Checking valid config in dove_audio1_ctrl_set

2012-11-12 Thread Sebastian Hesselbarth
On 11/11/2012 02:46 PM, Axel Lin wrote: Move the code checking valid config to dove_audio1_ctrl_set(), this ensures we always set valid config. And then dove_audio1_ctrl_get() always returns correct config. Signed-off-by: Axel Lin Axel, although correct in a software point-of-view, I don't

Re: [PATCH RFT 2/2] pinctrl: dove: Checking valid config in dove_audio1_ctrl_set

2012-11-12 Thread Sebastian Hesselbarth
On 11/11/2012 02:46 PM, Axel Lin wrote: Move the code checking valid config to dove_audio1_ctrl_set(), this ensures we always set valid config. And then dove_audio1_ctrl_get() always returns correct config. Signed-off-by: Axel Linaxel@ingics.com Axel, although correct in a software

[PATCH RFT 2/2] pinctrl: dove: Checking valid config in dove_audio1_ctrl_set

2012-11-11 Thread Axel Lin
Move the code checking valid config to dove_audio1_ctrl_set(), this ensures we always set valid config. And then dove_audio1_ctrl_get() always returns correct config. Signed-off-by: Axel Lin --- drivers/pinctrl/mvebu/pinctrl-dove.c | 13 +++-- 1 file changed, 7 insertions(+), 6

[PATCH RFT 2/2] pinctrl: dove: Checking valid config in dove_audio1_ctrl_set

2012-11-11 Thread Axel Lin
Move the code checking valid config to dove_audio1_ctrl_set(), this ensures we always set valid config. And then dove_audio1_ctrl_get() always returns correct config. Signed-off-by: Axel Lin axel@ingics.com --- drivers/pinctrl/mvebu/pinctrl-dove.c | 13 +++-- 1 file changed, 7

[PATCH RFT 2/2] pinctrl: dove: Checking valid config in dove_audio1_ctrl_set

2012-11-10 Thread Axel Lin
Move the code checking valid config to dove_audio1_ctrl_set(), this ensures we always set valid config. And then dove_audio1_ctrl_get() always returns correct config. Signed-off-by: Axel Lin --- drivers/pinctrl/mvebu/pinctrl-dove.c | 13 +++-- 1 file changed, 7 insertions(+), 6

[PATCH RFT 2/2] pinctrl: dove: Checking valid config in dove_audio1_ctrl_set

2012-11-10 Thread Axel Lin
Move the code checking valid config to dove_audio1_ctrl_set(), this ensures we always set valid config. And then dove_audio1_ctrl_get() always returns correct config. Signed-off-by: Axel Lin axel@ingics.com --- drivers/pinctrl/mvebu/pinctrl-dove.c | 13 +++-- 1 file changed, 7