Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-04-04 Thread Lionel DEBIEVE
Hi, Looking at the thread discussion, except architecture discussion around the IRQF_ONESHOT, I think it could go to upstream too. I'll re-upload patch for upstream. Thanks for reviewing. BR, Lionel On 03/30/2017 09:54 AM, Lee Jones wrote: > On Wed, 29 Mar 2017, Sebastian Andrzej Siewior

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-04-04 Thread Lionel DEBIEVE
Hi, Looking at the thread discussion, except architecture discussion around the IRQF_ONESHOT, I think it could go to upstream too. I'll re-upload patch for upstream. Thanks for reviewing. BR, Lionel On 03/30/2017 09:54 AM, Lee Jones wrote: > On Wed, 29 Mar 2017, Sebastian Andrzej Siewior

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-30 Thread Lee Jones
On Wed, 29 Mar 2017, Sebastian Andrzej Siewior wrote: > On 2017-03-22 09:05:58 [-0700], Steven Rostedt wrote: > > On Wed, 22 Mar 2017 16:18:43 +0100 > > Lionel Debieve wrote: > > > > > Use raw_spin_lock in enable/disable channel as it comes from > > > interrupt context. >

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-30 Thread Lee Jones
On Wed, 29 Mar 2017, Sebastian Andrzej Siewior wrote: > On 2017-03-22 09:05:58 [-0700], Steven Rostedt wrote: > > On Wed, 22 Mar 2017 16:18:43 +0100 > > Lionel Debieve wrote: > > > > > Use raw_spin_lock in enable/disable channel as it comes from > > > interrupt context. > > > > > > BUG:

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-29 Thread Sebastian Andrzej Siewior
On 2017-03-22 09:05:58 [-0700], Steven Rostedt wrote: > On Wed, 22 Mar 2017 16:18:43 +0100 > Lionel Debieve wrote: > > > Use raw_spin_lock in enable/disable channel as it comes from > > interrupt context. > > > > BUG: sleeping function called from invalid context at > >

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-29 Thread Sebastian Andrzej Siewior
On 2017-03-22 09:05:58 [-0700], Steven Rostedt wrote: > On Wed, 22 Mar 2017 16:18:43 +0100 > Lionel Debieve wrote: > > > Use raw_spin_lock in enable/disable channel as it comes from > > interrupt context. > > > > BUG: sleeping function called from invalid context at > >

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-28 Thread Lee Jones
On Thu, 23 Mar 2017, Julia Cartwright wrote: > On Thu, Mar 23, 2017 at 10:26:49AM +, Lee Jones wrote: > > On Thu, 23 Mar 2017, Lionel DEBIEVE wrote: > > > > > On 03/22/2017 07:47 PM, Julia Cartwright wrote: > > > > On Wed, Mar 22, 2017 at 01:30:12PM -0500, Grygorii Strashko wrote: > > > >>

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-28 Thread Lee Jones
On Thu, 23 Mar 2017, Julia Cartwright wrote: > On Thu, Mar 23, 2017 at 10:26:49AM +, Lee Jones wrote: > > On Thu, 23 Mar 2017, Lionel DEBIEVE wrote: > > > > > On 03/22/2017 07:47 PM, Julia Cartwright wrote: > > > > On Wed, Mar 22, 2017 at 01:30:12PM -0500, Grygorii Strashko wrote: > > > >>

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-24 Thread Thomas Gleixner
On Wed, 22 Mar 2017, Julia Cartwright wrote: > On Wed, Mar 22, 2017 at 01:30:12PM -0500, Grygorii Strashko wrote: > > It will not be threaded because there are IRQF_ONESHOT used. > > > > ret = devm_request_threaded_irq(>dev, irq, > > sti_mbox_irq_handler, >

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-24 Thread Thomas Gleixner
On Wed, 22 Mar 2017, Julia Cartwright wrote: > On Wed, Mar 22, 2017 at 01:30:12PM -0500, Grygorii Strashko wrote: > > It will not be threaded because there are IRQF_ONESHOT used. > > > > ret = devm_request_threaded_irq(>dev, irq, > > sti_mbox_irq_handler, >

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-23 Thread Julia Cartwright
On Thu, Mar 23, 2017 at 10:26:49AM +, Lee Jones wrote: > On Thu, 23 Mar 2017, Lionel DEBIEVE wrote: > > > On 03/22/2017 07:47 PM, Julia Cartwright wrote: > > > On Wed, Mar 22, 2017 at 01:30:12PM -0500, Grygorii Strashko wrote: > > >> On 03/22/2017 01:01 PM, Steven Rostedt wrote: > > >>> On

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-23 Thread Julia Cartwright
On Thu, Mar 23, 2017 at 10:26:49AM +, Lee Jones wrote: > On Thu, 23 Mar 2017, Lionel DEBIEVE wrote: > > > On 03/22/2017 07:47 PM, Julia Cartwright wrote: > > > On Wed, Mar 22, 2017 at 01:30:12PM -0500, Grygorii Strashko wrote: > > >> On 03/22/2017 01:01 PM, Steven Rostedt wrote: > > >>> On

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-23 Thread Lee Jones
On Thu, 23 Mar 2017, Lionel DEBIEVE wrote: > On 03/22/2017 07:47 PM, Julia Cartwright wrote: > > On Wed, Mar 22, 2017 at 01:30:12PM -0500, Grygorii Strashko wrote: > >> On 03/22/2017 01:01 PM, Steven Rostedt wrote: > >>> On Wed, 22 Mar 2017 12:37:59 -0500 > >>> Julia Cartwright

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-23 Thread Lee Jones
On Thu, 23 Mar 2017, Lionel DEBIEVE wrote: > On 03/22/2017 07:47 PM, Julia Cartwright wrote: > > On Wed, Mar 22, 2017 at 01:30:12PM -0500, Grygorii Strashko wrote: > >> On 03/22/2017 01:01 PM, Steven Rostedt wrote: > >>> On Wed, 22 Mar 2017 12:37:59 -0500 > >>> Julia Cartwright wrote: > >>> >

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-23 Thread Lionel DEBIEVE
On 03/22/2017 07:47 PM, Julia Cartwright wrote: > On Wed, Mar 22, 2017 at 01:30:12PM -0500, Grygorii Strashko wrote: >> On 03/22/2017 01:01 PM, Steven Rostedt wrote: >>> On Wed, 22 Mar 2017 12:37:59 -0500 >>> Julia Cartwright wrote: >>> Which kernel were you testing on, here?

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-23 Thread Lionel DEBIEVE
On 03/22/2017 07:47 PM, Julia Cartwright wrote: > On Wed, Mar 22, 2017 at 01:30:12PM -0500, Grygorii Strashko wrote: >> On 03/22/2017 01:01 PM, Steven Rostedt wrote: >>> On Wed, 22 Mar 2017 12:37:59 -0500 >>> Julia Cartwright wrote: >>> Which kernel were you testing on, here? From what I

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-22 Thread Julia Cartwright
On Wed, Mar 22, 2017 at 01:30:12PM -0500, Grygorii Strashko wrote: > > On 03/22/2017 01:01 PM, Steven Rostedt wrote: > > On Wed, 22 Mar 2017 12:37:59 -0500 > > Julia Cartwright wrote: > > > > > Which kernel were you testing on, here? From what I can tell, this > > > should have

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-22 Thread Julia Cartwright
On Wed, Mar 22, 2017 at 01:30:12PM -0500, Grygorii Strashko wrote: > > On 03/22/2017 01:01 PM, Steven Rostedt wrote: > > On Wed, 22 Mar 2017 12:37:59 -0500 > > Julia Cartwright wrote: > > > > > Which kernel were you testing on, here? From what I can tell, this > > > should have been fixed with

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-22 Thread Grygorii Strashko
On 03/22/2017 01:01 PM, Steven Rostedt wrote: On Wed, 22 Mar 2017 12:37:59 -0500 Julia Cartwright wrote: Which kernel were you testing on, here? From what I can tell, this should have been fixed with Thomas's commit: 2a1d3ab8986d ("genirq: Handle force threading of irqs

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-22 Thread Grygorii Strashko
On 03/22/2017 01:01 PM, Steven Rostedt wrote: On Wed, 22 Mar 2017 12:37:59 -0500 Julia Cartwright wrote: Which kernel were you testing on, here? From what I can tell, this should have been fixed with Thomas's commit: 2a1d3ab8986d ("genirq: Handle force threading of irqs with primary and

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-22 Thread Steven Rostedt
On Wed, 22 Mar 2017 12:37:59 -0500 Julia Cartwright wrote: > Which kernel were you testing on, here? From what I can tell, this > should have been fixed with Thomas's commit: > >2a1d3ab8986d ("genirq: Handle force threading of irqs with primary > and thread handler") Thanks

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-22 Thread Steven Rostedt
On Wed, 22 Mar 2017 12:37:59 -0500 Julia Cartwright wrote: > Which kernel were you testing on, here? From what I can tell, this > should have been fixed with Thomas's commit: > >2a1d3ab8986d ("genirq: Handle force threading of irqs with primary > and thread handler") Thanks Julia for

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-22 Thread Julia Cartwright
On Wed, Mar 22, 2017 at 04:18:43PM +0100, Lionel Debieve wrote: > Use raw_spin_lock in enable/disable channel as it comes from > interrupt context. > > BUG: sleeping function called from invalid context at > kernel/locking/rtmutex.c:995 > in_atomic(): 1, irqs_disabled(): 128, pid: 307, name:

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-22 Thread Julia Cartwright
On Wed, Mar 22, 2017 at 04:18:43PM +0100, Lionel Debieve wrote: > Use raw_spin_lock in enable/disable channel as it comes from > interrupt context. > > BUG: sleeping function called from invalid context at > kernel/locking/rtmutex.c:995 > in_atomic(): 1, irqs_disabled(): 128, pid: 307, name:

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-22 Thread Lionel DEBIEVE
On 03/22/2017 05:05 PM, Steven Rostedt wrote: > On Wed, 22 Mar 2017 16:18:43 +0100 > Lionel Debieve wrote: > >> Use raw_spin_lock in enable/disable channel as it comes from >> interrupt context. >> >> BUG: sleeping function called from invalid context at >>

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-22 Thread Lionel DEBIEVE
On 03/22/2017 05:05 PM, Steven Rostedt wrote: > On Wed, 22 Mar 2017 16:18:43 +0100 > Lionel Debieve wrote: > >> Use raw_spin_lock in enable/disable channel as it comes from >> interrupt context. >> >> BUG: sleeping function called from invalid context at >> kernel/locking/rtmutex.c:995 >>

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-22 Thread Steven Rostedt
On Wed, 22 Mar 2017 16:18:43 +0100 Lionel Debieve wrote: > Use raw_spin_lock in enable/disable channel as it comes from > interrupt context. > > BUG: sleeping function called from invalid context at > kernel/locking/rtmutex.c:995 > in_atomic(): 1, irqs_disabled(): 128,

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-22 Thread Steven Rostedt
On Wed, 22 Mar 2017 16:18:43 +0100 Lionel Debieve wrote: > Use raw_spin_lock in enable/disable channel as it comes from > interrupt context. > > BUG: sleeping function called from invalid context at > kernel/locking/rtmutex.c:995 > in_atomic(): 1, irqs_disabled(): 128, pid: 307, name:

[PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-22 Thread Lionel Debieve
Use raw_spin_lock in enable/disable channel as it comes from interrupt context. BUG: sleeping function called from invalid context at kernel/locking/rtmutex.c:995 in_atomic(): 1, irqs_disabled(): 128, pid: 307, name: pulseaudio Preemption disabled at: [] __handle_domain_irq+0x4c/0xec CPU: 0 PID:

[PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-22 Thread Lionel Debieve
Use raw_spin_lock in enable/disable channel as it comes from interrupt context. BUG: sleeping function called from invalid context at kernel/locking/rtmutex.c:995 in_atomic(): 1, irqs_disabled(): 128, pid: 307, name: pulseaudio Preemption disabled at: [] __handle_domain_irq+0x4c/0xec CPU: 0 PID: