Re: [PATCH V17 2/3] dmaengine: qcom_hidma: add debugfs hooks

2016-05-02 Thread Mark Brown
On Mon, May 02, 2016 at 02:55:52PM +0530, Vinod Koul wrote: > On Sun, May 01, 2016 at 12:35:37AM -0400, Sinan Kaya wrote: > > My evaluation turned out negative. The regmap code is nice for bus like > > peripherals > > like I2C and SPI where everything is bitwise accessed. This is not the case >

Re: [PATCH V17 2/3] dmaengine: qcom_hidma: add debugfs hooks

2016-05-02 Thread Mark Brown
On Mon, May 02, 2016 at 02:55:52PM +0530, Vinod Koul wrote: > On Sun, May 01, 2016 at 12:35:37AM -0400, Sinan Kaya wrote: > > My evaluation turned out negative. The regmap code is nice for bus like > > peripherals > > like I2C and SPI where everything is bitwise accessed. This is not the case >

Re: [PATCH V17 2/3] dmaengine: qcom_hidma: add debugfs hooks

2016-05-02 Thread Vinod Koul
On Sun, May 01, 2016 at 12:35:37AM -0400, Sinan Kaya wrote: > >>> > > >>> > Hmm, have you thought about using regmap? > >>> > >>> To be honest, I didn't know what regmap is but I just read some code > >>> and looked at how it is used. Feel free to correct me if I got it > >>> wrong. > >>> > >>>

Re: [PATCH V17 2/3] dmaengine: qcom_hidma: add debugfs hooks

2016-05-02 Thread Vinod Koul
On Sun, May 01, 2016 at 12:35:37AM -0400, Sinan Kaya wrote: > >>> > > >>> > Hmm, have you thought about using regmap? > >>> > >>> To be honest, I didn't know what regmap is but I just read some code > >>> and looked at how it is used. Feel free to correct me if I got it > >>> wrong. > >>> > >>>

Re: [PATCH V17 2/3] dmaengine: qcom_hidma: add debugfs hooks

2016-04-30 Thread Sinan Kaya
On 4/27/2016 8:51 AM, ok...@codeaurora.org wrote: > On 2016-04-27 04:15, Vinod Koul wrote: >> On Tue, Apr 26, 2016 at 12:55:18PM -0400, Sinan Kaya wrote: >>> On 4/26/2016 12:25 PM, Vinod Koul wrote: >>> > On Tue, Apr 26, 2016 at 08:08:16AM -0400, ok...@codeaurora.org wrote: >>> >> On 2016-04-25

Re: [PATCH V17 2/3] dmaengine: qcom_hidma: add debugfs hooks

2016-04-30 Thread Sinan Kaya
On 4/27/2016 8:51 AM, ok...@codeaurora.org wrote: > On 2016-04-27 04:15, Vinod Koul wrote: >> On Tue, Apr 26, 2016 at 12:55:18PM -0400, Sinan Kaya wrote: >>> On 4/26/2016 12:25 PM, Vinod Koul wrote: >>> > On Tue, Apr 26, 2016 at 08:08:16AM -0400, ok...@codeaurora.org wrote: >>> >> On 2016-04-25

Re: [PATCH V17 2/3] dmaengine: qcom_hidma: add debugfs hooks

2016-04-27 Thread okaya
On 2016-04-27 04:47, Marc Zyngier wrote: On 27/04/16 09:15, Vinod Koul wrote: On Tue, Apr 26, 2016 at 12:55:18PM -0400, Sinan Kaya wrote: On 4/26/2016 12:25 PM, Vinod Koul wrote: On Tue, Apr 26, 2016 at 08:08:16AM -0400, ok...@codeaurora.org wrote: On 2016-04-25 23:30, Vinod Koul wrote: On

Re: [PATCH V17 2/3] dmaengine: qcom_hidma: add debugfs hooks

2016-04-27 Thread okaya
On 2016-04-27 04:47, Marc Zyngier wrote: On 27/04/16 09:15, Vinod Koul wrote: On Tue, Apr 26, 2016 at 12:55:18PM -0400, Sinan Kaya wrote: On 4/26/2016 12:25 PM, Vinod Koul wrote: On Tue, Apr 26, 2016 at 08:08:16AM -0400, ok...@codeaurora.org wrote: On 2016-04-25 23:30, Vinod Koul wrote: On

Re: [PATCH V17 2/3] dmaengine: qcom_hidma: add debugfs hooks

2016-04-27 Thread okaya
On 2016-04-27 04:15, Vinod Koul wrote: On Tue, Apr 26, 2016 at 12:55:18PM -0400, Sinan Kaya wrote: On 4/26/2016 12:25 PM, Vinod Koul wrote: > On Tue, Apr 26, 2016 at 08:08:16AM -0400, ok...@codeaurora.org wrote: >> On 2016-04-25 23:30, Vinod Koul wrote: >>> On Mon, Apr 11, 2016 at 10:21:12AM

Re: [PATCH V17 2/3] dmaengine: qcom_hidma: add debugfs hooks

2016-04-27 Thread okaya
On 2016-04-27 04:15, Vinod Koul wrote: On Tue, Apr 26, 2016 at 12:55:18PM -0400, Sinan Kaya wrote: On 4/26/2016 12:25 PM, Vinod Koul wrote: > On Tue, Apr 26, 2016 at 08:08:16AM -0400, ok...@codeaurora.org wrote: >> On 2016-04-25 23:30, Vinod Koul wrote: >>> On Mon, Apr 11, 2016 at 10:21:12AM

Re: [PATCH V17 2/3] dmaengine: qcom_hidma: add debugfs hooks

2016-04-27 Thread Marc Zyngier
On 27/04/16 09:15, Vinod Koul wrote: > On Tue, Apr 26, 2016 at 12:55:18PM -0400, Sinan Kaya wrote: >> On 4/26/2016 12:25 PM, Vinod Koul wrote: >>> On Tue, Apr 26, 2016 at 08:08:16AM -0400, ok...@codeaurora.org wrote: On 2016-04-25 23:30, Vinod Koul wrote: > On Mon, Apr 11, 2016 at

Re: [PATCH V17 2/3] dmaengine: qcom_hidma: add debugfs hooks

2016-04-27 Thread Marc Zyngier
On 27/04/16 09:15, Vinod Koul wrote: > On Tue, Apr 26, 2016 at 12:55:18PM -0400, Sinan Kaya wrote: >> On 4/26/2016 12:25 PM, Vinod Koul wrote: >>> On Tue, Apr 26, 2016 at 08:08:16AM -0400, ok...@codeaurora.org wrote: On 2016-04-25 23:30, Vinod Koul wrote: > On Mon, Apr 11, 2016 at

Re: [PATCH V17 2/3] dmaengine: qcom_hidma: add debugfs hooks

2016-04-27 Thread Vinod Koul
On Tue, Apr 26, 2016 at 12:55:18PM -0400, Sinan Kaya wrote: > On 4/26/2016 12:25 PM, Vinod Koul wrote: > > On Tue, Apr 26, 2016 at 08:08:16AM -0400, ok...@codeaurora.org wrote: > >> On 2016-04-25 23:30, Vinod Koul wrote: > >>> On Mon, Apr 11, 2016 at 10:21:12AM -0400, Sinan Kaya wrote: > >>> >

Re: [PATCH V17 2/3] dmaengine: qcom_hidma: add debugfs hooks

2016-04-27 Thread Vinod Koul
On Tue, Apr 26, 2016 at 12:55:18PM -0400, Sinan Kaya wrote: > On 4/26/2016 12:25 PM, Vinod Koul wrote: > > On Tue, Apr 26, 2016 at 08:08:16AM -0400, ok...@codeaurora.org wrote: > >> On 2016-04-25 23:30, Vinod Koul wrote: > >>> On Mon, Apr 11, 2016 at 10:21:12AM -0400, Sinan Kaya wrote: > >>> >

Re: [PATCH V17 2/3] dmaengine: qcom_hidma: add debugfs hooks

2016-04-26 Thread Sinan Kaya
On 4/26/2016 12:25 PM, Vinod Koul wrote: > On Tue, Apr 26, 2016 at 08:08:16AM -0400, ok...@codeaurora.org wrote: >> On 2016-04-25 23:30, Vinod Koul wrote: >>> On Mon, Apr 11, 2016 at 10:21:12AM -0400, Sinan Kaya wrote: >>> +static int hidma_chan_stats(struct seq_file *s, void *unused) +{

Re: [PATCH V17 2/3] dmaengine: qcom_hidma: add debugfs hooks

2016-04-26 Thread Sinan Kaya
On 4/26/2016 12:25 PM, Vinod Koul wrote: > On Tue, Apr 26, 2016 at 08:08:16AM -0400, ok...@codeaurora.org wrote: >> On 2016-04-25 23:30, Vinod Koul wrote: >>> On Mon, Apr 11, 2016 at 10:21:12AM -0400, Sinan Kaya wrote: >>> +static int hidma_chan_stats(struct seq_file *s, void *unused) +{

Re: [PATCH V17 2/3] dmaengine: qcom_hidma: add debugfs hooks

2016-04-26 Thread Vinod Koul
On Tue, Apr 26, 2016 at 08:08:16AM -0400, ok...@codeaurora.org wrote: > On 2016-04-25 23:30, Vinod Koul wrote: > >On Mon, Apr 11, 2016 at 10:21:12AM -0400, Sinan Kaya wrote: > > > >>+static int hidma_chan_stats(struct seq_file *s, void *unused) > >>+{ > >>+ struct hidma_chan *mchan = s->private;

Re: [PATCH V17 2/3] dmaengine: qcom_hidma: add debugfs hooks

2016-04-26 Thread Vinod Koul
On Tue, Apr 26, 2016 at 08:08:16AM -0400, ok...@codeaurora.org wrote: > On 2016-04-25 23:30, Vinod Koul wrote: > >On Mon, Apr 11, 2016 at 10:21:12AM -0400, Sinan Kaya wrote: > > > >>+static int hidma_chan_stats(struct seq_file *s, void *unused) > >>+{ > >>+ struct hidma_chan *mchan = s->private;

Re: [PATCH V17 2/3] dmaengine: qcom_hidma: add debugfs hooks

2016-04-26 Thread okaya
On 2016-04-25 23:30, Vinod Koul wrote: On Mon, Apr 11, 2016 at 10:21:12AM -0400, Sinan Kaya wrote: +static int hidma_chan_stats(struct seq_file *s, void *unused) +{ + struct hidma_chan *mchan = s->private; + struct hidma_desc *mdesc; + struct hidma_dev *dmadev =

Re: [PATCH V17 2/3] dmaengine: qcom_hidma: add debugfs hooks

2016-04-26 Thread okaya
On 2016-04-25 23:30, Vinod Koul wrote: On Mon, Apr 11, 2016 at 10:21:12AM -0400, Sinan Kaya wrote: +static int hidma_chan_stats(struct seq_file *s, void *unused) +{ + struct hidma_chan *mchan = s->private; + struct hidma_desc *mdesc; + struct hidma_dev *dmadev =

Re: [PATCH V17 2/3] dmaengine: qcom_hidma: add debugfs hooks

2016-04-25 Thread Vinod Koul
On Mon, Apr 11, 2016 at 10:21:12AM -0400, Sinan Kaya wrote: > +static int hidma_chan_stats(struct seq_file *s, void *unused) > +{ > + struct hidma_chan *mchan = s->private; > + struct hidma_desc *mdesc; > + struct hidma_dev *dmadev = mchan->dmadev; > + > +

Re: [PATCH V17 2/3] dmaengine: qcom_hidma: add debugfs hooks

2016-04-25 Thread Vinod Koul
On Mon, Apr 11, 2016 at 10:21:12AM -0400, Sinan Kaya wrote: > +static int hidma_chan_stats(struct seq_file *s, void *unused) > +{ > + struct hidma_chan *mchan = s->private; > + struct hidma_desc *mdesc; > + struct hidma_dev *dmadev = mchan->dmadev; > + > +

[PATCH V17 2/3] dmaengine: qcom_hidma: add debugfs hooks

2016-04-11 Thread Sinan Kaya
Add debugfs hooks for debugging the execution behavior of the DMA channel. The debugfs hooks get initialized by the probe function and uninitialized by the remove function. A stats file is created in debugfs. The stats file will show the information about each HIDMA channel as well as each

[PATCH V17 2/3] dmaengine: qcom_hidma: add debugfs hooks

2016-04-11 Thread Sinan Kaya
Add debugfs hooks for debugging the execution behavior of the DMA channel. The debugfs hooks get initialized by the probe function and uninitialized by the remove function. A stats file is created in debugfs. The stats file will show the information about each HIDMA channel as well as each