Re: [PATCH V2] ndisc: Use more standard logging styles

2012-12-14 Thread Eric Dumazet
On Thu, 2012-12-13 at 20:23 -0800, Joe Perches wrote: > The logging style in this file is "baroque". > > Convert indirect uses of net__ratelimited to > simply use net__ratelimited. > > Add a nd_dbg macro and #define ND_DEBUG for the other > generally inactivated logging messages. > > Make those

Re: [PATCH V2] ndisc: Use more standard logging styles

2012-12-14 Thread Eric Dumazet
On Thu, 2012-12-13 at 20:23 -0800, Joe Perches wrote: The logging style in this file is baroque. Convert indirect uses of net_level_ratelimited to simply use net_level_ratelimited. Add a nd_dbg macro and #define ND_DEBUG for the other generally inactivated logging messages. Make those

[PATCH V2] ndisc: Use more standard logging styles

2012-12-13 Thread Joe Perches
The logging style in this file is "baroque". Convert indirect uses of net__ratelimited to simply use net__ratelimited. Add a nd_dbg macro and #define ND_DEBUG for the other generally inactivated logging messages. Make those inactivated messages emit only at KERN_DEBUG instead of other levels. 

[PATCH V2] ndisc: Use more standard logging styles

2012-12-13 Thread Joe Perches
The logging style in this file is baroque. Convert indirect uses of net_level_ratelimited to simply use net_level_ratelimited. Add a nd_dbg macro and #define ND_DEBUG for the other generally inactivated logging messages. Make those inactivated messages emit only at KERN_DEBUG instead of other