RE: [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events

2017-06-30 Thread Hunter, Adrian
-Original Message- From: Arnaldo Carvalho de Melo [mailto:a...@kernel.org] Sent: Friday, June 30, 2017 5:54 PM To: Hunter, Adrian <adrian.hun...@intel.com> Cc: Andi Kleen <a...@linux.intel.com>; linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 25/37] perf script: Add synth

RE: [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events

2017-06-30 Thread Hunter, Adrian
-Original Message- From: Arnaldo Carvalho de Melo [mailto:a...@kernel.org] Sent: Friday, June 30, 2017 5:54 PM To: Hunter, Adrian Cc: Andi Kleen ; linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events > Em Fri, Jun

Re: [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events

2017-06-30 Thread Arnaldo Carvalho de Melo
Em Fri, Jun 30, 2017 at 11:51:22AM +0300, Adrian Hunter escreveu: > On 06/30/2017 05:08 AM, Arnaldo Carvalho de Melo wrote: > > Em Thu, Jun 29, 2017 at 05:13:54PM -0300, Arnaldo Carvalho de Melo escreveu: > > Ok, passes all tests (gcc, clang where available) on: > > 41 ubuntu:16.10: Ok > > 42

Re: [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events

2017-06-30 Thread Arnaldo Carvalho de Melo
Em Fri, Jun 30, 2017 at 11:51:22AM +0300, Adrian Hunter escreveu: > On 06/30/2017 05:08 AM, Arnaldo Carvalho de Melo wrote: > > Em Thu, Jun 29, 2017 at 05:13:54PM -0300, Arnaldo Carvalho de Melo escreveu: > > Ok, passes all tests (gcc, clang where available) on: > > 41 ubuntu:16.10: Ok > > 42

Re: [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events

2017-06-30 Thread Adrian Hunter
On 06/30/2017 05:08 AM, Arnaldo Carvalho de Melo wrote: > Em Thu, Jun 29, 2017 at 05:13:54PM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Thu, Jun 29, 2017 at 10:56:25PM +0300, Adrian Hunter escreveu: >>> On 06/28/2017 11:26 PM, Arnaldo Carvalho de Melo wrote: Right, and I've not been able

Re: [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events

2017-06-30 Thread Adrian Hunter
On 06/30/2017 05:08 AM, Arnaldo Carvalho de Melo wrote: > Em Thu, Jun 29, 2017 at 05:13:54PM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Thu, Jun 29, 2017 at 10:56:25PM +0300, Adrian Hunter escreveu: >>> On 06/28/2017 11:26 PM, Arnaldo Carvalho de Melo wrote: Right, and I've not been able

Re: [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events

2017-06-29 Thread Arnaldo Carvalho de Melo
Em Thu, Jun 29, 2017 at 05:13:54PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Jun 29, 2017 at 10:56:25PM +0300, Adrian Hunter escreveu: > > On 06/28/2017 11:26 PM, Arnaldo Carvalho de Melo wrote: > > > Right, and I've not been able to focus on this, but I think the problem > > > is with

Re: [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events

2017-06-29 Thread Arnaldo Carvalho de Melo
Em Thu, Jun 29, 2017 at 05:13:54PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Jun 29, 2017 at 10:56:25PM +0300, Adrian Hunter escreveu: > > On 06/28/2017 11:26 PM, Arnaldo Carvalho de Melo wrote: > > > Right, and I've not been able to focus on this, but I think the problem > > > is with

Re: [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events

2017-06-29 Thread Arnaldo Carvalho de Melo
Em Thu, Jun 29, 2017 at 10:56:25PM +0300, Adrian Hunter escreveu: > On 06/28/2017 11:26 PM, Arnaldo Carvalho de Melo wrote: > > Em Wed, Jun 28, 2017 at 08:21:37PM +, Hunter, Adrian escreveu: > >> Sorry for the top-post... > >> > >> Yeah, I've now mixed up the variable attribute: > >> > >>

Re: [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events

2017-06-29 Thread Arnaldo Carvalho de Melo
Em Thu, Jun 29, 2017 at 10:56:25PM +0300, Adrian Hunter escreveu: > On 06/28/2017 11:26 PM, Arnaldo Carvalho de Melo wrote: > > Em Wed, Jun 28, 2017 at 08:21:37PM +, Hunter, Adrian escreveu: > >> Sorry for the top-post... > >> > >> Yeah, I've now mixed up the variable attribute: > >> > >>

Re: [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events

2017-06-29 Thread Adrian Hunter
_events_sample_type); > >> -Original Message- >> From: Arnaldo Carvalho de Melo [mailto:a...@kernel.org] >> Sent: Wednesday, June 28, 2017 9:54 PM >> To: Hunter, Adrian <adrian.hun...@intel.com> >> Cc: Andi Kleen <a...@linux.intel.com>; li

Re: [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events

2017-06-29 Thread Adrian Hunter
payload); - sample.raw_size = sizeof(raw); - sample.raw_data = + sample.raw_size = perf_synth__raw_size(raw); + sample.raw_data = perf_synth__raw_data(); return intel_pt_deliver_synth_event(pt, ptq, event, , pt->pwr

Re: [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events

2017-06-28 Thread Arnaldo Carvalho de Melo
unions :-\ - Arnaldo > -Original Message- > From: Arnaldo Carvalho de Melo [mailto:a...@kernel.org] > Sent: Wednesday, June 28, 2017 9:54 PM > To: Hunter, Adrian <adrian.hun...@intel.com> > Cc: Andi Kleen <a...@linux.intel.com>; linux-kernel@vger.kernel.org > Subj

Re: [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events

2017-06-28 Thread Arnaldo Carvalho de Melo
unions :-\ - Arnaldo > -Original Message- > From: Arnaldo Carvalho de Melo [mailto:a...@kernel.org] > Sent: Wednesday, June 28, 2017 9:54 PM > To: Hunter, Adrian > Cc: Andi Kleen ; linux-kernel@vger.kernel.org > Subject: Re: [PATCH V2 25/37] perf script: Add synthesized

RE: [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events

2017-06-28 Thread Hunter, Adrian
r.kernel.org Subject: Re: [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events Em Wed, Jun 28, 2017 at 08:40:25PM +0300, Adrian Hunter escreveu: > On 06/28/2017 04:04 PM, Arnaldo Carvalho de Melo wrote: > > Em Fri, May 26, 2017 at 11:17:26AM +0300, Adrian Hunt

RE: [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events

2017-06-28 Thread Hunter, Adrian
-Attributes Late here, so maybe it will make more sense tomorrow. -Original Message- From: Arnaldo Carvalho de Melo [mailto:a...@kernel.org] Sent: Wednesday, June 28, 2017 9:54 PM To: Hunter, Adrian Cc: Andi Kleen ; linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 25/37] perf script: Add

Re: [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events

2017-06-28 Thread Arnaldo Carvalho de Melo
Em Wed, Jun 28, 2017 at 08:40:25PM +0300, Adrian Hunter escreveu: > On 06/28/2017 04:04 PM, Arnaldo Carvalho de Melo wrote: > > Em Fri, May 26, 2017 at 11:17:26AM +0300, Adrian Hunter escreveu: > >> Add definitions for synthesized Intel PT events for power and ptwrite. > > > >> +++

Re: [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events

2017-06-28 Thread Arnaldo Carvalho de Melo
Em Wed, Jun 28, 2017 at 08:40:25PM +0300, Adrian Hunter escreveu: > On 06/28/2017 04:04 PM, Arnaldo Carvalho de Melo wrote: > > Em Fri, May 26, 2017 at 11:17:26AM +0300, Adrian Hunter escreveu: > >> Add definitions for synthesized Intel PT events for power and ptwrite. > > > >> +++

Re: [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events

2017-06-28 Thread Adrian Hunter
On 06/28/2017 04:04 PM, Arnaldo Carvalho de Melo wrote: > Em Fri, May 26, 2017 at 11:17:26AM +0300, Adrian Hunter escreveu: >> Add definitions for synthesized Intel PT events for power and ptwrite. > >> +++ b/tools/perf/util/event.h >> +/* >> + * Raw data formats for synthesized events. Note

Re: [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events

2017-06-28 Thread Adrian Hunter
On 06/28/2017 04:04 PM, Arnaldo Carvalho de Melo wrote: > Em Fri, May 26, 2017 at 11:17:26AM +0300, Adrian Hunter escreveu: >> Add definitions for synthesized Intel PT events for power and ptwrite. > >> +++ b/tools/perf/util/event.h >> +/* >> + * Raw data formats for synthesized events. Note

Re: [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events

2017-06-28 Thread Arnaldo Carvalho de Melo
Em Fri, May 26, 2017 at 11:17:26AM +0300, Adrian Hunter escreveu: > Add definitions for synthesized Intel PT events for power and ptwrite. > +++ b/tools/perf/util/event.h > +/* > + * Raw data formats for synthesized events. Note that raw data plus the raw > data > + * size (4 bytes) must align

Re: [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events

2017-06-28 Thread Arnaldo Carvalho de Melo
Em Fri, May 26, 2017 at 11:17:26AM +0300, Adrian Hunter escreveu: > Add definitions for synthesized Intel PT events for power and ptwrite. > +++ b/tools/perf/util/event.h > +/* > + * Raw data formats for synthesized events. Note that raw data plus the raw > data > + * size (4 bytes) must align

[PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events

2017-05-26 Thread Adrian Hunter
Add definitions for synthesized Intel PT events for power and ptwrite. Signed-off-by: Adrian Hunter --- tools/perf/builtin-script.c | 114 +++- tools/perf/util/event.h | 90 ++ 2 files changed,

[PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events

2017-05-26 Thread Adrian Hunter
Add definitions for synthesized Intel PT events for power and ptwrite. Signed-off-by: Adrian Hunter --- tools/perf/builtin-script.c | 114 +++- tools/perf/util/event.h | 90 ++ 2 files changed, 203 insertions(+), 1