Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-28 Thread Bjorn Helgaas
On Fri, May 23, 2014 at 6:31 PM, Suravee Suthikulanit wrote: > On 5/22/2014 9:54 PM, Bjorn Helgaas wrote: >> >> I've been poking around for recent dmesg logs that contain "PCI: Using >> configuration type 1 for extended access", and there are quite a few. >> In most cases there*is* an MCFG

Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-28 Thread Bjorn Helgaas
On Fri, May 23, 2014 at 6:31 PM, Suravee Suthikulanit suravee.suthikulpa...@amd.com wrote: On 5/22/2014 9:54 PM, Bjorn Helgaas wrote: I've been poking around for recent dmesg logs that contain PCI: Using configuration type 1 for extended access, and there are quite a few. In most cases

Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-23 Thread Suravee Suthikulanit
On 5/22/2014 9:54 PM, Bjorn Helgaas wrote: I've been poking around for recent dmesg logs that contain "PCI: Using configuration type 1 for extended access", and there are quite a few. In most cases there*is* an MCFG table, but apparently we decide not to use it for some reason (unfortunately we

Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-23 Thread Suravee Suthikulanit
On 5/23/2014 6:56 AM, Robert Richter wrote: On 22.05.14 20:54:54, Bjorn Helgaas wrote: I'm going to go out on a limb and guess that Windows does not enable ECS, so it probably uses ECAM. Therefore, I suspect Linux's parsing of MCFG is broken in some way, and we probably *could* use ECAM in all

Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-23 Thread Robert Richter
On 23.05.14 07:01:41, Bjorn Helgaas wrote: > [I guess I've been using the wrong term here. I think "ECS" just > refers to the extended config space itself, and I should have been > saying "IO ECS" or "EnableCf8ExtCfg".] > > My understanding was that if we don't enable IO ECS and we don't have >

Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-23 Thread Bjorn Helgaas
On Fri, May 23, 2014 at 5:56 AM, Robert Richter wrote: > On 22.05.14 20:54:54, Bjorn Helgaas wrote: >> I'm going to go out on a limb and guess that Windows does not enable >> ECS, so it probably uses ECAM. Therefore, I suspect Linux's parsing >> of MCFG is broken in some way, and we probably

Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-23 Thread Robert Richter
On 22.05.14 20:54:54, Bjorn Helgaas wrote: > I'm going to go out on a limb and guess that Windows does not enable > ECS, so it probably uses ECAM. Therefore, I suspect Linux's parsing > of MCFG is broken in some way, and we probably *could* use ECAM in all > these cases I'm seeing. Even if ECS

Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-23 Thread Robert Richter
On 22.05.14 20:54:54, Bjorn Helgaas wrote: I'm going to go out on a limb and guess that Windows does not enable ECS, so it probably uses ECAM. Therefore, I suspect Linux's parsing of MCFG is broken in some way, and we probably *could* use ECAM in all these cases I'm seeing. Even if ECS is

Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-23 Thread Bjorn Helgaas
On Fri, May 23, 2014 at 5:56 AM, Robert Richter r...@kernel.org wrote: On 22.05.14 20:54:54, Bjorn Helgaas wrote: I'm going to go out on a limb and guess that Windows does not enable ECS, so it probably uses ECAM. Therefore, I suspect Linux's parsing of MCFG is broken in some way, and we

Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-23 Thread Robert Richter
On 23.05.14 07:01:41, Bjorn Helgaas wrote: [I guess I've been using the wrong term here. I think ECS just refers to the extended config space itself, and I should have been saying IO ECS or EnableCf8ExtCfg.] My understanding was that if we don't enable IO ECS and we don't have MCFG, we

Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-23 Thread Suravee Suthikulanit
On 5/23/2014 6:56 AM, Robert Richter wrote: On 22.05.14 20:54:54, Bjorn Helgaas wrote: I'm going to go out on a limb and guess that Windows does not enable ECS, so it probably uses ECAM. Therefore, I suspect Linux's parsing of MCFG is broken in some way, and we probably *could* use ECAM in all

Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-23 Thread Suravee Suthikulanit
On 5/22/2014 9:54 PM, Bjorn Helgaas wrote: I've been poking around for recent dmesg logs that contain PCI: Using configuration type 1 for extended access, and there are quite a few. In most cases there*is* an MCFG table, but apparently we decide not to use it for some reason (unfortunately we

Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-22 Thread Bjorn Helgaas
On Thu, May 22, 2014 at 5:39 PM, Suravee Suthikulanit wrote: > On 5/22/2014 3:20 PM, Bjorn Helgaas wrote: >> On Thu, May 22, 2014 at 1:17 PM, Borislav Petkov wrote: >>> On Thu, May 22, 2014 at 11:56:03AM -0600, Bjorn Helgaas wrote: I chose Fam16h (0x16) because it looks like that's the

Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-22 Thread Suravee Suthikulanit
On 5/22/2014 3:20 PM, Bjorn Helgaas wrote: On Thu, May 22, 2014 at 1:17 PM, Borislav Petkov wrote: On Thu, May 22, 2014 at 11:56:03AM -0600, Bjorn Helgaas wrote: I chose Fam16h (0x16) because it looks like that's the newest stuff that's in the field. I suspect things would probably work if we

Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-22 Thread Borislav Petkov
On Thu, May 22, 2014 at 02:20:04PM -0600, Bjorn Helgaas wrote: > Even if MMCONFIG does work fine on everything from Fam10h onwards, we > still depend on the BIOS to provide a correct MCFG table. It is very hazy memory of mine that starting with F10h, we had an MCFG table always present but I

Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-22 Thread Bjorn Helgaas
On Thu, May 22, 2014 at 1:17 PM, Borislav Petkov wrote: > On Thu, May 22, 2014 at 11:56:03AM -0600, Bjorn Helgaas wrote: >> I chose Fam16h (0x16) because it looks like that's the newest stuff >> that's in the field. I suspect things would probably work if we >> changed this patch to leave ECS

Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-22 Thread Borislav Petkov
On Thu, May 22, 2014 at 11:56:03AM -0600, Bjorn Helgaas wrote: > I chose Fam16h (0x16) because it looks like that's the newest stuff > that's in the field. I suspect things would probably work if we > changed this patch to leave ECS disabled on some Fam16h, Fam15h, etc., > but that would change

Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-22 Thread Bjorn Helgaas
On Wed, May 21, 2014 at 5:38 PM, Borislav Petkov wrote: > On Wed, May 21, 2014 at 05:18:17PM -0600, Bjorn Helgaas wrote: >> ECS is an AMD mechanism that allows access to extended PCI config space >> (offsets 256-4096) via I/O ports CF8/CFCh. We normally use ECAM, i.e., >> MMCONFIG, to access

Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-22 Thread Bjorn Helgaas
On Wed, May 21, 2014 at 5:38 PM, Borislav Petkov b...@alien8.de wrote: On Wed, May 21, 2014 at 05:18:17PM -0600, Bjorn Helgaas wrote: ECS is an AMD mechanism that allows access to extended PCI config space (offsets 256-4096) via I/O ports CF8/CFCh. We normally use ECAM, i.e., MMCONFIG, to

Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-22 Thread Borislav Petkov
On Thu, May 22, 2014 at 11:56:03AM -0600, Bjorn Helgaas wrote: I chose Fam16h (0x16) because it looks like that's the newest stuff that's in the field. I suspect things would probably work if we changed this patch to leave ECS disabled on some Fam16h, Fam15h, etc., but that would change

Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-22 Thread Bjorn Helgaas
On Thu, May 22, 2014 at 1:17 PM, Borislav Petkov b...@alien8.de wrote: On Thu, May 22, 2014 at 11:56:03AM -0600, Bjorn Helgaas wrote: I chose Fam16h (0x16) because it looks like that's the newest stuff that's in the field. I suspect things would probably work if we changed this patch to leave

Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-22 Thread Borislav Petkov
On Thu, May 22, 2014 at 02:20:04PM -0600, Bjorn Helgaas wrote: Even if MMCONFIG does work fine on everything from Fam10h onwards, we still depend on the BIOS to provide a correct MCFG table. It is very hazy memory of mine that starting with F10h, we had an MCFG table always present but I don't

Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-22 Thread Suravee Suthikulanit
On 5/22/2014 3:20 PM, Bjorn Helgaas wrote: On Thu, May 22, 2014 at 1:17 PM, Borislav Petkov b...@alien8.de wrote: On Thu, May 22, 2014 at 11:56:03AM -0600, Bjorn Helgaas wrote: I chose Fam16h (0x16) because it looks like that's the newest stuff that's in the field. I suspect things would

Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-22 Thread Bjorn Helgaas
On Thu, May 22, 2014 at 5:39 PM, Suravee Suthikulanit suravee.suthikulpa...@amd.com wrote: On 5/22/2014 3:20 PM, Bjorn Helgaas wrote: On Thu, May 22, 2014 at 1:17 PM, Borislav Petkov b...@alien8.de wrote: On Thu, May 22, 2014 at 11:56:03AM -0600, Bjorn Helgaas wrote: I chose Fam16h (0x16)

Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-21 Thread Borislav Petkov
On Wed, May 21, 2014 at 05:18:17PM -0600, Bjorn Helgaas wrote: > ECS is an AMD mechanism that allows access to extended PCI config space > (offsets 256-4096) via I/O ports CF8/CFCh. We normally use ECAM, i.e., > MMCONFIG, to access that space, but apparently old machines have issues > that meant

[PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-21 Thread Bjorn Helgaas
ECS is an AMD mechanism that allows access to extended PCI config space (offsets 256-4096) via I/O ports CF8/CFCh. We normally use ECAM, i.e., MMCONFIG, to access that space, but apparently old machines have issues that meant we couldn't use ECAM. The solution was to enable ECS so we could use

[PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-21 Thread Bjorn Helgaas
ECS is an AMD mechanism that allows access to extended PCI config space (offsets 256-4096) via I/O ports CF8/CFCh. We normally use ECAM, i.e., MMCONFIG, to access that space, but apparently old machines have issues that meant we couldn't use ECAM. The solution was to enable ECS so we could use

Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-21 Thread Borislav Petkov
On Wed, May 21, 2014 at 05:18:17PM -0600, Bjorn Helgaas wrote: ECS is an AMD mechanism that allows access to extended PCI config space (offsets 256-4096) via I/O ports CF8/CFCh. We normally use ECAM, i.e., MMCONFIG, to access that space, but apparently old machines have issues that meant we