Re: [PATCH net] macvlan: don't touch promisc without passthrough

2013-06-13 Thread John Fastabend
On 06/12/2013 06:56 AM, Sergei Shtylyov wrote: Hello. On 12-06-2013 15:34, Michael S. Tsirkin wrote: commit df8ef8f3aaa6692970a436204c4429210addb23a in linux 3.5 added a way Please also specify that commit's summary line in parens. to control NOPROMISC macvlan flag through netlink.

Re: [PATCH net] macvlan: don't touch promisc without passthrough

2013-06-13 Thread John Fastabend
On 06/12/2013 06:56 AM, Sergei Shtylyov wrote: Hello. On 12-06-2013 15:34, Michael S. Tsirkin wrote: commit df8ef8f3aaa6692970a436204c4429210addb23a in linux 3.5 added a way Please also specify that commit's summary line in parens. to control NOPROMISC macvlan flag through netlink.

Re: [PATCH net] macvlan: don't touch promisc without passthrough

2013-06-12 Thread Sergei Shtylyov
Hello. On 12-06-2013 15:34, Michael S. Tsirkin wrote: commit df8ef8f3aaa6692970a436204c4429210addb23a in linux 3.5 added a way Please also specify that commit's summary line in parens. to control NOPROMISC macvlan flag through netlink. However, with a non passthrough device we don't

[PATCH net] macvlan: don't touch promisc without passthrough

2013-06-12 Thread Michael S. Tsirkin
commit df8ef8f3aaa6692970a436204c4429210addb23a in linux 3.5 added a way to control NOPROMISC macvlan flag through netlink. However, with a non passthrough device we don't set promisc on open or clear it on stop, even if NOPROMISC is off. As a result: If userspace clears NOPROMISC on open, then

[PATCH net] macvlan: don't touch promisc without passthrough

2013-06-12 Thread Michael S. Tsirkin
commit df8ef8f3aaa6692970a436204c4429210addb23a in linux 3.5 added a way to control NOPROMISC macvlan flag through netlink. However, with a non passthrough device we don't set promisc on open or clear it on stop, even if NOPROMISC is off. As a result: If userspace clears NOPROMISC on open, then

Re: [PATCH net] macvlan: don't touch promisc without passthrough

2013-06-12 Thread Sergei Shtylyov
Hello. On 12-06-2013 15:34, Michael S. Tsirkin wrote: commit df8ef8f3aaa6692970a436204c4429210addb23a in linux 3.5 added a way Please also specify that commit's summary line in parens. to control NOPROMISC macvlan flag through netlink. However, with a non passthrough device we don't