Re: [PATCH net-next] net: stmmac: set total length of the packet to be transmitted in TDES3

2017-04-13 Thread David Miller
From: Niklas Cassel Date: Mon, 10 Apr 2017 20:33:29 +0200 > From: Niklas Cassel > > Field FL/TPL in register TDES3 is not correctly set on GMAC4. > TX appears to be functional on GMAC 4.10a even if this field is not set, > however, to avoid

Re: [PATCH net-next] net: stmmac: set total length of the packet to be transmitted in TDES3

2017-04-13 Thread David Miller
From: Niklas Cassel Date: Mon, 10 Apr 2017 20:33:29 +0200 > From: Niklas Cassel > > Field FL/TPL in register TDES3 is not correctly set on GMAC4. > TX appears to be functional on GMAC 4.10a even if this field is not set, > however, to avoid relying on undefined behavior, set the length in

Re: [PATCH net-next] net: stmmac: set total length of the packet to be transmitted in TDES3

2017-04-11 Thread Giuseppe CAVALLARO
On 4/10/2017 8:33 PM, Niklas Cassel wrote: From: Niklas Cassel Field FL/TPL in register TDES3 is not correctly set on GMAC4. TX appears to be functional on GMAC 4.10a even if this field is not set, however, to avoid relying on undefined behavior, set the length in

Re: [PATCH net-next] net: stmmac: set total length of the packet to be transmitted in TDES3

2017-04-11 Thread Giuseppe CAVALLARO
On 4/10/2017 8:33 PM, Niklas Cassel wrote: From: Niklas Cassel Field FL/TPL in register TDES3 is not correctly set on GMAC4. TX appears to be functional on GMAC 4.10a even if this field is not set, however, to avoid relying on undefined behavior, set the length in TDES3. The field has a

Re: [PATCH net-next] net: stmmac: set total length of the packet to be transmitted in TDES3

2017-04-11 Thread Niklas Cassel
On 04/11/2017 10:48 AM, Joao Pinto wrote: > > Hi Niklas, > > Às 7:33 PM de 4/10/2017, Niklas Cassel escreveu: >> From: Niklas Cassel >> >> Field FL/TPL in register TDES3 is not correctly set on GMAC4. >> TX appears to be functional on GMAC 4.10a even if this field is not

Re: [PATCH net-next] net: stmmac: set total length of the packet to be transmitted in TDES3

2017-04-11 Thread Niklas Cassel
On 04/11/2017 10:48 AM, Joao Pinto wrote: > > Hi Niklas, > > Às 7:33 PM de 4/10/2017, Niklas Cassel escreveu: >> From: Niklas Cassel >> >> Field FL/TPL in register TDES3 is not correctly set on GMAC4. >> TX appears to be functional on GMAC 4.10a even if this field is not set, >> however, to

Re: [PATCH net-next] net: stmmac: set total length of the packet to be transmitted in TDES3

2017-04-11 Thread Joao Pinto
Hi Niklas, Às 7:33 PM de 4/10/2017, Niklas Cassel escreveu: > From: Niklas Cassel > > Field FL/TPL in register TDES3 is not correctly set on GMAC4. > TX appears to be functional on GMAC 4.10a even if this field is not set, > however, to avoid relying on undefined

Re: [PATCH net-next] net: stmmac: set total length of the packet to be transmitted in TDES3

2017-04-11 Thread Joao Pinto
Hi Niklas, Às 7:33 PM de 4/10/2017, Niklas Cassel escreveu: > From: Niklas Cassel > > Field FL/TPL in register TDES3 is not correctly set on GMAC4. > TX appears to be functional on GMAC 4.10a even if this field is not set, > however, to avoid relying on undefined behavior, set the length in

Re: [PATCH net-next] net: stmmac: set total length of the packet to be transmitted in TDES3

2017-04-11 Thread Alexandre Torgue
Hi, On 04/11/2017 07:40 AM, Giuseppe CAVALLARO wrote: Hi Niklas patch looks ok for me, Alex any feedback? It sounds good for me to. peppe On 4/10/2017 8:33 PM, Niklas Cassel wrote: From: Niklas Cassel Field FL/TPL in register TDES3 is not correctly set on GMAC4.

Re: [PATCH net-next] net: stmmac: set total length of the packet to be transmitted in TDES3

2017-04-11 Thread Alexandre Torgue
Hi, On 04/11/2017 07:40 AM, Giuseppe CAVALLARO wrote: Hi Niklas patch looks ok for me, Alex any feedback? It sounds good for me to. peppe On 4/10/2017 8:33 PM, Niklas Cassel wrote: From: Niklas Cassel Field FL/TPL in register TDES3 is not correctly set on GMAC4. TX appears to be

Re: [PATCH net-next] net: stmmac: set total length of the packet to be transmitted in TDES3

2017-04-10 Thread Giuseppe CAVALLARO
Hi Niklas patch looks ok for me, Alex any feedback? peppe On 4/10/2017 8:33 PM, Niklas Cassel wrote: From: Niklas Cassel Field FL/TPL in register TDES3 is not correctly set on GMAC4. TX appears to be functional on GMAC 4.10a even if this field is not set, however, to

Re: [PATCH net-next] net: stmmac: set total length of the packet to be transmitted in TDES3

2017-04-10 Thread Giuseppe CAVALLARO
Hi Niklas patch looks ok for me, Alex any feedback? peppe On 4/10/2017 8:33 PM, Niklas Cassel wrote: From: Niklas Cassel Field FL/TPL in register TDES3 is not correctly set on GMAC4. TX appears to be functional on GMAC 4.10a even if this field is not set, however, to avoid relying on

[PATCH net-next] net: stmmac: set total length of the packet to be transmitted in TDES3

2017-04-10 Thread Niklas Cassel
From: Niklas Cassel Field FL/TPL in register TDES3 is not correctly set on GMAC4. TX appears to be functional on GMAC 4.10a even if this field is not set, however, to avoid relying on undefined behavior, set the length in TDES3. The field has a different meaning

[PATCH net-next] net: stmmac: set total length of the packet to be transmitted in TDES3

2017-04-10 Thread Niklas Cassel
From: Niklas Cassel Field FL/TPL in register TDES3 is not correctly set on GMAC4. TX appears to be functional on GMAC 4.10a even if this field is not set, however, to avoid relying on undefined behavior, set the length in TDES3. The field has a different meaning depending on if the TSE bit in