Re: [PATCH net-next 06/20] net: hns3: Modify the update period of packet statistics

2018-01-06 Thread Andrew Lunn
> >Is it because the static void is on the previous line? > Yes, it is because the static void is on the previous line. > > I can add one patch to fix the previous line , and this patch will correct > automatically. > > do it need V2 patchset? or push a new patch after this patchset? Thanks

Re: [PATCH net-next 06/20] net: hns3: Modify the update period of packet statistics

2018-01-06 Thread Andrew Lunn
> >Is it because the static void is on the previous line? > Yes, it is because the static void is on the previous line. > > I can add one patch to fix the previous line , and this patch will correct > automatically. > > do it need V2 patchset? or push a new patch after this patchset? Thanks

Re: [PATCH net-next 06/20] net: hns3: Modify the update period of packet statistics

2018-01-05 Thread lipeng (Y)
On 2018/1/5 22:54, Andrew Lunn wrote: --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c @@ -1126,6 +1126,7 @@ static int hns3_nic_set_features(struct net_device *netdev, { struct hns3_nic_priv *priv = netdev_priv(netdev);

Re: [PATCH net-next 06/20] net: hns3: Modify the update period of packet statistics

2018-01-05 Thread lipeng (Y)
On 2018/1/5 22:54, Andrew Lunn wrote: --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c @@ -1126,6 +1126,7 @@ static int hns3_nic_set_features(struct net_device *netdev, { struct hns3_nic_priv *priv = netdev_priv(netdev);

Re: [PATCH net-next 06/20] net: hns3: Modify the update period of packet statistics

2018-01-05 Thread Andrew Lunn
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > @@ -1126,6 +1126,7 @@ static int hns3_nic_set_features(struct net_device > *netdev, > { > struct hns3_nic_priv *priv = netdev_priv(netdev); > int queue_num =

Re: [PATCH net-next 06/20] net: hns3: Modify the update period of packet statistics

2018-01-05 Thread Andrew Lunn
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > @@ -1126,6 +1126,7 @@ static int hns3_nic_set_features(struct net_device > *netdev, > { > struct hns3_nic_priv *priv = netdev_priv(netdev); > int queue_num =

[PATCH net-next 06/20] net: hns3: Modify the update period of packet statistics

2018-01-05 Thread Peng Li
From: Jian Shen It takes more than 200 query response messages between driver and IMP, while updating the packet statistics. It's too heavy for IMP to update it per second. Extend the update period of packet statistics data from 1 second to 300 seconds(if too long, the

[PATCH net-next 06/20] net: hns3: Modify the update period of packet statistics

2018-01-05 Thread Peng Li
From: Jian Shen It takes more than 200 query response messages between driver and IMP, while updating the packet statistics. It's too heavy for IMP to update it per second. Extend the update period of packet statistics data from 1 second to 300 seconds(if too long, the statistics may overflow).