Re: [PATCH net-next v6 1/10] xen-netback: Use skb->cb for pending_idx

2014-03-05 Thread Zoltan Kiss
On 05/03/14 12:16, Wei Liu wrote: On Tue, Mar 04, 2014 at 10:32:12PM +, Zoltan Kiss wrote: Storing the pending_idx at the first byte of the linear buffer never looked good, skb->cb is a more proper place for this. It also prevents the header to be directly grant copied there, and we don't

Re: [PATCH net-next v6 1/10] xen-netback: Use skb->cb for pending_idx

2014-03-05 Thread Wei Liu
On Tue, Mar 04, 2014 at 10:32:12PM +, Zoltan Kiss wrote: > Storing the pending_idx at the first byte of the linear buffer never looked > good, skb->cb is a more proper place for this. It also prevents the header to > be directly grant copied there, and we don't have the pending_idx after we >

Re: [PATCH net-next v6 1/10] xen-netback: Use skb-cb for pending_idx

2014-03-05 Thread Wei Liu
On Tue, Mar 04, 2014 at 10:32:12PM +, Zoltan Kiss wrote: Storing the pending_idx at the first byte of the linear buffer never looked good, skb-cb is a more proper place for this. It also prevents the header to be directly grant copied there, and we don't have the pending_idx after we

Re: [PATCH net-next v6 1/10] xen-netback: Use skb-cb for pending_idx

2014-03-05 Thread Zoltan Kiss
On 05/03/14 12:16, Wei Liu wrote: On Tue, Mar 04, 2014 at 10:32:12PM +, Zoltan Kiss wrote: Storing the pending_idx at the first byte of the linear buffer never looked good, skb-cb is a more proper place for this. It also prevents the header to be directly grant copied there, and we don't

[PATCH net-next v6 1/10] xen-netback: Use skb->cb for pending_idx

2014-03-04 Thread Zoltan Kiss
Storing the pending_idx at the first byte of the linear buffer never looked good, skb->cb is a more proper place for this. It also prevents the header to be directly grant copied there, and we don't have the pending_idx after we copied the header here, so it's time to change it. Signed-off-by:

[PATCH net-next v6 1/10] xen-netback: Use skb-cb for pending_idx

2014-03-04 Thread Zoltan Kiss
Storing the pending_idx at the first byte of the linear buffer never looked good, skb-cb is a more proper place for this. It also prevents the header to be directly grant copied there, and we don't have the pending_idx after we copied the header here, so it's time to change it. Signed-off-by: