Re: [PATCH v1 0/4] rtc: pcf2127: a fix, a cleanup and two questionable features

2015-10-14 Thread Alexandre Belloni
On 02/10/2015 at 11:17:18 +0200, Uwe Kleine-König wrote : > Hello, > > the fix and the cleanup should be fine. Patches 3 and 4 are probably > wrong (but still state of the art for other in-tree drivers) because > sysfs_create_file is called too late. See >

Re: [PATCH v1 0/4] rtc: pcf2127: a fix, a cleanup and two questionable features

2015-10-14 Thread Alexandre Belloni
On 02/10/2015 at 11:17:18 +0200, Uwe Kleine-König wrote : > Hello, > > the fix and the cleanup should be fine. Patches 3 and 4 are probably > wrong (but still state of the art for other in-tree drivers) because > sysfs_create_file is called too late. See >

[PATCH v1 0/4] rtc: pcf2127: a fix, a cleanup and two questionable features

2015-10-02 Thread Uwe Kleine-König
Hello, the fix and the cleanup should be fine. Patches 3 and 4 are probably wrong (but still state of the art for other in-tree drivers) because sysfs_create_file is called too late. See http://kroah.com/log/blog/2013/06/26/how-to-create-a-sysfs-file-correctly/ for some details. I failed to find

[PATCH v1 0/4] rtc: pcf2127: a fix, a cleanup and two questionable features

2015-10-02 Thread Uwe Kleine-König
Hello, the fix and the cleanup should be fine. Patches 3 and 4 are probably wrong (but still state of the art for other in-tree drivers) because sysfs_create_file is called too late. See http://kroah.com/log/blog/2013/06/26/how-to-create-a-sysfs-file-correctly/ for some details. I failed to find