Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-11-07 Thread Michal Hocko
On Wed 07-11-18 11:28:37, Michal Hocko wrote: > On Wed 07-11-18 09:50:10, Vlastimil Babka wrote: > > On 11/7/18 8:02 AM, Konstantin Khlebnikov wrote: > [...] > > > Could you point what exactly are you fixing with this set? > > > > > > from v2: > > > > > > > totalram_pages, zone->managed_pages

Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-11-07 Thread Michal Hocko
On Wed 07-11-18 11:28:37, Michal Hocko wrote: > On Wed 07-11-18 09:50:10, Vlastimil Babka wrote: > > On 11/7/18 8:02 AM, Konstantin Khlebnikov wrote: > [...] > > > Could you point what exactly are you fixing with this set? > > > > > > from v2: > > > > > > > totalram_pages, zone->managed_pages

Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-11-07 Thread Michal Hocko
On Wed 07-11-18 09:50:10, Vlastimil Babka wrote: > On 11/7/18 8:02 AM, Konstantin Khlebnikov wrote: [...] > > Could you point what exactly are you fixing with this set? > > > > from v2: > > > > > totalram_pages, zone->managed_pages and totalhigh_pages updates > > > are protected by

Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-11-07 Thread Michal Hocko
On Wed 07-11-18 09:50:10, Vlastimil Babka wrote: > On 11/7/18 8:02 AM, Konstantin Khlebnikov wrote: [...] > > Could you point what exactly are you fixing with this set? > > > > from v2: > > > > > totalram_pages, zone->managed_pages and totalhigh_pages updates > > > are protected by

Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-11-07 Thread Vlastimil Babka
On 11/7/18 8:02 AM, Konstantin Khlebnikov wrote: > On 06.11.2018 11:43, Arun KS wrote: >> On 2018-11-06 14:07, Konstantin Khlebnikov wrote: >>> On 06.11.2018 11:30, Arun KS wrote: On 2018-11-06 13:47, Konstantin Khlebnikov wrote: > On 06.11.2018 8:38, Arun KS wrote: >> Any comments?

Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-11-07 Thread Vlastimil Babka
On 11/7/18 8:02 AM, Konstantin Khlebnikov wrote: > On 06.11.2018 11:43, Arun KS wrote: >> On 2018-11-06 14:07, Konstantin Khlebnikov wrote: >>> On 06.11.2018 11:30, Arun KS wrote: On 2018-11-06 13:47, Konstantin Khlebnikov wrote: > On 06.11.2018 8:38, Arun KS wrote: >> Any comments?

Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-11-06 Thread Konstantin Khlebnikov
On 06.11.2018 11:43, Arun KS wrote: On 2018-11-06 14:07, Konstantin Khlebnikov wrote: On 06.11.2018 11:30, Arun KS wrote: On 2018-11-06 13:47, Konstantin Khlebnikov wrote: On 06.11.2018 8:38, Arun KS wrote: Any comments? Looks good. Except unclear motivation behind this change. This should

Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-11-06 Thread Konstantin Khlebnikov
On 06.11.2018 11:43, Arun KS wrote: On 2018-11-06 14:07, Konstantin Khlebnikov wrote: On 06.11.2018 11:30, Arun KS wrote: On 2018-11-06 13:47, Konstantin Khlebnikov wrote: On 06.11.2018 8:38, Arun KS wrote: Any comments? Looks good. Except unclear motivation behind this change. This should

Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-11-06 Thread Arun KS
On 2018-11-07 05:52, Andrew Morton wrote: On Fri, 26 Oct 2018 16:30:58 +0530 Arun KS wrote: This series convert totalram_pages, totalhigh_pages and zone->managed_pages to atomic variables. The whole point appears to be removal of managed_page_count_lock, yes? Why? What is the value of

Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-11-06 Thread Arun KS
On 2018-11-07 05:52, Andrew Morton wrote: On Fri, 26 Oct 2018 16:30:58 +0530 Arun KS wrote: This series convert totalram_pages, totalhigh_pages and zone->managed_pages to atomic variables. The whole point appears to be removal of managed_page_count_lock, yes? Why? What is the value of

Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-11-06 Thread Andrew Morton
On Fri, 26 Oct 2018 16:30:58 +0530 Arun KS wrote: > This series convert totalram_pages, totalhigh_pages and > zone->managed_pages to atomic variables. The whole point appears to be removal of managed_page_count_lock, yes? Why? What is the value of this patchset? If "performance" then are any

Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-11-06 Thread Andrew Morton
On Fri, 26 Oct 2018 16:30:58 +0530 Arun KS wrote: > This series convert totalram_pages, totalhigh_pages and > zone->managed_pages to atomic variables. The whole point appears to be removal of managed_page_count_lock, yes? Why? What is the value of this patchset? If "performance" then are any

Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-11-06 Thread Arun KS
On 2018-11-06 14:07, Konstantin Khlebnikov wrote: On 06.11.2018 11:30, Arun KS wrote: On 2018-11-06 13:47, Konstantin Khlebnikov wrote: On 06.11.2018 8:38, Arun KS wrote: Any comments? Looks good. Except unclear motivation behind this change. This should be in comment of one of patch.

Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-11-06 Thread Arun KS
On 2018-11-06 14:07, Konstantin Khlebnikov wrote: On 06.11.2018 11:30, Arun KS wrote: On 2018-11-06 13:47, Konstantin Khlebnikov wrote: On 06.11.2018 8:38, Arun KS wrote: Any comments? Looks good. Except unclear motivation behind this change. This should be in comment of one of patch.

Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-11-06 Thread Konstantin Khlebnikov
On 06.11.2018 11:30, Arun KS wrote: On 2018-11-06 13:47, Konstantin Khlebnikov wrote: On 06.11.2018 8:38, Arun KS wrote: Any comments? Looks good. Except unclear motivation behind this change. This should be in comment of one of patch. totalram_pages, zone->managed_pages and

Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-11-06 Thread Konstantin Khlebnikov
On 06.11.2018 11:30, Arun KS wrote: On 2018-11-06 13:47, Konstantin Khlebnikov wrote: On 06.11.2018 8:38, Arun KS wrote: Any comments? Looks good. Except unclear motivation behind this change. This should be in comment of one of patch. totalram_pages, zone->managed_pages and

Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-11-06 Thread Arun KS
On 2018-11-06 13:47, Konstantin Khlebnikov wrote: On 06.11.2018 8:38, Arun KS wrote: Any comments? Looks good. Except unclear motivation behind this change. This should be in comment of one of patch. totalram_pages, zone->managed_pages and totalhigh_pages are sometimes modified outside

Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-11-06 Thread Arun KS
On 2018-11-06 13:47, Konstantin Khlebnikov wrote: On 06.11.2018 8:38, Arun KS wrote: Any comments? Looks good. Except unclear motivation behind this change. This should be in comment of one of patch. totalram_pages, zone->managed_pages and totalhigh_pages are sometimes modified outside

Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-11-06 Thread Konstantin Khlebnikov
On 06.11.2018 8:38, Arun KS wrote: Any comments? Looks good. Except unclear motivation behind this change. This should be in comment of one of patch. Reviewed-by: Konstantin Khlebnikov Regards, Arun On 2018-10-26 16:30, Arun KS wrote: This series convert totalram_pages, totalhigh_pages

Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-11-06 Thread Konstantin Khlebnikov
On 06.11.2018 8:38, Arun KS wrote: Any comments? Looks good. Except unclear motivation behind this change. This should be in comment of one of patch. Reviewed-by: Konstantin Khlebnikov Regards, Arun On 2018-10-26 16:30, Arun KS wrote: This series convert totalram_pages, totalhigh_pages

Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-11-05 Thread Arun KS
Any comments? Regards, Arun On 2018-10-26 16:30, Arun KS wrote: This series convert totalram_pages, totalhigh_pages and zone->managed_pages to atomic variables. The patch was comiple tested on x86(x86_64_defconfig & i386_defconfig) on tip of linux-mmotm. And memory hotplug tested on arm64,

Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-11-05 Thread Arun KS
Any comments? Regards, Arun On 2018-10-26 16:30, Arun KS wrote: This series convert totalram_pages, totalhigh_pages and zone->managed_pages to atomic variables. The patch was comiple tested on x86(x86_64_defconfig & i386_defconfig) on tip of linux-mmotm. And memory hotplug tested on arm64,

[PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-10-26 Thread Arun KS
This series convert totalram_pages, totalhigh_pages and zone->managed_pages to atomic variables. The patch was comiple tested on x86(x86_64_defconfig & i386_defconfig) on tip of linux-mmotm. And memory hotplug tested on arm64, but on an older version of kernel. Arun KS (4): mm: Fix multiple

[PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-10-26 Thread Arun KS
This series convert totalram_pages, totalhigh_pages and zone->managed_pages to atomic variables. The patch was comiple tested on x86(x86_64_defconfig & i386_defconfig) on tip of linux-mmotm. And memory hotplug tested on arm64, but on an older version of kernel. Arun KS (4): mm: Fix multiple

[PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-10-26 Thread Arun KS
This series convert totalram_pages, totalhigh_pages and zone->managed_pages to atomic variables. The patch was comiple tested on x86(x86_64_defconfig & i386_defconfig) on tip of linux-mmotm. And memory hotplug tested on arm64, but on an older version of kernel. Arun KS (4): mm: Fix multiple

[PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-10-26 Thread Arun KS
This series convert totalram_pages, totalhigh_pages and zone->managed_pages to atomic variables. The patch was comiple tested on x86(x86_64_defconfig & i386_defconfig) on tip of linux-mmotm. And memory hotplug tested on arm64, but on an older version of kernel. Arun KS (4): mm: Fix multiple