Re: [PATCH v1 08/10] kgdb: Remove "weak" from kgdb_arch_pc() declaration

2014-10-20 Thread Bjorn Helgaas
On Fri, Oct 17, 2014 at 1:59 AM, Vineet Gupta wrote: > On Thursday 16 October 2014 07:08 PM, Vineet Gupta wrote: >> On Thursday 16 October 2014 05:05 AM, Bjorn Helgaas wrote: >>> > [+cc Harvey, Vineet, linux-sh; arc, sh, and x86 have kgdb_arch_pc() >>> > definitions and could see issues from

Re: [PATCH v1 08/10] kgdb: Remove weak from kgdb_arch_pc() declaration

2014-10-20 Thread Bjorn Helgaas
On Fri, Oct 17, 2014 at 1:59 AM, Vineet Gupta vineet.gup...@synopsys.com wrote: On Thursday 16 October 2014 07:08 PM, Vineet Gupta wrote: On Thursday 16 October 2014 05:05 AM, Bjorn Helgaas wrote: [+cc Harvey, Vineet, linux-sh; arc, sh, and x86 have kgdb_arch_pc() definitions and could see

Re: [PATCH v1 08/10] kgdb: Remove "weak" from kgdb_arch_pc() declaration

2014-10-17 Thread Vineet Gupta
On Thursday 16 October 2014 07:08 PM, Vineet Gupta wrote: > On Thursday 16 October 2014 05:05 AM, Bjorn Helgaas wrote: >> > [+cc Harvey, Vineet, linux-sh; arc, sh, and x86 have kgdb_arch_pc() >> > definitions and could see issues from this] > Thanks for the heads up ! > > I compile tested arc

Re: [PATCH v1 08/10] kgdb: Remove weak from kgdb_arch_pc() declaration

2014-10-17 Thread Vineet Gupta
On Thursday 16 October 2014 07:08 PM, Vineet Gupta wrote: On Thursday 16 October 2014 05:05 AM, Bjorn Helgaas wrote: [+cc Harvey, Vineet, linux-sh; arc, sh, and x86 have kgdb_arch_pc() definitions and could see issues from this] Thanks for the heads up ! I compile tested arc tree (with

Re: [PATCH v1 08/10] kgdb: Remove "weak" from kgdb_arch_pc() declaration

2014-10-16 Thread Vineet Gupta
Hi Bjorn, On Thursday 16 October 2014 05:05 AM, Bjorn Helgaas wrote: > [+cc Harvey, Vineet, linux-sh; arc, sh, and x86 have kgdb_arch_pc() > definitions and could see issues from this] Thanks for the heads up ! I compile tested arc tree (with kgdb) from linux-next of today, which has this patch

Re: [PATCH v1 08/10] kgdb: Remove weak from kgdb_arch_pc() declaration

2014-10-16 Thread Vineet Gupta
Hi Bjorn, On Thursday 16 October 2014 05:05 AM, Bjorn Helgaas wrote: [+cc Harvey, Vineet, linux-sh; arc, sh, and x86 have kgdb_arch_pc() definitions and could see issues from this] Thanks for the heads up ! I compile tested arc tree (with kgdb) from linux-next of today, which has this patch

Re: [PATCH v1 08/10] kgdb: Remove "weak" from kgdb_arch_pc() declaration

2014-10-15 Thread Harvey Harrison
On Wed, Oct 15, 2014 at 10:06 AM, Bjorn Helgaas wrote: > > kernel/debug/debug_core.c provides a default kgdb_arch_pc() definition > explicitly marked "weak". Several architectures provide their own > definitions intended to override the default, but the "weak" attribute on > the declaration

Re: [PATCH v1 08/10] kgdb: Remove "weak" from kgdb_arch_pc() declaration

2014-10-15 Thread Bjorn Helgaas
[+cc Harvey, Vineet, linux-sh; arc, sh, and x86 have kgdb_arch_pc() definitions and could see issues from this] On Wed, Oct 15, 2014 at 11:06 AM, Bjorn Helgaas wrote: > kernel/debug/debug_core.c provides a default kgdb_arch_pc() definition > explicitly marked "weak". Several architectures

[PATCH v1 08/10] kgdb: Remove "weak" from kgdb_arch_pc() declaration

2014-10-15 Thread Bjorn Helgaas
kernel/debug/debug_core.c provides a default kgdb_arch_pc() definition explicitly marked "weak". Several architectures provide their own definitions intended to override the default, but the "weak" attribute on the declaration applied to the arch definitions as well, so the linker chose one based

[PATCH v1 08/10] kgdb: Remove weak from kgdb_arch_pc() declaration

2014-10-15 Thread Bjorn Helgaas
kernel/debug/debug_core.c provides a default kgdb_arch_pc() definition explicitly marked weak. Several architectures provide their own definitions intended to override the default, but the weak attribute on the declaration applied to the arch definitions as well, so the linker chose one based on

Re: [PATCH v1 08/10] kgdb: Remove weak from kgdb_arch_pc() declaration

2014-10-15 Thread Bjorn Helgaas
[+cc Harvey, Vineet, linux-sh; arc, sh, and x86 have kgdb_arch_pc() definitions and could see issues from this] On Wed, Oct 15, 2014 at 11:06 AM, Bjorn Helgaas bhelg...@google.com wrote: kernel/debug/debug_core.c provides a default kgdb_arch_pc() definition explicitly marked weak. Several

Re: [PATCH v1 08/10] kgdb: Remove weak from kgdb_arch_pc() declaration

2014-10-15 Thread Harvey Harrison
On Wed, Oct 15, 2014 at 10:06 AM, Bjorn Helgaas bhelg...@google.com wrote: kernel/debug/debug_core.c provides a default kgdb_arch_pc() definition explicitly marked weak. Several architectures provide their own definitions intended to override the default, but the weak attribute on the