Re: [PATCH v10 06/17] mm: slub: introduce metadata_access_enable()/metadata_access_disable()

2015-01-30 Thread Andrey Ryabinin
2015-01-31 2:16 GMT+03:00 Andrew Morton : > On Sat, 31 Jan 2015 03:11:55 +0400 Andrey Ryabinin > wrote: > >> >> > kasan_disable_local/kasan_enable_local are also undocumented doesn't >> >> > help. >> >> > >> >> >> >> Ok, How about this? >> >> >> >> /* >> >> * This hooks separate payload access

Re: [PATCH v10 06/17] mm: slub: introduce metadata_access_enable()/metadata_access_disable()

2015-01-30 Thread Andrew Morton
On Sat, 31 Jan 2015 03:11:55 +0400 Andrey Ryabinin wrote: > >> > kasan_disable_local/kasan_enable_local are also undocumented doesn't > >> > help. > >> > > >> > >> Ok, How about this? > >> > >> /* > >> * This hooks separate payload access from metadata access. > >> * Useful for memory

Re: [PATCH v10 06/17] mm: slub: introduce metadata_access_enable()/metadata_access_disable()

2015-01-30 Thread Andrey Ryabinin
2015-01-31 0:42 GMT+03:00 Andrew Morton : > On Fri, 30 Jan 2015 20:05:13 +0300 Andrey Ryabinin > wrote: > >> >> --- a/mm/slub.c >> >> +++ b/mm/slub.c >> >> @@ -467,13 +467,23 @@ static int slub_debug; >> >> static char *slub_debug_slabs; >> >> static int disable_higher_order_debug; >> >> >> >>

Re: [PATCH v10 06/17] mm: slub: introduce metadata_access_enable()/metadata_access_disable()

2015-01-30 Thread Andrew Morton
On Fri, 30 Jan 2015 20:05:13 +0300 Andrey Ryabinin wrote: > >> --- a/mm/slub.c > >> +++ b/mm/slub.c > >> @@ -467,13 +467,23 @@ static int slub_debug; > >> static char *slub_debug_slabs; > >> static int disable_higher_order_debug; > >> > >> +static inline void metadata_access_enable(void) >

Re: [PATCH v10 06/17] mm: slub: introduce metadata_access_enable()/metadata_access_disable()

2015-01-30 Thread Andrey Ryabinin
On 01/30/2015 02:12 AM, Andrew Morton wrote: > On Thu, 29 Jan 2015 18:11:50 +0300 Andrey Ryabinin > wrote: > >> Wrap access to object's metadata in external functions with >> metadata_access_enable()/metadata_access_disable() function calls. >> >> This hooks separates payload accesses from

Re: [PATCH v10 06/17] mm: slub: introduce metadata_access_enable()/metadata_access_disable()

2015-01-30 Thread Andrey Ryabinin
On 01/30/2015 02:12 AM, Andrew Morton wrote: On Thu, 29 Jan 2015 18:11:50 +0300 Andrey Ryabinin a.ryabi...@samsung.com wrote: Wrap access to object's metadata in external functions with metadata_access_enable()/metadata_access_disable() function calls. This hooks separates payload

Re: [PATCH v10 06/17] mm: slub: introduce metadata_access_enable()/metadata_access_disable()

2015-01-30 Thread Andrey Ryabinin
2015-01-31 0:42 GMT+03:00 Andrew Morton a...@linux-foundation.org: On Fri, 30 Jan 2015 20:05:13 +0300 Andrey Ryabinin a.ryabi...@samsung.com wrote: --- a/mm/slub.c +++ b/mm/slub.c @@ -467,13 +467,23 @@ static int slub_debug; static char *slub_debug_slabs; static int

Re: [PATCH v10 06/17] mm: slub: introduce metadata_access_enable()/metadata_access_disable()

2015-01-30 Thread Andrew Morton
On Fri, 30 Jan 2015 20:05:13 +0300 Andrey Ryabinin a.ryabi...@samsung.com wrote: --- a/mm/slub.c +++ b/mm/slub.c @@ -467,13 +467,23 @@ static int slub_debug; static char *slub_debug_slabs; static int disable_higher_order_debug; +static inline void metadata_access_enable(void)

Re: [PATCH v10 06/17] mm: slub: introduce metadata_access_enable()/metadata_access_disable()

2015-01-30 Thread Andrey Ryabinin
2015-01-31 2:16 GMT+03:00 Andrew Morton a...@linux-foundation.org: On Sat, 31 Jan 2015 03:11:55 +0400 Andrey Ryabinin ryabinin@gmail.com wrote: kasan_disable_local/kasan_enable_local are also undocumented doesn't help. Ok, How about this? /* * This hooks separate

Re: [PATCH v10 06/17] mm: slub: introduce metadata_access_enable()/metadata_access_disable()

2015-01-30 Thread Andrew Morton
On Sat, 31 Jan 2015 03:11:55 +0400 Andrey Ryabinin ryabinin@gmail.com wrote: kasan_disable_local/kasan_enable_local are also undocumented doesn't help. Ok, How about this? /* * This hooks separate payload access from metadata access. * Useful for memory checkers that

Re: [PATCH v10 06/17] mm: slub: introduce metadata_access_enable()/metadata_access_disable()

2015-01-29 Thread Andrew Morton
On Thu, 29 Jan 2015 18:11:50 +0300 Andrey Ryabinin wrote: > Wrap access to object's metadata in external functions with > metadata_access_enable()/metadata_access_disable() function calls. > > This hooks separates payload accesses from metadata accesses > which might be useful for different

[PATCH v10 06/17] mm: slub: introduce metadata_access_enable()/metadata_access_disable()

2015-01-29 Thread Andrey Ryabinin
Wrap access to object's metadata in external functions with metadata_access_enable()/metadata_access_disable() function calls. This hooks separates payload accesses from metadata accesses which might be useful for different checkers (e.g. KASan). Signed-off-by: Andrey Ryabinin --- mm/slub.c |

[PATCH v10 06/17] mm: slub: introduce metadata_access_enable()/metadata_access_disable()

2015-01-29 Thread Andrey Ryabinin
Wrap access to object's metadata in external functions with metadata_access_enable()/metadata_access_disable() function calls. This hooks separates payload accesses from metadata accesses which might be useful for different checkers (e.g. KASan). Signed-off-by: Andrey Ryabinin

Re: [PATCH v10 06/17] mm: slub: introduce metadata_access_enable()/metadata_access_disable()

2015-01-29 Thread Andrew Morton
On Thu, 29 Jan 2015 18:11:50 +0300 Andrey Ryabinin a.ryabi...@samsung.com wrote: Wrap access to object's metadata in external functions with metadata_access_enable()/metadata_access_disable() function calls. This hooks separates payload accesses from metadata accesses which might be useful