Re: [PATCH v14 07/20] mm/thp: narrow lru locking

2020-07-10 Thread Alex Shi
在 2020/7/10 下午7:28, Kirill A. Shutemov 写道: >> * hugetlb_fault_mutex (hugetlbfs specific page fault mutex) >> * anon_vma->rwsem >> * mm->page_table_lock or pte_lock >> - * pgdat->lru_lock (in mark_page_accessed, isolate_lru_page) >> *

Re: [PATCH v14 07/20] mm/thp: narrow lru locking

2020-07-10 Thread Alex Shi
在 2020/7/9 下午11:48, Kirill A. Shutemov 写道: > On Mon, Jul 06, 2020 at 09:52:34PM -0700, Hugh Dickins wrote: >> On Mon, 6 Jul 2020, Matthew Wilcox wrote: >>> On Mon, Jul 06, 2020 at 05:15:09PM +0800, Alex Shi wrote: Hi Kirill & Johannes & Matthew, >> >> Adding Kirill, who was in patch's Cc

Re: [PATCH v14 07/20] mm/thp: narrow lru locking

2020-07-09 Thread Kirill A. Shutemov
On Mon, Jul 06, 2020 at 09:52:34PM -0700, Hugh Dickins wrote: > On Mon, 6 Jul 2020, Matthew Wilcox wrote: > > On Mon, Jul 06, 2020 at 05:15:09PM +0800, Alex Shi wrote: > > > Hi Kirill & Johannes & Matthew, > > Adding Kirill, who was in patch's Cc list but not mail's Cc list. > > I asked Alex to

Re: [PATCH v14 07/20] mm/thp: narrow lru locking

2020-07-09 Thread Alex Shi
在 2020/7/7 下午12:52, Hugh Dickins 写道: > My vote, for dispatch of the series, is to leave this patch in; > but cannot object if consensus were that it should be taken out. hi Johannes & Kirill, What's your comments for this patch or others? I am ok to withdraw this patch if no one like to give

Re: [PATCH v14 07/20] mm/thp: narrow lru locking

2020-07-07 Thread Alex Shi
在 2020/7/6 下午7:35, Matthew Wilcox 写道: >> Would you like to give some comments or share your concern of this patchset, >> specialy for THP part? > I don't have the brain space to understand this patch set fully at > the moment. I'll note that the realtime folks are doing their best to > stamp

Re: [PATCH v14 07/20] mm/thp: narrow lru locking

2020-07-06 Thread Hugh Dickins
On Mon, 6 Jul 2020, Matthew Wilcox wrote: > On Mon, Jul 06, 2020 at 05:15:09PM +0800, Alex Shi wrote: > > Hi Kirill & Johannes & Matthew, Adding Kirill, who was in patch's Cc list but not mail's Cc list. I asked Alex to direct this one particularly to Kirill and Johannes and Matthew because (and

Re: [PATCH v14 07/20] mm/thp: narrow lru locking

2020-07-06 Thread Matthew Wilcox
On Mon, Jul 06, 2020 at 05:15:09PM +0800, Alex Shi wrote: > Hi Kirill & Johannes & Matthew, > > Would you like to give some comments or share your concern of this patchset, > specialy for THP part? I don't have the brain space to understand this patch set fully at the moment. I'll note that

Re: [PATCH v14 07/20] mm/thp: narrow lru locking

2020-07-06 Thread Alex Shi
Hi Kirill & Johannes & Matthew, Would you like to give some comments or share your concern of this patchset, specialy for THP part? Many Thanks Alex 在 2020/7/3 下午1:07, Alex Shi 写道: > lru_lock and page cache xa_lock have no reason with current sequence, > put them together isn't necessary.

[PATCH v14 07/20] mm/thp: narrow lru locking

2020-07-02 Thread Alex Shi
lru_lock and page cache xa_lock have no reason with current sequence, put them together isn't necessary. let's narrow the lru locking, but left the local_irq_disable to block interrupt re-entry and statistic update. Hugh Dickins point: split_huge_page_to_list() was already silly,to be using the