RE: [PATCH v18 3/3] Input: new da7280 haptic driver

2020-08-02 Thread Roy Im
On Sun, August 2, 2020 8:54 PM, Pavel Machek wrote: > Hi! > > > > +static DEVICE_ATTR_RW(ps_seq_id); > > > +static DEVICE_ATTR_RW(ps_seq_loop); static > > > +DEVICE_ATTR_RW(gpi_seq_id0); static DEVICE_ATTR_RW(gpi_seq_id1); > > > +static DEVICE_ATTR_RW(gpi_seq_id2); static > > >

Re: [PATCH v18 3/3] Input: new da7280 haptic driver

2020-08-02 Thread Pavel Machek
Hi! > > +static DEVICE_ATTR_RW(ps_seq_id); > > +static DEVICE_ATTR_RW(ps_seq_loop); > > +static DEVICE_ATTR_RW(gpi_seq_id0); > > +static DEVICE_ATTR_RW(gpi_seq_id1); > > +static DEVICE_ATTR_RW(gpi_seq_id2); > > +static DEVICE_ATTR_WO(patterns); > > Should this be a binary attribute instead of

RE: [PATCH v18 3/3] Input: new da7280 haptic driver

2020-07-31 Thread Roy Im
On Thu, July 30, 2020 2:10 PM, Dmitry Torokhov > On Wed, Jul 29, 2020 at 02:09:48PM +, Roy Im wrote: > > Wednesday, July 29, 2020 3:37 PM, Dmitry Torokhov wrote: > > > On Wed, Jul 29, 2020 at 11:59:40AM +0900, Roy Im wrote: > > > > v11: > > > > - Updated the pwm related code,

Re: [PATCH v18 3/3] Input: new da7280 haptic driver

2020-07-30 Thread Dmitry Torokhov
On Thu, Jul 30, 2020 at 11:30:58AM +0300, Andy Shevchenko wrote: > On Thu, Jul 30, 2020 at 08:16:31AM +0200, Uwe Kleine-König wrote: > > On Wed, Jul 29, 2020 at 10:06:53PM -0700, Dmitry Torokhov wrote: > > > On Wed, Jul 29, 2020 at 09:21:45AM +0200, Uwe Kleine-König wrote: > > > > On Tue, Jul 28,

Re: [PATCH v18 3/3] Input: new da7280 haptic driver

2020-07-30 Thread Andy Shevchenko
On Thu, Jul 30, 2020 at 08:16:31AM +0200, Uwe Kleine-König wrote: > On Wed, Jul 29, 2020 at 10:06:53PM -0700, Dmitry Torokhov wrote: > > On Wed, Jul 29, 2020 at 09:21:45AM +0200, Uwe Kleine-König wrote: > > > On Tue, Jul 28, 2020 at 11:36:38PM -0700, Dmitry Torokhov wrote: ... > > Maybe we

Re: [PATCH v18 3/3] Input: new da7280 haptic driver

2020-07-30 Thread Uwe Kleine-König
Hello, On Wed, Jul 29, 2020 at 11:34:04PM -0700, Dmitry Torokhov wrote: > On Thu, Jul 30, 2020 at 08:16:31AM +0200, Uwe Kleine-König wrote: > > I suggested that some time ago with limited success, see > > https://lore.kernel.org/lkml/20200129115516.zsvxu56e6h7gh...@pathway.suse.cz/ > > . > > > >

Re: [PATCH v18 3/3] Input: new da7280 haptic driver

2020-07-30 Thread Dmitry Torokhov
On Thu, Jul 30, 2020 at 08:16:31AM +0200, Uwe Kleine-König wrote: > [Adding vsprintf maintainers to Cc:] > > Hello, > > On Wed, Jul 29, 2020 at 10:06:53PM -0700, Dmitry Torokhov wrote: > > On Wed, Jul 29, 2020 at 09:21:45AM +0200, Uwe Kleine-König wrote: > > > Hello, > > > > > > On Tue, Jul 28,

Re: [PATCH v18 3/3] Input: new da7280 haptic driver

2020-07-30 Thread Uwe Kleine-König
[Adding vsprintf maintainers to Cc:] Hello, On Wed, Jul 29, 2020 at 10:06:53PM -0700, Dmitry Torokhov wrote: > On Wed, Jul 29, 2020 at 09:21:45AM +0200, Uwe Kleine-König wrote: > > Hello, > > > > On Tue, Jul 28, 2020 at 11:36:38PM -0700, Dmitry Torokhov wrote: > > > > v9: > > > > -

Re: [PATCH v18 3/3] Input: new da7280 haptic driver

2020-07-29 Thread Dmitry Torokhov
On Wed, Jul 29, 2020 at 02:09:48PM +, Roy Im wrote: > Hello Dmitry and Uwe, > > Wednesday, July 29, 2020 3:37 PM, Dmitry Torokhov wrote: > > > On Wed, Jul 29, 2020 at 11:59:40AM +0900, Roy Im wrote: > > > Adds support for the Dialog DA7280 LRA/ERM Haptic Driver with multiple > > > mode and

Re: [PATCH v18 3/3] Input: new da7280 haptic driver

2020-07-29 Thread Dmitry Torokhov
Hi Uwe, On Wed, Jul 29, 2020 at 09:21:45AM +0200, Uwe Kleine-König wrote: > Hello, > > On Tue, Jul 28, 2020 at 11:36:38PM -0700, Dmitry Torokhov wrote: > > > v9: > > > - Removed the header file and put the definitions into the c file. > > > - Updated the pwm code and error logs with %pE > >

RE: [PATCH v18 3/3] Input: new da7280 haptic driver

2020-07-29 Thread Roy Im
Hello Dmitry and Uwe, Wednesday, July 29, 2020 3:37 PM, Dmitry Torokhov wrote: > On Wed, Jul 29, 2020 at 11:59:40AM +0900, Roy Im wrote: > > Adds support for the Dialog DA7280 LRA/ERM Haptic Driver with multiple > > mode and integrated waveform memory and wideband support. > > It communicates

Re: [PATCH v18 3/3] Input: new da7280 haptic driver

2020-07-29 Thread Uwe Kleine-König
Hello, On Tue, Jul 28, 2020 at 11:36:38PM -0700, Dmitry Torokhov wrote: > > v9: > > - Removed the header file and put the definitions into the c file. > > - Updated the pwm code and error logs with %pE > > I believe the %pE is to format an escaped buffer, you probably want to > %pe

Re: [PATCH v18 3/3] Input: new da7280 haptic driver

2020-07-29 Thread Dmitry Torokhov
Hi Roy, On Wed, Jul 29, 2020 at 11:59:40AM +0900, Roy Im wrote: > Adds support for the Dialog DA7280 LRA/ERM Haptic Driver with > multiple mode and integrated waveform memory and wideband support. > It communicates via an I2C bus to the device. A few questions/suggestions... > > Reviewed-by:

[PATCH v18 3/3] Input: new da7280 haptic driver

2020-07-28 Thread Roy Im
Adds support for the Dialog DA7280 LRA/ERM Haptic Driver with multiple mode and integrated waveform memory and wideband support. It communicates via an I2C bus to the device. Reviewed-by: Jes Sorensen . Signed-off-by: Roy Im --- v18: - Corrected comments in Kconfig - Updated to