Re: [PATCH v2] ASoC: rockchip: i2s: restore register during runtime_suspend/resume cycle

2016-09-06 Thread Mark Brown
On Tue, Sep 06, 2016 at 09:19:53AM +0800, Sugar Zhang wrote: > struct rk_i2s_dev *i2s = dev_get_drvdata(dev); > - int ret; > + int ret = 0; > Why are you initializing this? All this will do is stop the compiler warning you about use without initializaiton bugs. signature.asc

Re: [PATCH v2] ASoC: rockchip: i2s: restore register during runtime_suspend/resume cycle

2016-09-06 Thread Mark Brown
On Tue, Sep 06, 2016 at 09:19:53AM +0800, Sugar Zhang wrote: > struct rk_i2s_dev *i2s = dev_get_drvdata(dev); > - int ret; > + int ret = 0; > Why are you initializing this? All this will do is stop the compiler warning you about use without initializaiton bugs. signature.asc

[PATCH v2] ASoC: rockchip: i2s: restore register during runtime_suspend/resume cycle

2016-09-05 Thread Sugar Zhang
when step into runtime_suspend, i2s pd will be disabled and loss state. so need to restore register when runtime_resume. Signed-off-by: Sugar Zhang --- Changes in v2: - remove system suspend/resume and restore register in runtime_suspend/resume per Doug Anderson's

[PATCH v2] ASoC: rockchip: i2s: restore register during runtime_suspend/resume cycle

2016-09-05 Thread Sugar Zhang
when step into runtime_suspend, i2s pd will be disabled and loss state. so need to restore register when runtime_resume. Signed-off-by: Sugar Zhang --- Changes in v2: - remove system suspend/resume and restore register in runtime_suspend/resume per Doug Anderson's suggestion