Re: [PATCH v2] Add 4 tracepoint events for vfs

2013-01-30 Thread Steven Rostedt
On Wed, 2013-01-30 at 14:35 +0800, chenggang wrote: > +#include > + > +DECLARE_EVENT_CLASS(vfs_filerw_template, > + > + TP_PROTO(long long pos, unsigned long bytes, unsigned char *fname), One last nit. Might want to make fname "const". -- Steve > + > + TP_ARGS(pos, bytes, fname), > + >

Re: [PATCH v2] Add 4 tracepoint events for vfs

2013-01-30 Thread Steven Rostedt
On Wed, 2013-01-30 at 14:35 +0800, chenggang wrote: +#include asm/ptrace.h + +DECLARE_EVENT_CLASS(vfs_filerw_template, + + TP_PROTO(long long pos, unsigned long bytes, unsigned char *fname), One last nit. Might want to make fname const. -- Steve + + TP_ARGS(pos, bytes, fname), +

[PATCH v2] Add 4 tracepoint events for vfs

2013-01-29 Thread chenggang
From: chenggang@gmail.com If the engineers want to analyze the file access behavior of some applications without source code, perf tools with some appropriate tracepoints events in the VFS subsystem are excellent choice. The system engineers or developers of server software require to know

[PATCH v2] Add 4 tracepoint events for vfs

2013-01-29 Thread chenggang
From: chenggang@gmail.com If the engineers want to analyze the file access behavior of some applications without source code, perf tools with some appropriate tracepoints events in the VFS subsystem are excellent choice. The system engineers or developers of server software require to know