Re: [PATCH v2] Ceph: Punch hole support

2013-06-20 Thread Rob Landley
On 06/19/2013 11:23:51 AM, Li Wang wrote: This patch implements punch hole (fallocate) support for Ceph. Signed-off-by: Li Wang Signed-off-by: Yunchuan Wen +static int ceph_delete_object(struct inode *inode, u64 offset, u64 *length) +{ + struct ceph_inode_info *ci =

Re: [PATCH v2] Ceph: Punch hole support

2013-06-20 Thread Rob Landley
On 06/19/2013 11:23:51 AM, Li Wang wrote: This patch implements punch hole (fallocate) support for Ceph. Signed-off-by: Li Wang liw...@ubuntukylin.com Signed-off-by: Yunchuan Wen wenyunch...@ubuntukylin.com +static int ceph_delete_object(struct inode *inode, u64 offset, u64 *length) +{ +

Re: [PATCH v2] Ceph: Punch hole support

2013-06-19 Thread Dave Chinner
On Wed, Jun 19, 2013 at 09:31:21AM -0700, Sage Weil wrote: > Hi Li, > > There is a version of fsx.c floating around that tests hole punching... > have you tried running that on top of this patch? Ideally, we should > build a test (ceph.git/qa/workunits/rbd/hole_punch.sh or similar) that >

Re: [PATCH v2] Ceph: Punch hole support

2013-06-19 Thread Sage Weil
Hi Li, There is a version of fsx.c floating around that tests hole punching... have you tried running that on top of this patch? Ideally, we should build a test (ceph.git/qa/workunits/rbd/hole_punch.sh or similar) that tests the hole punch both with a default file layout and with a more

[PATCH v2] Ceph: Punch hole support

2013-06-19 Thread Li Wang
This patch implements punch hole (fallocate) support for Ceph. Signed-off-by: Li Wang Signed-off-by: Yunchuan Wen --- fs/ceph/file.c| 313 + net/ceph/osd_client.c |8 +- 2 files changed, 319 insertions(+), 2 deletions(-) diff

[PATCH v2] Ceph: Punch hole support

2013-06-19 Thread Li Wang
This patch implements punch hole (fallocate) support for Ceph. Signed-off-by: Li Wang liw...@ubuntukylin.com Signed-off-by: Yunchuan Wen wenyunch...@ubuntukylin.com --- fs/ceph/file.c| 313 + net/ceph/osd_client.c |8 +- 2 files

Re: [PATCH v2] Ceph: Punch hole support

2013-06-19 Thread Sage Weil
Hi Li, There is a version of fsx.c floating around that tests hole punching... have you tried running that on top of this patch? Ideally, we should build a test (ceph.git/qa/workunits/rbd/hole_punch.sh or similar) that tests the hole punch both with a default file layout and with a more

Re: [PATCH v2] Ceph: Punch hole support

2013-06-19 Thread Dave Chinner
On Wed, Jun 19, 2013 at 09:31:21AM -0700, Sage Weil wrote: Hi Li, There is a version of fsx.c floating around that tests hole punching... have you tried running that on top of this patch? Ideally, we should build a test (ceph.git/qa/workunits/rbd/hole_punch.sh or similar) that tests the