Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-08-01 Thread Vivek Goyal
On Thu, Aug 01, 2013 at 03:34:06PM +0900, Takao Indoh wrote: > (2013/08/01 6:23), Rafael J. Wysocki wrote: > > On Wednesday, July 31, 2013 03:08:03 PM Bjorn Helgaas wrote: > >> [+cc Rafael, linux-acpi] > >> > >> On Tue, Jul 30, 2013 at 6:35 PM, Takao Indoh > >> wrote: > >> > >>> On x86,

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-08-01 Thread Alex Williamson
On Thu, 2013-08-01 at 15:34 +0900, Takao Indoh wrote: > (2013/08/01 6:23), Rafael J. Wysocki wrote: > > On Wednesday, July 31, 2013 03:08:03 PM Bjorn Helgaas wrote: > >> [+cc Rafael, linux-acpi] > >> > >> On Tue, Jul 30, 2013 at 6:35 PM, Takao Indoh > >> wrote: > >> > >>> On x86, currently IOMMU

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-08-01 Thread Takao Indoh
(2013/08/01 6:23), Rafael J. Wysocki wrote: > On Wednesday, July 31, 2013 03:08:03 PM Bjorn Helgaas wrote: >> [+cc Rafael, linux-acpi] >> >> On Tue, Jul 30, 2013 at 6:35 PM, Takao Indoh >> wrote: >> >>> On x86, currently IOMMU initialization run *after* PCI enumeration, but >>> what you are

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-08-01 Thread Takao Indoh
(2013/08/01 6:23), Rafael J. Wysocki wrote: On Wednesday, July 31, 2013 03:08:03 PM Bjorn Helgaas wrote: [+cc Rafael, linux-acpi] On Tue, Jul 30, 2013 at 6:35 PM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: On x86, currently IOMMU initialization run *after* PCI enumeration, but what you

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-08-01 Thread Alex Williamson
On Thu, 2013-08-01 at 15:34 +0900, Takao Indoh wrote: (2013/08/01 6:23), Rafael J. Wysocki wrote: On Wednesday, July 31, 2013 03:08:03 PM Bjorn Helgaas wrote: [+cc Rafael, linux-acpi] On Tue, Jul 30, 2013 at 6:35 PM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: On x86, currently

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-08-01 Thread Vivek Goyal
On Thu, Aug 01, 2013 at 03:34:06PM +0900, Takao Indoh wrote: (2013/08/01 6:23), Rafael J. Wysocki wrote: On Wednesday, July 31, 2013 03:08:03 PM Bjorn Helgaas wrote: [+cc Rafael, linux-acpi] On Tue, Jul 30, 2013 at 6:35 PM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: On x86,

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-31 Thread Rafael J. Wysocki
On Wednesday, July 31, 2013 03:08:03 PM Bjorn Helgaas wrote: > [+cc Rafael, linux-acpi] > > On Tue, Jul 30, 2013 at 6:35 PM, Takao Indoh > wrote: > > > On x86, currently IOMMU initialization run *after* PCI enumeration, but > > what you are talking about is that it should be changed so that

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-31 Thread Bjorn Helgaas
[+cc Rafael, linux-acpi] On Tue, Jul 30, 2013 at 6:35 PM, Takao Indoh wrote: > On x86, currently IOMMU initialization run *after* PCI enumeration, but > what you are talking about is that it should be changed so that x86 > IOMMU initialization is done *before* PCI enumeration like sparc, right?

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-31 Thread Vivek Goyal
On Tue, Jul 30, 2013 at 09:59:16AM -0600, Bjorn Helgaas wrote: > On Tue, Jul 30, 2013 at 12:09 AM, Takao Indoh > wrote: > > (2013/07/29 23:17), Bjorn Helgaas wrote: > >> On Sun, Jul 28, 2013 at 6:37 PM, Takao Indoh > >> wrote: > >>> (2013/07/26 2:00), Bjorn Helgaas wrote: > > My point

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-31 Thread Vivek Goyal
On Thu, Jul 25, 2013 at 11:00:46AM -0600, Bjorn Helgaas wrote: > On Wed, Jul 24, 2013 at 12:29 AM, Takao Indoh > wrote: > > Sorry for letting this discussion slide, I was busy on other works:-( > > Anyway, the summary of previous discussion is: > > - My patch adds new initcall(fs_initcall) to

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-31 Thread Vivek Goyal
On Thu, Jul 25, 2013 at 11:00:46AM -0600, Bjorn Helgaas wrote: On Wed, Jul 24, 2013 at 12:29 AM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: Sorry for letting this discussion slide, I was busy on other works:-( Anyway, the summary of previous discussion is: - My patch adds new

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-31 Thread Vivek Goyal
On Tue, Jul 30, 2013 at 09:59:16AM -0600, Bjorn Helgaas wrote: On Tue, Jul 30, 2013 at 12:09 AM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: (2013/07/29 23:17), Bjorn Helgaas wrote: On Sun, Jul 28, 2013 at 6:37 PM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: (2013/07/26 2:00), Bjorn

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-31 Thread Bjorn Helgaas
[+cc Rafael, linux-acpi] On Tue, Jul 30, 2013 at 6:35 PM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: On x86, currently IOMMU initialization run *after* PCI enumeration, but what you are talking about is that it should be changed so that x86 IOMMU initialization is done *before* PCI

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-31 Thread Rafael J. Wysocki
On Wednesday, July 31, 2013 03:08:03 PM Bjorn Helgaas wrote: [+cc Rafael, linux-acpi] On Tue, Jul 30, 2013 at 6:35 PM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: On x86, currently IOMMU initialization run *after* PCI enumeration, but what you are talking about is that it should be

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-30 Thread Takao Indoh
(2013/07/31 12:11), Alex Williamson wrote: > On Wed, 2013-07-31 at 09:35 +0900, Takao Indoh wrote: >> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c >> index e37fea6..c595997 100644 >> --- a/drivers/pci/pci.c >> +++ b/drivers/pci/pci.c >> @@ -3392,6 +3392,59 @@ int pci_reset_function(struct

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-30 Thread Alex Williamson
On Wed, 2013-07-31 at 09:35 +0900, Takao Indoh wrote: > (2013/07/31 0:59), Bjorn Helgaas wrote: > > On Tue, Jul 30, 2013 at 12:09 AM, Takao Indoh > > wrote: > >> (2013/07/29 23:17), Bjorn Helgaas wrote: > >>> On Sun, Jul 28, 2013 at 6:37 PM, Takao Indoh > >>> wrote: > (2013/07/26 2:00),

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-30 Thread Takao Indoh
(2013/07/31 0:59), Bjorn Helgaas wrote: > On Tue, Jul 30, 2013 at 12:09 AM, Takao Indoh > wrote: >> (2013/07/29 23:17), Bjorn Helgaas wrote: >>> On Sun, Jul 28, 2013 at 6:37 PM, Takao Indoh >>> wrote: (2013/07/26 2:00), Bjorn Helgaas wrote: > > My point about IOMMU and PCI

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-30 Thread Bjorn Helgaas
On Tue, Jul 30, 2013 at 12:09 AM, Takao Indoh wrote: > (2013/07/29 23:17), Bjorn Helgaas wrote: >> On Sun, Jul 28, 2013 at 6:37 PM, Takao Indoh >> wrote: >>> (2013/07/26 2:00), Bjorn Helgaas wrote: My point about IOMMU and PCI initialization order doesn't go away just because it

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-30 Thread Takao Indoh
(2013/07/29 23:17), Bjorn Helgaas wrote: > On Sun, Jul 28, 2013 at 6:37 PM, Takao Indoh > wrote: >> (2013/07/26 2:00), Bjorn Helgaas wrote: >>> On Wed, Jul 24, 2013 at 12:29 AM, Takao Indoh >>> wrote: Sorry for letting this discussion slide, I was busy on other works:-( Anyway, the

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-30 Thread Takao Indoh
(2013/07/29 23:17), Bjorn Helgaas wrote: On Sun, Jul 28, 2013 at 6:37 PM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: (2013/07/26 2:00), Bjorn Helgaas wrote: On Wed, Jul 24, 2013 at 12:29 AM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: Sorry for letting this discussion slide, I was busy

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-30 Thread Bjorn Helgaas
On Tue, Jul 30, 2013 at 12:09 AM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: (2013/07/29 23:17), Bjorn Helgaas wrote: On Sun, Jul 28, 2013 at 6:37 PM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: (2013/07/26 2:00), Bjorn Helgaas wrote: My point about IOMMU and PCI initialization order

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-30 Thread Takao Indoh
(2013/07/31 0:59), Bjorn Helgaas wrote: On Tue, Jul 30, 2013 at 12:09 AM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: (2013/07/29 23:17), Bjorn Helgaas wrote: On Sun, Jul 28, 2013 at 6:37 PM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: (2013/07/26 2:00), Bjorn Helgaas wrote: My point

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-30 Thread Alex Williamson
On Wed, 2013-07-31 at 09:35 +0900, Takao Indoh wrote: (2013/07/31 0:59), Bjorn Helgaas wrote: On Tue, Jul 30, 2013 at 12:09 AM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: (2013/07/29 23:17), Bjorn Helgaas wrote: On Sun, Jul 28, 2013 at 6:37 PM, Takao Indoh indou.ta...@jp.fujitsu.com

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-30 Thread Takao Indoh
(2013/07/31 12:11), Alex Williamson wrote: On Wed, 2013-07-31 at 09:35 +0900, Takao Indoh wrote: diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index e37fea6..c595997 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -3392,6 +3392,59 @@ int pci_reset_function(struct pci_dev *dev)

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-29 Thread Bjorn Helgaas
On Sun, Jul 28, 2013 at 6:37 PM, Takao Indoh wrote: > (2013/07/26 2:00), Bjorn Helgaas wrote: >> On Wed, Jul 24, 2013 at 12:29 AM, Takao Indoh >> wrote: >>> Sorry for letting this discussion slide, I was busy on other works:-( >>> Anyway, the summary of previous discussion is: >>> - My patch

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-29 Thread Bjorn Helgaas
On Sun, Jul 28, 2013 at 6:37 PM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: (2013/07/26 2:00), Bjorn Helgaas wrote: On Wed, Jul 24, 2013 at 12:29 AM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: Sorry for letting this discussion slide, I was busy on other works:-( Anyway, the summary of

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-28 Thread Takao Indoh
(2013/07/26 2:00), Bjorn Helgaas wrote: > On Wed, Jul 24, 2013 at 12:29 AM, Takao Indoh > wrote: >> Sorry for letting this discussion slide, I was busy on other works:-( >> Anyway, the summary of previous discussion is: >> - My patch adds new initcall(fs_initcall) to reset all PCIe endpoints on

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-28 Thread Takao Indoh
(2013/07/25 23:24), Vivek Goyal wrote: > On Wed, Jul 24, 2013 at 03:29:58PM +0900, Takao Indoh wrote: >> Sorry for letting this discussion slide, I was busy on other works:-( >> Anyway, the summary of previous discussion is: >> - My patch adds new initcall(fs_initcall) to reset all PCIe endpoints

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-28 Thread Takao Indoh
(2013/07/25 23:24), Vivek Goyal wrote: On Wed, Jul 24, 2013 at 03:29:58PM +0900, Takao Indoh wrote: Sorry for letting this discussion slide, I was busy on other works:-( Anyway, the summary of previous discussion is: - My patch adds new initcall(fs_initcall) to reset all PCIe endpoints on

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-28 Thread Takao Indoh
(2013/07/26 2:00), Bjorn Helgaas wrote: On Wed, Jul 24, 2013 at 12:29 AM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: Sorry for letting this discussion slide, I was busy on other works:-( Anyway, the summary of previous discussion is: - My patch adds new initcall(fs_initcall) to reset all

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-25 Thread Bjorn Helgaas
On Wed, Jul 24, 2013 at 12:29 AM, Takao Indoh wrote: > Sorry for letting this discussion slide, I was busy on other works:-( > Anyway, the summary of previous discussion is: > - My patch adds new initcall(fs_initcall) to reset all PCIe endpoints on > boot. This expects PCI enumeration is done

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-25 Thread Vivek Goyal
On Wed, Jul 24, 2013 at 03:29:58PM +0900, Takao Indoh wrote: > Sorry for letting this discussion slide, I was busy on other works:-( > Anyway, the summary of previous discussion is: > - My patch adds new initcall(fs_initcall) to reset all PCIe endpoints on > boot. This expects PCI enumeration is

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-25 Thread Vivek Goyal
On Wed, Jul 24, 2013 at 03:29:58PM +0900, Takao Indoh wrote: Sorry for letting this discussion slide, I was busy on other works:-( Anyway, the summary of previous discussion is: - My patch adds new initcall(fs_initcall) to reset all PCIe endpoints on boot. This expects PCI enumeration is

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-25 Thread Bjorn Helgaas
On Wed, Jul 24, 2013 at 12:29 AM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: Sorry for letting this discussion slide, I was busy on other works:-( Anyway, the summary of previous discussion is: - My patch adds new initcall(fs_initcall) to reset all PCIe endpoints on boot. This expects PCI

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-24 Thread Takao Indoh
Sorry for letting this discussion slide, I was busy on other works:-( Anyway, the summary of previous discussion is: - My patch adds new initcall(fs_initcall) to reset all PCIe endpoints on boot. This expects PCI enumeration is done before IOMMU initialization as follows. (1) PCI

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-24 Thread Takao Indoh
Sorry for letting this discussion slide, I was busy on other works:-( Anyway, the summary of previous discussion is: - My patch adds new initcall(fs_initcall) to reset all PCIe endpoints on boot. This expects PCI enumeration is done before IOMMU initialization as follows. (1) PCI

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-13 Thread Takao Indoh
(2013/06/13 12:41), Bjorn Helgaas wrote: > On Wed, Jun 12, 2013 at 8:44 PM, Takao Indoh > wrote: >> (2013/06/12 13:45), Bjorn Helgaas wrote: >>> [+cc Vivek, Haren; sorry I didn't think to add you earlier] >>> >>> On Tue, Jun 11, 2013 at 12:08 AM, Takao Indoh >>> wrote: (2013/06/11 11:20),

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-13 Thread Takao Indoh
(2013/06/13 12:41), Bjorn Helgaas wrote: On Wed, Jun 12, 2013 at 8:44 PM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: (2013/06/12 13:45), Bjorn Helgaas wrote: [+cc Vivek, Haren; sorry I didn't think to add you earlier] On Tue, Jun 11, 2013 at 12:08 AM, Takao Indoh

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-12 Thread Bjorn Helgaas
On Wed, Jun 12, 2013 at 8:44 PM, Takao Indoh wrote: > (2013/06/12 13:45), Bjorn Helgaas wrote: >> [+cc Vivek, Haren; sorry I didn't think to add you earlier] >> >> On Tue, Jun 11, 2013 at 12:08 AM, Takao Indoh >> wrote: >>> (2013/06/11 11:20), Bjorn Helgaas wrote: >> I'm not sure you need

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-12 Thread Takao Indoh
(2013/06/12 22:19), Don Dutile wrote: > On 06/11/2013 07:19 PM, Sumner, William wrote: >> >>> (2013/06/11 11:20), Bjorn Helgaas wrote: On Fri, Jun 7, 2013 at 2:46 AM, Takao Indoh wrote: > (2013/06/07 13:14), Bjorn Helgaas wrote: >> One thing I'm not sure about is that you

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-12 Thread Takao Indoh
(2013/06/12 13:45), Bjorn Helgaas wrote: > [+cc Vivek, Haren; sorry I didn't think to add you earlier] > > On Tue, Jun 11, 2013 at 12:08 AM, Takao Indoh > wrote: >> (2013/06/11 11:20), Bjorn Helgaas wrote: > >>> I'm not sure you need to reset legacy devices (or non-PCI devices) >>> yet, but the

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-12 Thread Don Dutile
On 06/11/2013 07:19 PM, Sumner, William wrote: (2013/06/11 11:20), Bjorn Helgaas wrote: On Fri, Jun 7, 2013 at 2:46 AM, Takao Indoh wrote: (2013/06/07 13:14), Bjorn Helgaas wrote: One thing I'm not sure about is that you are only resetting PCIe devices, but I don't think the problem is

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-12 Thread Don Dutile
On 06/11/2013 07:19 PM, Sumner, William wrote: (2013/06/11 11:20), Bjorn Helgaas wrote: On Fri, Jun 7, 2013 at 2:46 AM, Takao Indohindou.ta...@jp.fujitsu.com wrote: (2013/06/07 13:14), Bjorn Helgaas wrote: One thing I'm not sure about is that you are only resetting PCIe devices, but I

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-12 Thread Takao Indoh
(2013/06/12 13:45), Bjorn Helgaas wrote: [+cc Vivek, Haren; sorry I didn't think to add you earlier] On Tue, Jun 11, 2013 at 12:08 AM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: (2013/06/11 11:20), Bjorn Helgaas wrote: I'm not sure you need to reset legacy devices (or non-PCI devices)

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-12 Thread Takao Indoh
(2013/06/12 22:19), Don Dutile wrote: On 06/11/2013 07:19 PM, Sumner, William wrote: (2013/06/11 11:20), Bjorn Helgaas wrote: On Fri, Jun 7, 2013 at 2:46 AM, Takao Indohindou.ta...@jp.fujitsu.com wrote: (2013/06/07 13:14), Bjorn Helgaas wrote: One thing I'm not sure about is that you are

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-12 Thread Bjorn Helgaas
On Wed, Jun 12, 2013 at 8:44 PM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: (2013/06/12 13:45), Bjorn Helgaas wrote: [+cc Vivek, Haren; sorry I didn't think to add you earlier] On Tue, Jun 11, 2013 at 12:08 AM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: (2013/06/11 11:20), Bjorn

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-11 Thread Bjorn Helgaas
[+cc Vivek, Haren; sorry I didn't think to add you earlier] On Tue, Jun 11, 2013 at 12:08 AM, Takao Indoh wrote: > (2013/06/11 11:20), Bjorn Helgaas wrote: >> I'm not sure you need to reset legacy devices (or non-PCI devices) >> yet, but the current hook isn't anchored anywhere -- it's just an

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-11 Thread Bjorn Helgaas
[Your quoting is messed up below] >> This is Takao's text > This is Bill's text On Tue, Jun 11, 2013 at 5:19 PM, Sumner, William wrote: >>(2013/06/11 11:20), Bjorn Helgaas wrote: >>> On Fri, Jun 7, 2013 at 2:46 AM, Takao Indoh >>> wrote: >>Actually Vivek Goyal, kdump maintainer said same

RE: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-11 Thread Sumner, William
>(2013/06/11 11:20), Bjorn Helgaas wrote: >> On Fri, Jun 7, 2013 at 2:46 AM, Takao Indoh >> wrote: >>> (2013/06/07 13:14), Bjorn Helgaas wrote: >> One thing I'm not sure about is that you are only resetting PCIe devices, but I don't think the problem is actually specific to PCIe,

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-11 Thread Takao Indoh
(2013/06/11 11:20), Bjorn Helgaas wrote: > On Fri, Jun 7, 2013 at 2:46 AM, Takao Indoh > wrote: >> (2013/06/07 13:14), Bjorn Helgaas wrote: > >>> One thing I'm not sure about is that you are only resetting PCIe >>> devices, but I don't think the problem is actually specific to PCIe, >>> is it?

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-11 Thread Takao Indoh
(2013/06/11 11:20), Bjorn Helgaas wrote: On Fri, Jun 7, 2013 at 2:46 AM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: (2013/06/07 13:14), Bjorn Helgaas wrote: One thing I'm not sure about is that you are only resetting PCIe devices, but I don't think the problem is actually specific to

RE: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-11 Thread Sumner, William
(2013/06/11 11:20), Bjorn Helgaas wrote: On Fri, Jun 7, 2013 at 2:46 AM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: (2013/06/07 13:14), Bjorn Helgaas wrote: One thing I'm not sure about is that you are only resetting PCIe devices, but I don't think the problem is actually specific to

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-11 Thread Bjorn Helgaas
[Your quoting is messed up below] This is Takao's text This is Bill's text On Tue, Jun 11, 2013 at 5:19 PM, Sumner, William bill.sum...@hp.com wrote: (2013/06/11 11:20), Bjorn Helgaas wrote: On Fri, Jun 7, 2013 at 2:46 AM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: Actually Vivek Goyal,

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-11 Thread Bjorn Helgaas
[+cc Vivek, Haren; sorry I didn't think to add you earlier] On Tue, Jun 11, 2013 at 12:08 AM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: (2013/06/11 11:20), Bjorn Helgaas wrote: I'm not sure you need to reset legacy devices (or non-PCI devices) yet, but the current hook isn't anchored

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-10 Thread Bjorn Helgaas
On Fri, Jun 7, 2013 at 2:46 AM, Takao Indoh wrote: > (2013/06/07 13:14), Bjorn Helgaas wrote: >> One thing I'm not sure about is that you are only resetting PCIe >> devices, but I don't think the problem is actually specific to PCIe, >> is it? I think the same issue could occur on any system

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-10 Thread Bjorn Helgaas
On Fri, Jun 7, 2013 at 2:46 AM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: (2013/06/07 13:14), Bjorn Helgaas wrote: One thing I'm not sure about is that you are only resetting PCIe devices, but I don't think the problem is actually specific to PCIe, is it? I think the same issue could

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-07 Thread Takao Indoh
Thank you for your comments! (2013/06/07 13:14), Bjorn Helgaas wrote: > Sorry it's taken me so long to look at this. I've been putting this > off because the patch doesn't seem "obviously correct," and I don't > feel like I really understand the problem. I'm naive about both > IOMMUs and

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-07 Thread Takao Indoh
Thank you for your comments! (2013/06/07 13:14), Bjorn Helgaas wrote: Sorry it's taken me so long to look at this. I've been putting this off because the patch doesn't seem obviously correct, and I don't feel like I really understand the problem. I'm naive about both IOMMUs and kexec/kdump,

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-06 Thread Bjorn Helgaas
Sorry it's taken me so long to look at this. I've been putting this off because the patch doesn't seem "obviously correct," and I don't feel like I really understand the problem. I'm naive about both IOMMUs and kexec/kdump, so please pardon (and help me with) any silly questions or assumptions

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-06 Thread Takao Indoh
Ping Bjorn, could you please tell your impression on this idea? This fix is very important for kdump. For exmaple, kdump does not work if PCI passthrough is used on KVM guest. Please see patch description for details. If you don't agree this patch, please tell me what changes I should make.

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-06 Thread Takao Indoh
Ping Bjorn, could you please tell your impression on this idea? This fix is very important for kdump. For exmaple, kdump does not work if PCI passthrough is used on KVM guest. Please see patch description for details. If you don't agree this patch, please tell me what changes I should make.

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-06 Thread Bjorn Helgaas
Sorry it's taken me so long to look at this. I've been putting this off because the patch doesn't seem obviously correct, and I don't feel like I really understand the problem. I'm naive about both IOMMUs and kexec/kdump, so please pardon (and help me with) any silly questions or assumptions

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-05-21 Thread Takao Indoh
Hi Bjorn, Any comments, ack/nack? Thanks, Takao Indoh (2013/05/15 7:04), Eric W. Biederman wrote: > Takao Indoh writes: > >> This patch resets PCIe devices on boot to stop ongoing DMA. When >> "pci=pcie_reset_endpoint_devices" is specified, a hot reset is triggered >> on each PCIe root port

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-05-21 Thread Takao Indoh
Hi Bjorn, Any comments, ack/nack? Thanks, Takao Indoh (2013/05/15 7:04), Eric W. Biederman wrote: Takao Indoh indou.ta...@jp.fujitsu.com writes: This patch resets PCIe devices on boot to stop ongoing DMA. When pci=pcie_reset_endpoint_devices is specified, a hot reset is triggered on each

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-05-14 Thread Eric W. Biederman
Takao Indoh writes: > This patch resets PCIe devices on boot to stop ongoing DMA. When > "pci=pcie_reset_endpoint_devices" is specified, a hot reset is triggered > on each PCIe root port and downstream port to reset its downstream > endpoint. > > Problem: > This patch solves the problem that

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-05-14 Thread Eric W. Biederman
Takao Indoh indou.ta...@jp.fujitsu.com writes: This patch resets PCIe devices on boot to stop ongoing DMA. When pci=pcie_reset_endpoint_devices is specified, a hot reset is triggered on each PCIe root port and downstream port to reset its downstream endpoint. Problem: This patch solves the

[PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-05-13 Thread Takao Indoh
This patch resets PCIe devices on boot to stop ongoing DMA. When "pci=pcie_reset_endpoint_devices" is specified, a hot reset is triggered on each PCIe root port and downstream port to reset its downstream endpoint. Problem: This patch solves the problem that kdump can fail when intel_iommu=on is

[PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-05-13 Thread Takao Indoh
This patch resets PCIe devices on boot to stop ongoing DMA. When pci=pcie_reset_endpoint_devices is specified, a hot reset is triggered on each PCIe root port and downstream port to reset its downstream endpoint. Problem: This patch solves the problem that kdump can fail when intel_iommu=on is