Re: [PATCH v2] arm64: dts: qcom: Add Lenovo Miix 630

2019-04-12 Thread Jeffrey Hugo
On Fri, Apr 12, 2019 at 12:01 PM Bjorn Andersson wrote: > > On Thu 11 Apr 13:51 PDT 2019, Jeffrey Hugo wrote: > > diff --git a/arch/arm64/boot/dts/qcom/msm8998-clam.dtsi > > b/arch/arm64/boot/dts/qcom/msm8998-clam.dtsi > [..] > > + { > > + gpio-reserved-ranges = <0 4>, <81 4>; > > Did you

Re: [PATCH v2] arm64: dts: qcom: Add Lenovo Miix 630

2019-04-12 Thread Bjorn Andersson
On Thu 11 Apr 13:51 PDT 2019, Jeffrey Hugo wrote: > diff --git a/arch/arm64/boot/dts/qcom/msm8998-clam.dtsi > b/arch/arm64/boot/dts/qcom/msm8998-clam.dtsi [..] > + { > + gpio-reserved-ranges = <0 4>, <81 4>; Did you double check that you actually need these? (Iirc boot testing is enough) >

Re: [PATCH v2] arm64: dts: qcom: Add Lenovo Miix 630

2019-04-12 Thread Jeffrey Hugo
On Fri, Apr 12, 2019 at 9:30 AM Mark Rutland wrote: > > On Fri, Apr 12, 2019 at 09:19:18AM -0600, Jeffrey Hugo wrote: > > > > + keyboard@3a { > > > > + /* QTEC0001 is the ACPI HID, which could be used for > > > > quirks */ > > > > + compatible = "QTEC0001",

Re: [PATCH v2] arm64: dts: qcom: Add Lenovo Miix 630

2019-04-12 Thread Mark Rutland
On Fri, Apr 12, 2019 at 09:19:18AM -0600, Jeffrey Hugo wrote: > > > + keyboard@3a { > > > + /* QTEC0001 is the ACPI HID, which could be used for quirks > > > */ > > > + compatible = "QTEC0001", "hid-over-i2c"; > > > > As mentioned last time, please drop the ACPI HID,

Re: [PATCH v2] arm64: dts: qcom: Add Lenovo Miix 630

2019-04-12 Thread Jeffrey Hugo
I'm sorry, I had completely missed your reply to v1. To answer your previous question, why do we need a DT? DT is the quick path to support for these systems. There is already a fair amount of support in mainline to support the core SoC (msm8998) which is/was heavily used in top tier phone

Re: [PATCH v2] arm64: dts: qcom: Add Lenovo Miix 630

2019-04-12 Thread Mark Rutland
On Thu, Apr 11, 2019 at 01:51:44PM -0700, Jeffrey Hugo wrote: > This adds the initial DT for the Lenovo Miix 630 laptop. Supported > functionality includes USB (host), microSD-card, keyboard, and trackpad. > > Signed-off-by: Jeffrey Hugo > --- > > v2: > -Changed "cls" to "clam" since feedback

[PATCH v2] arm64: dts: qcom: Add Lenovo Miix 630

2019-04-11 Thread Jeffrey Hugo
This adds the initial DT for the Lenovo Miix 630 laptop. Supported functionality includes USB (host), microSD-card, keyboard, and trackpad. Signed-off-by: Jeffrey Hugo --- v2: -Changed "cls" to "clam" since feedback indicated "cls" is too opaque, but "clamshell" is a mouthfull. "clam" seems