Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-18 Thread Linus Walleij
On Thu, Jan 10, 2013 at 9:42 PM, Stephen Warren wrote: >> + /* Allocate a pin state container on-the-fly */ >> + if (!dev->pins) { >> + dpi = devm_kzalloc(dev, sizeof(*dpi), GFP_KERNEL); > > This is allocated using a devm_ function. If -EPROBE_DEFER is returned > below after

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-18 Thread Linus Walleij
On Thu, Jan 10, 2013 at 9:42 PM, Stephen Warren swar...@wwwdotorg.org wrote: + /* Allocate a pin state container on-the-fly */ + if (!dev-pins) { + dpi = devm_kzalloc(dev, sizeof(*dpi), GFP_KERNEL); This is allocated using a devm_ function. If -EPROBE_DEFER is returned

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-17 Thread Simon Horman
On Thu, Jan 17, 2013 at 09:31:01AM -0700, Stephen Warren wrote: > On 01/16/2013 11:02 PM, Simon Horman wrote: > > On Wed, Jan 16, 2013 at 10:49:05AM -0700, Stephen Warren wrote: > >> On 01/11/2013 01:45 PM, Linus Walleij wrote: > >>> On Fri, Jan 11, 2013 at 9:36 PM, Laurent Pinchart > >>> wrote:

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-17 Thread Stephen Warren
On 01/16/2013 11:02 PM, Simon Horman wrote: > On Wed, Jan 16, 2013 at 10:49:05AM -0700, Stephen Warren wrote: >> On 01/11/2013 01:45 PM, Linus Walleij wrote: >>> On Fri, Jan 11, 2013 at 9:36 PM, Laurent Pinchart >>> wrote: >>> I've sent several patch series for the SH PFC (Pin Function

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-17 Thread Stephen Warren
On 01/16/2013 05:59 PM, Linus Walleij wrote: > On Wed, Jan 16, 2013 at 6:49 PM, Stephen Warren wrote: > >> Hmm. It's causing a lot of engineers here a lot of trouble, since they >> all see linux-next won't boot, and haven't been paying enough attention >> to know which commit to revert:-(. Lots

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-17 Thread Stephen Warren
On 01/16/2013 05:59 PM, Linus Walleij wrote: On Wed, Jan 16, 2013 at 6:49 PM, Stephen Warren swar...@wwwdotorg.org wrote: Hmm. It's causing a lot of engineers here a lot of trouble, since they all see linux-next won't boot, and haven't been paying enough attention to know which commit to

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-17 Thread Stephen Warren
On 01/16/2013 11:02 PM, Simon Horman wrote: On Wed, Jan 16, 2013 at 10:49:05AM -0700, Stephen Warren wrote: On 01/11/2013 01:45 PM, Linus Walleij wrote: On Fri, Jan 11, 2013 at 9:36 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: I've sent several patch series for the SH PFC

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-17 Thread Simon Horman
On Thu, Jan 17, 2013 at 09:31:01AM -0700, Stephen Warren wrote: On 01/16/2013 11:02 PM, Simon Horman wrote: On Wed, Jan 16, 2013 at 10:49:05AM -0700, Stephen Warren wrote: On 01/11/2013 01:45 PM, Linus Walleij wrote: On Fri, Jan 11, 2013 at 9:36 PM, Laurent Pinchart

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-16 Thread Simon Horman
On Wed, Jan 16, 2013 at 10:49:05AM -0700, Stephen Warren wrote: > On 01/11/2013 01:45 PM, Linus Walleij wrote: > > On Fri, Jan 11, 2013 at 9:36 PM, Laurent Pinchart > > wrote: > > > >> I've sent several patch series for the SH PFC (Pin Function Controller) to > >> the > >> linux-sh mailing

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-16 Thread Greg KH
On Thu, Jan 17, 2013 at 01:59:52AM +0100, Linus Walleij wrote: > On Wed, Jan 16, 2013 at 6:49 PM, Stephen Warren wrote: > > > Hmm. It's causing a lot of engineers here a lot of trouble, since they > > all see linux-next won't boot, and haven't been paying enough attention > > to know which

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-16 Thread Linus Walleij
On Wed, Jan 16, 2013 at 6:49 PM, Stephen Warren wrote: > Hmm. It's causing a lot of engineers here a lot of trouble, since they > all see linux-next won't boot, and haven't been paying enough attention > to know which commit to revert:-(. Lots of lost productivity:-( > > Simon, the offending

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-16 Thread Stephen Warren
On 01/11/2013 01:45 PM, Linus Walleij wrote: > On Fri, Jan 11, 2013 at 9:36 PM, Laurent Pinchart > wrote: > >> I've sent several patch series for the SH PFC (Pin Function Controller) to >> the >> linux-sh mailing list. One of the series included pinctrl core patches for >> easier testing, but I

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-16 Thread Stephen Warren
On 01/11/2013 01:45 PM, Linus Walleij wrote: On Fri, Jan 11, 2013 at 9:36 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: I've sent several patch series for the SH PFC (Pin Function Controller) to the linux-sh mailing list. One of the series included pinctrl core patches for

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-16 Thread Linus Walleij
On Wed, Jan 16, 2013 at 6:49 PM, Stephen Warren swar...@wwwdotorg.org wrote: Hmm. It's causing a lot of engineers here a lot of trouble, since they all see linux-next won't boot, and haven't been paying enough attention to know which commit to revert:-(. Lots of lost productivity:-( Simon,

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-16 Thread Greg KH
On Thu, Jan 17, 2013 at 01:59:52AM +0100, Linus Walleij wrote: On Wed, Jan 16, 2013 at 6:49 PM, Stephen Warren swar...@wwwdotorg.org wrote: Hmm. It's causing a lot of engineers here a lot of trouble, since they all see linux-next won't boot, and haven't been paying enough attention to

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-16 Thread Simon Horman
On Wed, Jan 16, 2013 at 10:49:05AM -0700, Stephen Warren wrote: On 01/11/2013 01:45 PM, Linus Walleij wrote: On Fri, Jan 11, 2013 at 9:36 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: I've sent several patch series for the SH PFC (Pin Function Controller) to the

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-11 Thread Linus Walleij
On Fri, Jan 11, 2013 at 9:36 PM, Laurent Pinchart wrote: > I've sent several patch series for the SH PFC (Pin Function Controller) to the > linux-sh mailing list. One of the series included pinctrl core patches for > easier testing, but I made it clear that they should *not* be pushed to >

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-11 Thread Laurent Pinchart
Hi Simon, On Friday 11 January 2013 21:12:43 Linus Walleij wrote: > On Thu, Jan 10, 2013 at 9:42 PM, Stephen Warren wrote: > > On 12/12/2012 01:25 PM, Linus Walleij wrote: > >> From: Linus Walleij > >> > >> This makes the device core auto-grab the pinctrl handle and set > >> the "default"

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-11 Thread Linus Walleij
On Thu, Jan 10, 2013 at 11:07 PM, Stephen Warren wrote: > I see that an attempt was made to solve this problem, in the patch > immediately preceding this one (at least, as applied in the pinctrl > tree). However, that patch only addresses the case where the pin > controller is being looked up in

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-11 Thread Linus Walleij
On Thu, Jan 10, 2013 at 9:42 PM, Stephen Warren wrote: > On 12/12/2012 01:25 PM, Linus Walleij wrote: >> From: Linus Walleij >> >> This makes the device core auto-grab the pinctrl handle and set >> the "default" (PINCTRL_STATE_DEFAULT) state for every device >> that is present in the device

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-11 Thread Linus Walleij
On Thu, Jan 10, 2013 at 9:42 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 12/12/2012 01:25 PM, Linus Walleij wrote: From: Linus Walleij linus.wall...@linaro.org This makes the device core auto-grab the pinctrl handle and set the default (PINCTRL_STATE_DEFAULT) state for every device

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-11 Thread Linus Walleij
On Thu, Jan 10, 2013 at 11:07 PM, Stephen Warren swar...@wwwdotorg.org wrote: I see that an attempt was made to solve this problem, in the patch immediately preceding this one (at least, as applied in the pinctrl tree). However, that patch only addresses the case where the pin controller is

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-11 Thread Laurent Pinchart
Hi Simon, On Friday 11 January 2013 21:12:43 Linus Walleij wrote: On Thu, Jan 10, 2013 at 9:42 PM, Stephen Warren wrote: On 12/12/2012 01:25 PM, Linus Walleij wrote: From: Linus Walleij linus.wall...@linaro.org This makes the device core auto-grab the pinctrl handle and set the

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-11 Thread Linus Walleij
On Fri, Jan 11, 2013 at 9:36 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: I've sent several patch series for the SH PFC (Pin Function Controller) to the linux-sh mailing list. One of the series included pinctrl core patches for easier testing, but I made it clear that they

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-10 Thread Stephen Warren
On 01/10/2013 01:42 PM, Stephen Warren wrote: > On 12/12/2012 01:25 PM, Linus Walleij wrote: >> From: Linus Walleij >> >> This makes the device core auto-grab the pinctrl handle and set >> the "default" (PINCTRL_STATE_DEFAULT) state for every device >> that is present in the device model right

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-10 Thread Stephen Warren
On 12/12/2012 01:25 PM, Linus Walleij wrote: > From: Linus Walleij > > This makes the device core auto-grab the pinctrl handle and set > the "default" (PINCTRL_STATE_DEFAULT) state for every device > that is present in the device model right before probe. This will > account for the lion's share

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-10 Thread Stephen Warren
On 12/12/2012 01:25 PM, Linus Walleij wrote: From: Linus Walleij linus.wall...@linaro.org This makes the device core auto-grab the pinctrl handle and set the default (PINCTRL_STATE_DEFAULT) state for every device that is present in the device model right before probe. This will account for

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-10 Thread Stephen Warren
On 01/10/2013 01:42 PM, Stephen Warren wrote: On 12/12/2012 01:25 PM, Linus Walleij wrote: From: Linus Walleij linus.wall...@linaro.org This makes the device core auto-grab the pinctrl handle and set the default (PINCTRL_STATE_DEFAULT) state for every device that is present in the device

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-09 Thread Linus Walleij
On Wed, Jan 2, 2013 at 2:42 PM, Linus Walleij wrote: > On Wed, Dec 12, 2012 at 10:54 PM, Greg Kroah-Hartman > wrote: >> On Wed, Dec 12, 2012 at 09:25:07PM +0100, Linus Walleij wrote: >>> From: Linus Walleij >>> >>> This makes the device core auto-grab the pinctrl handle and set >>> the

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-09 Thread Linus Walleij
On Wed, Jan 2, 2013 at 2:42 PM, Linus Walleij linus.wall...@linaro.org wrote: On Wed, Dec 12, 2012 at 10:54 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Wed, Dec 12, 2012 at 09:25:07PM +0100, Linus Walleij wrote: From: Linus Walleij linus.wall...@linaro.org This makes the

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-02 Thread Linus Walleij
On Wed, Dec 12, 2012 at 10:54 PM, Greg Kroah-Hartman wrote: > On Wed, Dec 12, 2012 at 09:25:07PM +0100, Linus Walleij wrote: >> From: Linus Walleij >> >> This makes the device core auto-grab the pinctrl handle and set >> the "default" (PINCTRL_STATE_DEFAULT) state for every device >> that is

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-02 Thread Mark Brown
On Wed, Dec 12, 2012 at 09:25:07PM +0100, Linus Walleij wrote: > From: Linus Walleij > > This makes the device core auto-grab the pinctrl handle and set > the "default" (PINCTRL_STATE_DEFAULT) state for every device > that is present in the device model right before probe. This will > account

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-02 Thread Mark Brown
On Wed, Dec 12, 2012 at 09:25:07PM +0100, Linus Walleij wrote: From: Linus Walleij linus.wall...@linaro.org This makes the device core auto-grab the pinctrl handle and set the default (PINCTRL_STATE_DEFAULT) state for every device that is present in the device model right before probe. This

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2013-01-02 Thread Linus Walleij
On Wed, Dec 12, 2012 at 10:54 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Wed, Dec 12, 2012 at 09:25:07PM +0100, Linus Walleij wrote: From: Linus Walleij linus.wall...@linaro.org This makes the device core auto-grab the pinctrl handle and set the default

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2012-12-12 Thread Greg Kroah-Hartman
On Wed, Dec 12, 2012 at 09:25:07PM +0100, Linus Walleij wrote: > From: Linus Walleij > > This makes the device core auto-grab the pinctrl handle and set > the "default" (PINCTRL_STATE_DEFAULT) state for every device > that is present in the device model right before probe. This will > account

[PATCH v2] drivers/pinctrl: grab default handles from device core

2012-12-12 Thread Linus Walleij
From: Linus Walleij This makes the device core auto-grab the pinctrl handle and set the "default" (PINCTRL_STATE_DEFAULT) state for every device that is present in the device model right before probe. This will account for the lion's share of embedded silicon devcies. A modification of the

[PATCH v2] drivers/pinctrl: grab default handles from device core

2012-12-12 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org This makes the device core auto-grab the pinctrl handle and set the default (PINCTRL_STATE_DEFAULT) state for every device that is present in the device model right before probe. This will account for the lion's share of embedded silicon devcies. A

Re: [PATCH v2] drivers/pinctrl: grab default handles from device core

2012-12-12 Thread Greg Kroah-Hartman
On Wed, Dec 12, 2012 at 09:25:07PM +0100, Linus Walleij wrote: From: Linus Walleij linus.wall...@linaro.org This makes the device core auto-grab the pinctrl handle and set the default (PINCTRL_STATE_DEFAULT) state for every device that is present in the device model right before probe. This