Re: [PATCH v2] extcon: Add support for qcom SPMI PMIC USB id detection hardware

2016-09-11 Thread Chanwoo Choi
Hi Stephen, Looks good to me. But, there are something that need to be modified. - add the author information - add the description of driver - use the extcon_set_state() instead of extcon_set_cable_state_() I modified this patch and applied it because I should send the pull request within this

Re: [PATCH v2] extcon: Add support for qcom SPMI PMIC USB id detection hardware

2016-09-11 Thread Chanwoo Choi
Hi Stephen, Looks good to me. But, there are something that need to be modified. - add the author information - add the description of driver - use the extcon_set_state() instead of extcon_set_cable_state_() I modified this patch and applied it because I should send the pull request within this

[PATCH v2] extcon: Add support for qcom SPMI PMIC USB id detection hardware

2016-09-09 Thread Stephen Boyd
Some Qualcomm PMICs have a misc device that performs USB id pin detection via an interrupt. When the interrupt triggers, we should read the interrupt line to see if it has gone high or low. If the interrupt is low then the ID pin is grounded, and if the interrupt is high then the ID pin is being

[PATCH v2] extcon: Add support for qcom SPMI PMIC USB id detection hardware

2016-09-09 Thread Stephen Boyd
Some Qualcomm PMICs have a misc device that performs USB id pin detection via an interrupt. When the interrupt triggers, we should read the interrupt line to see if it has gone high or low. If the interrupt is low then the ID pin is grounded, and if the interrupt is high then the ID pin is being