[PATCH v2] fs: jfs: fix a possible data race in metapage_writepage()

2020-05-05 Thread Jia-Ju Bai
The functions metapage_writepage() and lmPostGC() can be concurrently executed in the following call contexts: Thread1: metapage_writepage() Thread2: lbmIODone() lmPostGC() In metapage_writepage(): if (mp->log && !(mp->log->cflag & logGC_PAGEOUT)) In lmPostGC():

Re: [PATCH v2] fs: jfs: fix a possible data race in metapage_writepage()

2020-05-05 Thread Dave Kleikamp
On 5/5/20 9:15 AM, Markus Elfring wrote: >> This data race is found by our concurrency fuzzer. > > * How do you think about to replace the word “is” by “was”? > > * Is this analysis tool publicly available? > > > … >> --- >> fs/jfs/jfs_metapage.c | 11 +-- > > I suggest to omit the

Re: [PATCH v2] fs: jfs: fix a possible data race in metapage_writepage()

2020-05-05 Thread Jia-Ju Bai
On 2020/5/5 22:15, Markus Elfring wrote: This data race is found by our concurrency fuzzer. * How do you think about to replace the word “is” by “was”? Okay. * Is this analysis tool publicly available? Not yet, because we are still developing this tool... … ---

Re: [PATCH v2] fs: jfs: fix a possible data race in metapage_writepage()

2020-05-05 Thread Markus Elfring
> This data race is found by our concurrency fuzzer. * How do you think about to replace the word “is” by “was”? * Is this analysis tool publicly available? … > --- > fs/jfs/jfs_metapage.c | 11 +-- I suggest to omit the triple dashes before this information. Regards, Markus

[PATCH v2] fs: jfs: fix a possible data race in metapage_writepage()

2020-05-05 Thread Jia-Ju Bai
The functions metapage_writepage() and lmPostGC() can be concurrently executed in the following call contexts: Thread1: metapage_writepage() Thread2: lbmIODone() lmPostGC() In metapage_writepage(): if (mp->log && !(mp->log->cflag & logGC_PAGEOUT)) In lmPostGC():