Re: [PATCH v2] iio: adc: New driver for TI ADS7950 chips

2016-11-24 Thread Jonathan Cameron
On 21/11/16 19:52, David Lechner wrote: > On 11/20/2016 12:28 PM, David Lechner wrote: >> This adds a new driver for the TI ADS7950 family of ADC chips. These >> communicate using SPI and come in 8/10/12-bit and 4/8/12/16 channel >> varieties. >> >> Signed-off-by: David Lechner

Re: [PATCH v2] iio: adc: New driver for TI ADS7950 chips

2016-11-24 Thread Jonathan Cameron
On 21/11/16 19:52, David Lechner wrote: > On 11/20/2016 12:28 PM, David Lechner wrote: >> This adds a new driver for the TI ADS7950 family of ADC chips. These >> communicate using SPI and come in 8/10/12-bit and 4/8/12/16 channel >> varieties. >> >> Signed-off-by: David Lechner >> --- >> >> v2

Re: [PATCH v2] iio: adc: New driver for TI ADS7950 chips

2016-11-22 Thread David Lechner
On 11/22/2016 01:23 AM, Jonathan Cameron wrote: On 21 November 2016 22:54:24 GMT+00:00, Peter Meerwald-Stadler wrote: +static int ti_ads7950_read_raw(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, +

Re: [PATCH v2] iio: adc: New driver for TI ADS7950 chips

2016-11-22 Thread David Lechner
On 11/22/2016 01:23 AM, Jonathan Cameron wrote: On 21 November 2016 22:54:24 GMT+00:00, Peter Meerwald-Stadler wrote: +static int ti_ads7950_read_raw(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + int *val, int

Re: [PATCH v2] iio: adc: New driver for TI ADS7950 chips

2016-11-21 Thread Jonathan Cameron
On 21 November 2016 22:54:24 GMT+00:00, Peter Meerwald-Stadler wrote: > >> > +static int ti_ads7950_read_raw(struct iio_dev *indio_dev, >> > + struct iio_chan_spec const *chan, >> > + int *val, int *val2, long m) >> > +{ >> > +

Re: [PATCH v2] iio: adc: New driver for TI ADS7950 chips

2016-11-21 Thread Jonathan Cameron
On 21 November 2016 22:54:24 GMT+00:00, Peter Meerwald-Stadler wrote: > >> > +static int ti_ads7950_read_raw(struct iio_dev *indio_dev, >> > + struct iio_chan_spec const *chan, >> > + int *val, int *val2, long m) >> > +{ >> > + struct

Re: [PATCH v2] iio: adc: New driver for TI ADS7950 chips

2016-11-21 Thread Peter Meerwald-Stadler
> > +static int ti_ads7950_read_raw(struct iio_dev *indio_dev, > > + struct iio_chan_spec const *chan, > > + int *val, int *val2, long m) > > +{ > > + struct ti_ads7950_state *st = iio_priv(indio_dev); > > + int ret; > > + > > + switch (m) {

Re: [PATCH v2] iio: adc: New driver for TI ADS7950 chips

2016-11-21 Thread Peter Meerwald-Stadler
> > +static int ti_ads7950_read_raw(struct iio_dev *indio_dev, > > + struct iio_chan_spec const *chan, > > + int *val, int *val2, long m) > > +{ > > + struct ti_ads7950_state *st = iio_priv(indio_dev); > > + int ret; > > + > > + switch (m) {

Re: [PATCH v2] iio: adc: New driver for TI ADS7950 chips

2016-11-21 Thread David Lechner
On 11/20/2016 12:28 PM, David Lechner wrote: This adds a new driver for the TI ADS7950 family of ADC chips. These communicate using SPI and come in 8/10/12-bit and 4/8/12/16 channel varieties. Signed-off-by: David Lechner --- v2 changes: * Got rid of XX wildcards -

Re: [PATCH v2] iio: adc: New driver for TI ADS7950 chips

2016-11-21 Thread David Lechner
On 11/20/2016 12:28 PM, David Lechner wrote: This adds a new driver for the TI ADS7950 family of ADC chips. These communicate using SPI and come in 8/10/12-bit and 4/8/12/16 channel varieties. Signed-off-by: David Lechner --- v2 changes: * Got rid of XX wildcards - using ADS7950 everywhere *

[PATCH v2] iio: adc: New driver for TI ADS7950 chips

2016-11-20 Thread David Lechner
This adds a new driver for the TI ADS7950 family of ADC chips. These communicate using SPI and come in 8/10/12-bit and 4/8/12/16 channel varieties. Signed-off-by: David Lechner --- v2 changes: * Got rid of XX wildcards - using ADS7950 everywhere * Fixed some macro

[PATCH v2] iio: adc: New driver for TI ADS7950 chips

2016-11-20 Thread David Lechner
This adds a new driver for the TI ADS7950 family of ADC chips. These communicate using SPI and come in 8/10/12-bit and 4/8/12/16 channel varieties. Signed-off-by: David Lechner --- v2 changes: * Got rid of XX wildcards - using ADS7950 everywhere * Fixed some macro parentheses issues * Added