Re: [PATCH v2] kprobes: Use synchronize_rcu_tasks_rude in kprobe_optimizer

2024-02-04 Thread Chen Zhongjin
On 2024/2/1 21:47, Paul E. McKenney wrote: On Sat, Jan 27, 2024 at 06:09:05PM +0800, Chen Zhongjin wrote: On 2024/1/20 23:30, Paul E. McKenney wrote: > (Apologies for the delay, despite my attempts to make it otherwise, your email still got dumped into my spam folder.) Sorry for that,

Re: [PATCH v2] kprobes: Use synchronize_rcu_tasks_rude in kprobe_optimizer

2024-02-01 Thread Paul E. McKenney
On Sat, Jan 27, 2024 at 06:09:05PM +0800, Chen Zhongjin wrote: > On 2024/1/20 23:30, Paul E. McKenney wrote: (Apologies for the delay, despite my attempts to make it otherwise, your email still got dumped into my spam folder.) > Hi Paul, > This patch works for my reproduce test case. Thank

Re: [PATCH v2] kprobes: Use synchronize_rcu_tasks_rude in kprobe_optimizer

2024-01-27 Thread Chen Zhongjin
On 2024/1/20 23:30, Paul E. McKenney wrote: Hi Paul, This patch works for my reproduce test case. Just a small question, if you dont mind, this problem exsit on LTS version but we had struct rcu_tasks_percpu after v5.17. We can't backport this patch to LTS 5.10 or 4.19, which are still under

Re: [PATCH v2] kprobes: Use synchronize_rcu_tasks_rude in kprobe_optimizer

2024-01-20 Thread Paul E. McKenney
On Fri, Jan 19, 2024 at 06:37:26AM -0800, Paul E. McKenney wrote: > On Thu, Jan 18, 2024 at 02:18:42AM +, Chen Zhongjin wrote: > > There is a deadlock scenario in kprobe_optimizer(): > > > > pid A pid B pid C > > kprobe_optimizer()

Re: [PATCH v2] kprobes: Use synchronize_rcu_tasks_rude in kprobe_optimizer

2024-01-19 Thread Paul E. McKenney
On Thu, Jan 18, 2024 at 02:18:42AM +, Chen Zhongjin wrote: > There is a deadlock scenario in kprobe_optimizer(): > > pid A pid B pid C > kprobe_optimizer()do_exit() perf_kprobe_init() > mutex_lock(_mutex)

Re: [PATCH v2] kprobes: Use synchronize_rcu_tasks_rude in kprobe_optimizer

2024-01-19 Thread Google
On Wed, 17 Jan 2024 21:26:46 -0500 Steven Rostedt wrote: > On Thu, 18 Jan 2024 02:18:42 + > Chen Zhongjin wrote: > > > There is a deadlock scenario in kprobe_optimizer(): > > > > pid A pid B pid C > > kprobe_optimizer() do_exit()

Re: [PATCH v2] kprobes: Use synchronize_rcu_tasks_rude in kprobe_optimizer

2024-01-19 Thread Paul E. McKenney
On Thu, Jan 18, 2024 at 06:44:54AM -0800, Paul E. McKenney wrote: > On Wed, Jan 17, 2024 at 09:26:46PM -0500, Steven Rostedt wrote: > > On Thu, 18 Jan 2024 02:18:42 + > > Chen Zhongjin wrote: > > > > > There is a deadlock scenario in kprobe_optimizer(): > > > > > > pid A

Re: [PATCH v2] kprobes: Use synchronize_rcu_tasks_rude in kprobe_optimizer

2024-01-18 Thread Paul E. McKenney
On Wed, Jan 17, 2024 at 09:26:46PM -0500, Steven Rostedt wrote: > On Thu, 18 Jan 2024 02:18:42 + > Chen Zhongjin wrote: > > > There is a deadlock scenario in kprobe_optimizer(): > > > > pid A pid B pid C > > kprobe_optimizer()

Re: [PATCH v2] kprobes: Use synchronize_rcu_tasks_rude in kprobe_optimizer

2024-01-17 Thread Steven Rostedt
On Thu, 18 Jan 2024 02:18:42 + Chen Zhongjin wrote: > There is a deadlock scenario in kprobe_optimizer(): > > pid A pid B pid C > kprobe_optimizer()do_exit() perf_kprobe_init() > mutex_lock(_mutex)

[PATCH v2] kprobes: Use synchronize_rcu_tasks_rude in kprobe_optimizer

2024-01-17 Thread Chen Zhongjin
There is a deadlock scenario in kprobe_optimizer(): pid A pid B pid C kprobe_optimizer() do_exit() perf_kprobe_init() mutex_lock(_mutex) exit_tasks_rcu_start() mutex_lock(_mutex) synchronize_rcu_tasks()