Re: [PATCH v2] lan743x: correctly handle chips with internal PHY

2020-11-09 Thread Roelof Berg
. > I would love to test this patch on fixed-link, but unfortunately Yes, understandable, it’s quite dome effort. I will e-mail the company that owns the test setup. They have their own pcba‘s ready meanwhile, so maybe they can give me the EVM setup and I can use it for testing your and other

Re: [PATCH v2] lan743x: correctly handle chips with internal PHY

2020-11-09 Thread Sven Van Asbroeck
Hi Roelof, On Sun, Nov 8, 2020 at 2:57 PM Roelof Berg wrote: > > Well, it’s not an easy 4 hours attempt between breakfast and lunch, > unfortunately, but it’s based on inexpensive off-the-shelf parts and doable > in an experienced team. > I would love to test this patch on fixed-link, but

Re: [PATCH v2] lan743x: correctly handle chips with internal PHY

2020-11-08 Thread Sven Van Asbroeck
Hi Roelof, great to meet another user of the lan743x ! On Sun, Nov 8, 2020 at 2:43 AM Roelof Berg wrote: > > My last customer has a fixed link setup, contact me if you need one. Maybe > they let me have it and I can test all future patches on fixed link as well. Is this a commercially

Re: [PATCH v2] lan743x: correctly handle chips with internal PHY

2020-11-08 Thread Sven Van Asbroeck
On Sat, Nov 7, 2020 at 11:14 PM Andrew Lunn wrote: > > This also has nothing to do with the problem you are fixing. It is a > sensible thing to do, but it should be a separate patch, and target > net-next, since it is not a fix. > Agreed - I will spin a truly minimal v3.

Re: [PATCH v2] lan743x: correctly handle chips with internal PHY

2020-11-08 Thread Roelof Berg
My last customer has a fixed link setup, contact me if you need one. Maybe they let me have it and I can test all future patches on fixed link as well. I tested the current driver version on a Lan7430 EVM in a PC by the way and it seemed to be working. I have the EVM still here if needed.

Re: [PATCH v2] lan743x: correctly handle chips with internal PHY

2020-11-07 Thread Andrew Lunn
On Fri, Nov 06, 2020 at 08:43:24AM -0500, Sven Van Asbroeck wrote: > From: Sven Van Asbroeck > > Commit 6f197fb63850 ("lan743x: Added fixed link and RGMII support") > assumes that chips with an internal PHY will never have a devicetree > entry. This is incorrect: even for these chips, a

[PATCH v2] lan743x: correctly handle chips with internal PHY

2020-11-06 Thread Sven Van Asbroeck
From: Sven Van Asbroeck Commit 6f197fb63850 ("lan743x: Added fixed link and RGMII support") assumes that chips with an internal PHY will never have a devicetree entry. This is incorrect: even for these chips, a devicetree entry can be useful e.g. to pass the mac address from bootloader to chip: