On Wed, Apr 17, 2013 at 10:52 PM, Timur Tabi wrote:
> On Wed, Apr 17, 2013 at 9:57 AM, Grant Likely
> wrote:
>>
>>> I really preciate if you can spend some times to review this patch.
>>
>> Applied, thanks.
>
> Pff. Why do I bother?
Relax Timur:
On Wed, Apr 17, 2013 at 9:57 AM, Grant Likely wrote:
>
>> I really preciate if you can spend some times to review this patch.
>
> Applied, thanks.
Pff. Why do I bother?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
On Tue, 16 Apr 2013 06:54:40 +, Tang Yuantian-B29983
wrote:
> Hi Grant.likely,
>
> I really preciate if you can spend some times to review this patch.
Applied, thanks.
g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
Tang Yuantian-B29983 wrote:
It was placed on ELSE statement originally, I moved it to IF statement.
Why is it so wrong?
Because the logic of the comment applies to the else-condition, not the
if-condtion.
--
Timur Tabi
--
To unsubscribe from this list: send the line "unsubscribe
Tang Yuantian-B29983 wrote:
It was placed on ELSE statement originally, I moved it to IF statement.
Why is it so wrong?
Because the logic of the comment applies to the else-condition, not the
if-condtion.
--
Timur Tabi
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
On Tue, 16 Apr 2013 06:54:40 +, Tang Yuantian-B29983 b29...@freescale.com
wrote:
Hi Grant.likely,
I really preciate if you can spend some times to review this patch.
Applied, thanks.
g.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to
On Wed, Apr 17, 2013 at 9:57 AM, Grant Likely grant.lik...@secretlab.ca wrote:
I really preciate if you can spend some times to review this patch.
Applied, thanks.
Pff. Why do I bother?
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to
On Wed, Apr 17, 2013 at 10:52 PM, Timur Tabi ti...@tabi.org wrote:
On Wed, Apr 17, 2013 at 9:57 AM, Grant Likely grant.lik...@secretlab.ca
wrote:
I really preciate if you can spend some times to review this patch.
Applied, thanks.
Pff. Why do I bother?
Relax Timur:
> -Original Message-
> From: Timur Tabi [mailto:ti...@tabi.org]
> Sent: 2013年4月17日 11:31
> To: Tang Yuantian-B29983
> Cc: Grant Likely; devicetree-discuss; linuxppc-...@lists.ozlabs.org; lkml;
> Rob Herring
> Subject: Re: [PATCH v2] of/base: release the node correctly in
>
Tang Yuantian-B29983 wrote:
>On Tue, Apr 9, 2013 at 10:36 PM, wrote:
> >
> >+ /* Found it! return success */
>
>I'm pretty sure this comment is in the wrong place.
It is not perfect, but acceptable.
Like I said, I'm pretty sure it's in the wrong place.
--
Timur
> -Original Message-
> From: Timur Tabi [mailto:ti...@tabi.org]
> Sent: 2013年4月16日 19:37
> To: Tang Yuantian-B29983
> Cc: Grant Likely; devicetree-discuss; linuxppc-...@lists.ozlabs.org; lkml;
> Rob Herring
> Subject: Re: [PATCH v2] of/base: release the node correctly in
>
On Tue, Apr 9, 2013 at 10:36 PM, wrote:
>
> + /* Found it! return success */
I'm pretty sure this comment is in the wrong place.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo
Hi Grant.likely,
I really preciate if you can spend some times to review this patch.
Thanks,
Yuantian
> -Original Message-
> From: Tang Yuantian-B29983
> Sent: 2013年4月10日 11:37
> To: grant.lik...@secretlab.ca
> Cc: rob.herr...@calxeda.com; devicetree-disc...@lists.ozlabs.org; linux-
>
Hi Grant.likely,
I really preciate if you can spend some times to review this patch.
Thanks,
Yuantian
-Original Message-
From: Tang Yuantian-B29983
Sent: 2013年4月10日 11:37
To: grant.lik...@secretlab.ca
Cc: rob.herr...@calxeda.com; devicetree-disc...@lists.ozlabs.org; linux-
On Tue, Apr 9, 2013 at 10:36 PM, yuantian.t...@freescale.com wrote:
+ /* Found it! return success */
I'm pretty sure this comment is in the wrong place.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to
-Original Message-
From: Timur Tabi [mailto:ti...@tabi.org]
Sent: 2013年4月16日 19:37
To: Tang Yuantian-B29983
Cc: Grant Likely; devicetree-discuss; linuxppc-...@lists.ozlabs.org; lkml;
Rob Herring
Subject: Re: [PATCH v2] of/base: release the node correctly in
Tang Yuantian-B29983 wrote:
On Tue, Apr 9, 2013 at 10:36 PM,yuantian.t...@freescale.com wrote:
+ /* Found it! return success */
I'm pretty sure this comment is in the wrong place.
It is not perfect, but acceptable.
Like I said, I'm pretty sure it's in the wrong
-Original Message-
From: Timur Tabi [mailto:ti...@tabi.org]
Sent: 2013年4月17日 11:31
To: Tang Yuantian-B29983
Cc: Grant Likely; devicetree-discuss; linuxppc-...@lists.ozlabs.org; lkml;
Rob Herring
Subject: Re: [PATCH v2] of/base: release the node correctly in
From: Tang Yuantian
Call of_node_put() only when the out_args is NULL on success,
or the node's reference count will not be correct because the caller
will call of_node_put() again.
Signed-off-by: Tang Yuantian
---
v2:
- modified the title and description. the 1st patch title is:
From: Tang Yuantian yuantian.t...@freescale.com
Call of_node_put() only when the out_args is NULL on success,
or the node's reference count will not be correct because the caller
will call of_node_put() again.
Signed-off-by: Tang Yuantian yuantian.t...@freescale.com
---
v2:
- modified
20 matches
Mail list logo
