Re: [ORLinux] [PATCH v2] openrisc: irq: use irqchip framework

2014-05-22 Thread Stefan Kristiansson
On Thu, May 22, 2014 at 09:48:00AM +0200, Geert Uytterhoeven wrote: > On Thu, May 22, 2014 at 9:32 AM, Jonas Bonn wrote: > > On 05/21/2014 09:50 PM, Stefan Kristiansson wrote: > >> I see two paths to go to get there though, and here's where I'd like some > >> input. > >> 1) Define the three

Re: [ORLinux] [PATCH v2] openrisc: irq: use irqchip framework

2014-05-22 Thread Geert Uytterhoeven
On Thu, May 22, 2014 at 9:32 AM, Jonas Bonn wrote: > On 05/21/2014 09:50 PM, Stefan Kristiansson wrote: >> I see two paths to go to get there though, and here's where I'd like some >> input. >> 1) Define the three different implementations as seperate irqchips, >>with accompanying

Re: [PATCH v2] openrisc: irq: use irqchip framework

2014-05-22 Thread Jonas Bonn
On 05/21/2014 09:50 PM, Stefan Kristiansson wrote: > > I see two paths to go to get there though, and here's where I'd like some > input. > 1) Define the three different implementations as seperate irqchips, >with accompanying IRQCHIP_DECLARE. > 2) Add custom device-tree bindings and

Re: [PATCH v2] openrisc: irq: use irqchip framework

2014-05-22 Thread Jonas Bonn
On 05/21/2014 09:50 PM, Stefan Kristiansson wrote: I see two paths to go to get there though, and here's where I'd like some input. 1) Define the three different implementations as seperate irqchips, with accompanying IRQCHIP_DECLARE. 2) Add custom device-tree bindings and determine the

Re: [ORLinux] [PATCH v2] openrisc: irq: use irqchip framework

2014-05-22 Thread Geert Uytterhoeven
On Thu, May 22, 2014 at 9:32 AM, Jonas Bonn jo...@southpole.se wrote: On 05/21/2014 09:50 PM, Stefan Kristiansson wrote: I see two paths to go to get there though, and here's where I'd like some input. 1) Define the three different implementations as seperate irqchips, with accompanying

Re: [ORLinux] [PATCH v2] openrisc: irq: use irqchip framework

2014-05-22 Thread Stefan Kristiansson
On Thu, May 22, 2014 at 09:48:00AM +0200, Geert Uytterhoeven wrote: On Thu, May 22, 2014 at 9:32 AM, Jonas Bonn jo...@southpole.se wrote: On 05/21/2014 09:50 PM, Stefan Kristiansson wrote: I see two paths to go to get there though, and here's where I'd like some input. 1) Define the

Re: [PATCH v2] openrisc: irq: use irqchip framework

2014-05-21 Thread Stefan Kristiansson
On Wed, May 21, 2014 at 04:01:56PM -0400, Jason Cooper wrote: > On Wed, May 21, 2014 at 10:50:57PM +0300, Stefan Kristiansson wrote: > ... > > I see two paths to go to get there though, and here's where I'd like some > > input. > > 1) Define the three different implementations as seperate

Re: [PATCH v2] openrisc: irq: use irqchip framework

2014-05-21 Thread Jason Cooper
On Wed, May 21, 2014 at 10:50:57PM +0300, Stefan Kristiansson wrote: ... > I see two paths to go to get there though, and here's where I'd like some > input. > 1) Define the three different implementations as seperate irqchips, >with accompanying IRQCHIP_DECLARE. > 2) Add custom device-tree

Re: [PATCH v2] openrisc: irq: use irqchip framework

2014-05-21 Thread Stefan Kristiansson
On Tue, May 20, 2014 at 08:18:16AM +0900, Thomas Gleixner wrote: > On Mon, 19 May 2014, Stefan Kristiansson wrote: > > +static void or1k_pic_ack(struct irq_data *data) > > +{ > > + /* EDGE-triggered interrupts need to be ack'ed in order to clear > > +* the latch. > > +* LEVEL-triggered

Re: [PATCH v2] openrisc: irq: use irqchip framework

2014-05-21 Thread Stefan Kristiansson
On Tue, May 20, 2014 at 08:18:16AM +0900, Thomas Gleixner wrote: On Mon, 19 May 2014, Stefan Kristiansson wrote: +static void or1k_pic_ack(struct irq_data *data) +{ + /* EDGE-triggered interrupts need to be ack'ed in order to clear +* the latch. +* LEVEL-triggered interrupts

Re: [PATCH v2] openrisc: irq: use irqchip framework

2014-05-21 Thread Jason Cooper
On Wed, May 21, 2014 at 10:50:57PM +0300, Stefan Kristiansson wrote: ... I see two paths to go to get there though, and here's where I'd like some input. 1) Define the three different implementations as seperate irqchips, with accompanying IRQCHIP_DECLARE. 2) Add custom device-tree

Re: [PATCH v2] openrisc: irq: use irqchip framework

2014-05-21 Thread Stefan Kristiansson
On Wed, May 21, 2014 at 04:01:56PM -0400, Jason Cooper wrote: On Wed, May 21, 2014 at 10:50:57PM +0300, Stefan Kristiansson wrote: ... I see two paths to go to get there though, and here's where I'd like some input. 1) Define the three different implementations as seperate irqchips,

Re: [PATCH v2] openrisc: irq: use irqchip framework

2014-05-19 Thread Thomas Gleixner
On Mon, 19 May 2014, Stefan Kristiansson wrote: > +static void or1k_pic_ack(struct irq_data *data) > +{ > + /* EDGE-triggered interrupts need to be ack'ed in order to clear > + * the latch. > + * LEVEL-triggered interrupts do not need to be ack'ed; however, > + * ack'ing the

[PATCH v2] openrisc: irq: use irqchip framework

2014-05-19 Thread Stefan Kristiansson
In addition to consolidating the or1k-pic with other interrupt controllers, this makes OpenRISC less tied to its on-cpu interrupt controller. All or1k-pic specific parts are moved out of irq.c and into drivers/irqchip/irq-or1k-pic.c In that transition, a couple of changes have been done: - The

Re: [PATCH v2] openrisc: irq: use irqchip framework

2014-05-19 Thread Thomas Gleixner
On Mon, 19 May 2014, Stefan Kristiansson wrote: +static void or1k_pic_ack(struct irq_data *data) +{ + /* EDGE-triggered interrupts need to be ack'ed in order to clear + * the latch. + * LEVEL-triggered interrupts do not need to be ack'ed; however, + * ack'ing the interrupt

[PATCH v2] openrisc: irq: use irqchip framework

2014-05-19 Thread Stefan Kristiansson
In addition to consolidating the or1k-pic with other interrupt controllers, this makes OpenRISC less tied to its on-cpu interrupt controller. All or1k-pic specific parts are moved out of irq.c and into drivers/irqchip/irq-or1k-pic.c In that transition, a couple of changes have been done: - The