Re: [PATCH v2] rch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE_' for related macros

2014-06-25 Thread Guenter Roeck
On Thu, Jun 26, 2014 at 12:05:33AM +, Wu Yu-Chen wrote: > As I said, these macros are useless currently. I don’t think users will use > these macros since the kernel doesn’t respond these macros. However, you are > welcome to provide your idea  > Just drop them entirely. Guenter -- To

Re: [PATCH v2] rch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE_' for related macros

2014-06-25 Thread Chen Gang
On 06/25/2014 11:16 PM, Lennox Wu wrote: > These marcos are listed in advance. > Indeed, they have not been used, and the functions use them have not > be released. UAPI is the main interface for contribution to outside, that is our main goal, and has the highest priority. After new contents are

Re: [PATCH v2] rch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE_' for related macros

2014-06-25 Thread Lennox Wu
These marcos are listed in advance. Indeed, they have not been used, and the functions use them have not be released. I would like to keep the status even if the configure should not be used. However, if guys think it is dirty, maybe we can remove or comment them first. Best, Lennox 2014-06-25

Re: [PATCH v2] rch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE_' for related macros

2014-06-25 Thread Lennox Wu
These marcos are listed in advance. Indeed, they have not been used, and the functions use them have not be released. I would like to keep the status even if the configure should not be used. However, if guys think it is dirty, maybe we can remove or comment them first. Best, Lennox 2014-06-25

Re: [PATCH v2] rch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE_' for related macros

2014-06-25 Thread Chen Gang
On 06/25/2014 11:16 PM, Lennox Wu wrote: These marcos are listed in advance. Indeed, they have not been used, and the functions use them have not be released. UAPI is the main interface for contribution to outside, that is our main goal, and has the highest priority. After new contents are

Re: [PATCH v2] rch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE_' for related macros

2014-06-25 Thread Guenter Roeck
On Thu, Jun 26, 2014 at 12:05:33AM +, Wu Yu-Chen wrote: As I said, these macros are useless currently. I don’t think users will use these macros since the kernel doesn’t respond these macros. However, you are welcome to provide your idea  Just drop them entirely. Guenter -- To

Re: [PATCH v2] rch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE_' for related macros

2014-06-24 Thread Chen Gang
On 06/25/2014 07:40 AM, David Rientjes wrote: > On Tue, 24 Jun 2014, Guenter Roeck wrote: > >> That is another question. But for the time being it might be sufficient to >> surround the defines with #if !defined(__KERNEL__) without introducing new >> (and unused) kernel defines. >> > > On the

Re: [PATCH v2] rch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE_' for related macros

2014-06-24 Thread David Rientjes
On Tue, 24 Jun 2014, Guenter Roeck wrote: > That is another question. But for the time being it might be sufficient to > surround the defines with #if !defined(__KERNEL__) without introducing new > (and unused) kernel defines. > On the other hand, if no userspace is referencing these, then you

Re: [PATCH v2] rch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE_' for related macros

2014-06-24 Thread Guenter Roeck
On 06/24/2014 03:51 PM, David Rientjes wrote: On Tue, 24 Jun 2014, Guenter Roeck wrote: diff --git a/arch/score/include/uapi/asm/ptrace.h b/arch/score/include/uapi/asm/ptrace.h index f59771a..56e2de0 100644 --- a/arch/score/include/uapi/asm/ptrace.h +++ b/arch/score/include/uapi/asm/ptrace.h

Re: [PATCH v2] rch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE_' for related macros

2014-06-24 Thread David Rientjes
On Tue, 24 Jun 2014, Guenter Roeck wrote: > > diff --git a/arch/score/include/uapi/asm/ptrace.h > > b/arch/score/include/uapi/asm/ptrace.h > > index f59771a..56e2de0 100644 > > --- a/arch/score/include/uapi/asm/ptrace.h > > +++ b/arch/score/include/uapi/asm/ptrace.h > > @@ -4,16 +4,29 @@ > >

Re: [PATCH v2] rch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE_' for related macros

2014-06-24 Thread Guenter Roeck
On 06/24/2014 06:08 AM, Chen Gang wrote: 'COUNTER' and other same kind macros are too common to use, and easy to get conflict with other modules. So add prefix for them. And it is UAPI, so only change it within linux kernel. The related warning (allmodconfig with score): CC [M]

[PATCH v2] rch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE_' for related macros

2014-06-24 Thread Chen Gang
'COUNTER' and other same kind macros are too common to use, and easy to get conflict with other modules. So add prefix for them. And it is UAPI, so only change it within linux kernel. The related warning (allmodconfig with score): CC [M] drivers/md/raid1.o In file included from

[PATCH v2] rch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE_' for related macros

2014-06-24 Thread Chen Gang
'COUNTER' and other same kind macros are too common to use, and easy to get conflict with other modules. So add prefix for them. And it is UAPI, so only change it within linux kernel. The related warning (allmodconfig with score): CC [M] drivers/md/raid1.o In file included from

Re: [PATCH v2] rch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE_' for related macros

2014-06-24 Thread Guenter Roeck
On 06/24/2014 06:08 AM, Chen Gang wrote: 'COUNTER' and other same kind macros are too common to use, and easy to get conflict with other modules. So add prefix for them. And it is UAPI, so only change it within linux kernel. The related warning (allmodconfig with score): CC [M]

Re: [PATCH v2] rch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE_' for related macros

2014-06-24 Thread David Rientjes
On Tue, 24 Jun 2014, Guenter Roeck wrote: diff --git a/arch/score/include/uapi/asm/ptrace.h b/arch/score/include/uapi/asm/ptrace.h index f59771a..56e2de0 100644 --- a/arch/score/include/uapi/asm/ptrace.h +++ b/arch/score/include/uapi/asm/ptrace.h @@ -4,16 +4,29 @@ #define

Re: [PATCH v2] rch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE_' for related macros

2014-06-24 Thread Guenter Roeck
On 06/24/2014 03:51 PM, David Rientjes wrote: On Tue, 24 Jun 2014, Guenter Roeck wrote: diff --git a/arch/score/include/uapi/asm/ptrace.h b/arch/score/include/uapi/asm/ptrace.h index f59771a..56e2de0 100644 --- a/arch/score/include/uapi/asm/ptrace.h +++ b/arch/score/include/uapi/asm/ptrace.h

Re: [PATCH v2] rch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE_' for related macros

2014-06-24 Thread David Rientjes
On Tue, 24 Jun 2014, Guenter Roeck wrote: That is another question. But for the time being it might be sufficient to surround the defines with #if !defined(__KERNEL__) without introducing new (and unused) kernel defines. On the other hand, if no userspace is referencing these, then you

Re: [PATCH v2] rch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE_' for related macros

2014-06-24 Thread Chen Gang
On 06/25/2014 07:40 AM, David Rientjes wrote: On Tue, 24 Jun 2014, Guenter Roeck wrote: That is another question. But for the time being it might be sufficient to surround the defines with #if !defined(__KERNEL__) without introducing new (and unused) kernel defines. On the other hand,