Re: [PATCH v2] sched: fix wrong rq's runnable_avg update with rt task

2013-02-12 Thread Vincent Guittot
On 12 February 2013 15:53, Steven Rostedt wrote: > On Tue, 2013-02-12 at 14:23 +0100, Vincent Guittot wrote: >> .set_curr_task = set_curr_task_idle, >> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h >> index fc88644..9707092 100644 >> --- a/kernel/sched/sched.h >> +++

Re: [PATCH v2] sched: fix wrong rq's runnable_avg update with rt task

2013-02-12 Thread Steven Rostedt
On Tue, 2013-02-12 at 14:23 +0100, Vincent Guittot wrote: > .set_curr_task = set_curr_task_idle, > diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h > index fc88644..9707092 100644 > --- a/kernel/sched/sched.h > +++ b/kernel/sched/sched.h > @@ -877,6 +877,7 @@ extern const

Re: [PATCH v2] sched: fix wrong rq's runnable_avg update with rt task

2013-02-12 Thread Vincent Guittot
On 12 February 2013 14:23, Vincent Guittot wrote: > When a RT task is scheduled on an idle CPU, the update of the rq's load is > not done because CFS's functions are not called. Then, the idle_balance, > which is called just before entering the idle function, updates the > rq's load and makes the

[PATCH v2] sched: fix wrong rq's runnable_avg update with rt task

2013-02-12 Thread Vincent Guittot
When a RT task is scheduled on an idle CPU, the update of the rq's load is not done because CFS's functions are not called. Then, the idle_balance, which is called just before entering the idle function, updates the rq's load and makes the assumption that the elapsed time since the last update,

[PATCH v2] sched: fix wrong rq's runnable_avg update with rt task

2013-02-12 Thread Vincent Guittot
When a RT task is scheduled on an idle CPU, the update of the rq's load is not done because CFS's functions are not called. Then, the idle_balance, which is called just before entering the idle function, updates the rq's load and makes the assumption that the elapsed time since the last update,

Re: [PATCH v2] sched: fix wrong rq's runnable_avg update with rt task

2013-02-12 Thread Vincent Guittot
On 12 February 2013 14:23, Vincent Guittot vincent.guit...@linaro.org wrote: When a RT task is scheduled on an idle CPU, the update of the rq's load is not done because CFS's functions are not called. Then, the idle_balance, which is called just before entering the idle function, updates the

Re: [PATCH v2] sched: fix wrong rq's runnable_avg update with rt task

2013-02-12 Thread Steven Rostedt
On Tue, 2013-02-12 at 14:23 +0100, Vincent Guittot wrote: .set_curr_task = set_curr_task_idle, diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index fc88644..9707092 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -877,6 +877,7 @@ extern const struct

Re: [PATCH v2] sched: fix wrong rq's runnable_avg update with rt task

2013-02-12 Thread Vincent Guittot
On 12 February 2013 15:53, Steven Rostedt rost...@goodmis.org wrote: On Tue, 2013-02-12 at 14:23 +0100, Vincent Guittot wrote: .set_curr_task = set_curr_task_idle, diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index fc88644..9707092 100644 --- a/kernel/sched/sched.h