Re: [PATCH v2] usb/xhci: fix compilation warning when !CONFIG_PCI && !CONFIG_PM

2014-03-24 Thread Mathias Nyman
On 03/21/2014 11:41 PM, David Cohen wrote: Hi Mathias, Thanks for commenting. That would be actually the v1 of my patch :) I changed after I see the proper function has __maybe_unused flag. But I'm fine with Sarah picking any of the patch's versions. Guess you're handling the review of

Re: [PATCH v2] usb/xhci: fix compilation warning when !CONFIG_PCI !CONFIG_PM

2014-03-24 Thread Mathias Nyman
On 03/21/2014 11:41 PM, David Cohen wrote: Hi Mathias, Thanks for commenting. That would be actually the v1 of my patch :) I changed after I see the proper function has __maybe_unused flag. But I'm fine with Sarah picking any of the patch's versions. Guess you're handling the review of

Re: [PATCH v2] usb/xhci: fix compilation warning when !CONFIG_PCI && !CONFIG_PM

2014-03-21 Thread David Cohen
Hi Mathias, On Tue, Feb 18, 2014 at 11:04:12AM -0800, David Cohen wrote: > On Tue, Feb 18, 2014 at 12:47:41PM -0600, Felipe Balbi wrote: > > On Tue, Feb 18, 2014 at 10:00:30AM -0800, David Cohen wrote: > > > Hi Sarah, > > > > > > On Mon, Jan 06, 2014 at 07:02:19PM -0800, David Cohen wrote: > > >

Re: [PATCH v2] usb/xhci: fix compilation warning when !CONFIG_PCI !CONFIG_PM

2014-03-21 Thread David Cohen
Hi Mathias, On Tue, Feb 18, 2014 at 11:04:12AM -0800, David Cohen wrote: On Tue, Feb 18, 2014 at 12:47:41PM -0600, Felipe Balbi wrote: On Tue, Feb 18, 2014 at 10:00:30AM -0800, David Cohen wrote: Hi Sarah, On Mon, Jan 06, 2014 at 07:02:19PM -0800, David Cohen wrote: When

Re: [PATCH v2] usb/xhci: fix compilation warning when !CONFIG_PCI && !CONFIG_PM

2014-02-18 Thread David Cohen
On Tue, Feb 18, 2014 at 12:47:41PM -0600, Felipe Balbi wrote: > On Tue, Feb 18, 2014 at 10:00:30AM -0800, David Cohen wrote: > > Hi Sarah, > > > > On Mon, Jan 06, 2014 at 07:02:19PM -0800, David Cohen wrote: > > > When CONFIG_PCI and CONFIG_PM are not selected, xhci.c gets this > > > warning: > >

Re: [PATCH v2] usb/xhci: fix compilation warning when !CONFIG_PCI && !CONFIG_PM

2014-02-18 Thread Felipe Balbi
On Tue, Feb 18, 2014 at 10:00:30AM -0800, David Cohen wrote: > Hi Sarah, > > On Mon, Jan 06, 2014 at 07:02:19PM -0800, David Cohen wrote: > > When CONFIG_PCI and CONFIG_PM are not selected, xhci.c gets this > > warning: > > drivers/usb/host/xhci.c:409:13: warning: ‘xhci_msix_sync_irqs’ defined >

Re: [PATCH v2] usb/xhci: fix compilation warning when !CONFIG_PCI && !CONFIG_PM

2014-02-18 Thread David Cohen
Hi Sarah, On Mon, Jan 06, 2014 at 07:02:19PM -0800, David Cohen wrote: > When CONFIG_PCI and CONFIG_PM are not selected, xhci.c gets this > warning: > drivers/usb/host/xhci.c:409:13: warning: ‘xhci_msix_sync_irqs’ defined > but not used [-Wunused-function] > > It happens due to lack of

Re: [PATCH v2] usb/xhci: fix compilation warning when !CONFIG_PCI !CONFIG_PM

2014-02-18 Thread David Cohen
Hi Sarah, On Mon, Jan 06, 2014 at 07:02:19PM -0800, David Cohen wrote: When CONFIG_PCI and CONFIG_PM are not selected, xhci.c gets this warning: drivers/usb/host/xhci.c:409:13: warning: ‘xhci_msix_sync_irqs’ defined but not used [-Wunused-function] It happens due to lack of __maybe_unused

Re: [PATCH v2] usb/xhci: fix compilation warning when !CONFIG_PCI !CONFIG_PM

2014-02-18 Thread Felipe Balbi
On Tue, Feb 18, 2014 at 10:00:30AM -0800, David Cohen wrote: Hi Sarah, On Mon, Jan 06, 2014 at 07:02:19PM -0800, David Cohen wrote: When CONFIG_PCI and CONFIG_PM are not selected, xhci.c gets this warning: drivers/usb/host/xhci.c:409:13: warning: ‘xhci_msix_sync_irqs’ defined but not

Re: [PATCH v2] usb/xhci: fix compilation warning when !CONFIG_PCI !CONFIG_PM

2014-02-18 Thread David Cohen
On Tue, Feb 18, 2014 at 12:47:41PM -0600, Felipe Balbi wrote: On Tue, Feb 18, 2014 at 10:00:30AM -0800, David Cohen wrote: Hi Sarah, On Mon, Jan 06, 2014 at 07:02:19PM -0800, David Cohen wrote: When CONFIG_PCI and CONFIG_PM are not selected, xhci.c gets this warning:

[PATCH v2] usb/xhci: fix compilation warning when !CONFIG_PCI && !CONFIG_PM

2014-01-06 Thread David Cohen
When CONFIG_PCI and CONFIG_PM are not selected, xhci.c gets this warning: drivers/usb/host/xhci.c:409:13: warning: ‘xhci_msix_sync_irqs’ defined but not used [-Wunused-function] It happens due to lack of __maybe_unused flag on xhci_msix_sync_irqs() function in case of !CONFIG_PCI. Signed-off-by:

[PATCH v2] usb/xhci: fix compilation warning when !CONFIG_PCI !CONFIG_PM

2014-01-06 Thread David Cohen
When CONFIG_PCI and CONFIG_PM are not selected, xhci.c gets this warning: drivers/usb/host/xhci.c:409:13: warning: ‘xhci_msix_sync_irqs’ defined but not used [-Wunused-function] It happens due to lack of __maybe_unused flag on xhci_msix_sync_irqs() function in case of !CONFIG_PCI. Signed-off-by: