Re: [PATCH v2 0/4] perf: Fix perf_event_attr::exclusive rotation

2020-11-09 Thread Peter Zijlstra
On Mon, Nov 02, 2020 at 06:41:43PM -0800, Andi Kleen wrote: > On Mon, Nov 02, 2020 at 03:16:25PM +0100, Peter Zijlstra wrote: > > On Sun, Nov 01, 2020 at 07:52:38PM -0800, Andi Kleen wrote: > > > The main motivation is actually that the "multiple groups" algorithm > > > in perf doesn't work all

Re: [PATCH v2 0/4] perf: Fix perf_event_attr::exclusive rotation

2020-11-02 Thread Andi Kleen
On Mon, Nov 02, 2020 at 03:16:25PM +0100, Peter Zijlstra wrote: > On Sun, Nov 01, 2020 at 07:52:38PM -0800, Andi Kleen wrote: > > The main motivation is actually that the "multiple groups" algorithm > > in perf doesn't work all that great: it has quite a few cases where it > > starves groups or

Re: [PATCH v2 0/4] perf: Fix perf_event_attr::exclusive rotation

2020-11-02 Thread Peter Zijlstra
On Sun, Nov 01, 2020 at 07:52:38PM -0800, Andi Kleen wrote: > The main motivation is actually that the "multiple groups" algorithm > in perf doesn't work all that great: it has quite a few cases where it > starves groups or makes the wrong decisions. That is because it is very > difficult (likely

Re: [PATCH v2 0/4] perf: Fix perf_event_attr::exclusive rotation

2020-11-01 Thread Andi Kleen
> hm, it's too late for me to check ;-) but should I be able to do > this with exclusive event.. running both command at the same time: Yes. The exclusive part only applies during a given context, but the two commands are different contexts. You would only see a difference when in the same

Re: [PATCH v2 0/4] perf: Fix perf_event_attr::exclusive rotation

2020-10-31 Thread Jiri Olsa
On Thu, Oct 29, 2020 at 05:27:19PM +0100, Peter Zijlstra wrote: > Hi, > > Andi recently added exclusive event group support to tools/perf: > > https://lkml.kernel.org/r/20201014144255.22699-1-a...@firstfloor.org > > and promptly found that they didn't work as specified. > > (sorry for the

[PATCH v2 0/4] perf: Fix perf_event_attr::exclusive rotation

2020-10-29 Thread Peter Zijlstra
Hi, Andi recently added exclusive event group support to tools/perf: https://lkml.kernel.org/r/20201014144255.22699-1-a...@firstfloor.org and promptly found that they didn't work as specified. (sorry for the resend, I forgot LKML the first time)