Re: [PATCH v2 0/6] Btrfs: show subvolume name and ID in /proc/mounts

2015-05-11 Thread Qu Wenruo
Original Message Subject: Re: [PATCH v2 0/6] Btrfs: show subvolume name and ID in /proc/mounts From: Omar Sandoval To: David Sterba , Qu Wenruo , Date: 2015年05月11日 17:42 On Thu, Apr 09, 2015 at 02:34:50PM -0700, Omar Sandoval wrote: Here's version 2 of providing

Re: [PATCH v2 0/6] Btrfs: show subvolume name and ID in /proc/mounts

2015-05-11 Thread Omar Sandoval
On Mon, May 11, 2015 at 04:51:37PM +0200, David Sterba wrote: > On Mon, May 11, 2015 at 02:42:58AM -0700, Omar Sandoval wrote: > > Sorry for the long-winded email! Thoughts, David, Qu? > > I'm ok with the approach and the patchset as a whole. There was one > minor issue with the aliasing of the

Re: [PATCH v2 0/6] Btrfs: show subvolume name and ID in /proc/mounts

2015-05-11 Thread David Sterba
On Mon, May 11, 2015 at 02:42:58AM -0700, Omar Sandoval wrote: > Sorry for the long-winded email! Thoughts, David, Qu? I'm ok with the approach and the patchset as a whole. There was one minor issue with the aliasing of the toplevel subvolume (id 0 or 5). I'll post a comment to the patch. -- To

Re: [PATCH v2 0/6] Btrfs: show subvolume name and ID in /proc/mounts

2015-05-11 Thread Omar Sandoval
On Thu, Apr 09, 2015 at 02:34:50PM -0700, Omar Sandoval wrote: > Here's version 2 of providing the subvolume name and ID in /proc/mounts. > > It turns out that getting the name of a subvolume reliably is a bit > trickier than it would seem because of how mounting subvolumes by ID is >

Re: [PATCH v2 0/6] Btrfs: show subvolume name and ID in /proc/mounts

2015-05-11 Thread Omar Sandoval
On Thu, Apr 09, 2015 at 02:34:50PM -0700, Omar Sandoval wrote: Here's version 2 of providing the subvolume name and ID in /proc/mounts. It turns out that getting the name of a subvolume reliably is a bit trickier than it would seem because of how mounting subvolumes by ID is implemented. In

Re: [PATCH v2 0/6] Btrfs: show subvolume name and ID in /proc/mounts

2015-05-11 Thread David Sterba
On Mon, May 11, 2015 at 02:42:58AM -0700, Omar Sandoval wrote: Sorry for the long-winded email! Thoughts, David, Qu? I'm ok with the approach and the patchset as a whole. There was one minor issue with the aliasing of the toplevel subvolume (id 0 or 5). I'll post a comment to the patch. -- To

Re: [PATCH v2 0/6] Btrfs: show subvolume name and ID in /proc/mounts

2015-05-11 Thread Omar Sandoval
On Mon, May 11, 2015 at 04:51:37PM +0200, David Sterba wrote: On Mon, May 11, 2015 at 02:42:58AM -0700, Omar Sandoval wrote: Sorry for the long-winded email! Thoughts, David, Qu? I'm ok with the approach and the patchset as a whole. There was one minor issue with the aliasing of the

Re: [PATCH v2 0/6] Btrfs: show subvolume name and ID in /proc/mounts

2015-05-11 Thread Qu Wenruo
Original Message Subject: Re: [PATCH v2 0/6] Btrfs: show subvolume name and ID in /proc/mounts From: Omar Sandoval osan...@osandov.com To: David Sterba dste...@suse.cz, Qu Wenruo quwen...@cn.fujitsu.com, linux-bt...@vger.kernel.org Date: 2015年05月11日 17:42 On Thu, Apr 09

[PATCH v2 0/6] Btrfs: show subvolume name and ID in /proc/mounts

2015-04-09 Thread Omar Sandoval
Here's version 2 of providing the subvolume name and ID in /proc/mounts. It turns out that getting the name of a subvolume reliably is a bit trickier than it would seem because of how mounting subvolumes by ID is implemented. In particular, in that case, the dentry we get for the root of the

[PATCH v2 0/6] Btrfs: show subvolume name and ID in /proc/mounts

2015-04-09 Thread Omar Sandoval
Here's version 2 of providing the subvolume name and ID in /proc/mounts. It turns out that getting the name of a subvolume reliably is a bit trickier than it would seem because of how mounting subvolumes by ID is implemented. In particular, in that case, the dentry we get for the root of the