Re: [PATCH v2 01/13] gpio: Add Elba SoC gpio driver for spi cs control

2021-03-31 Thread Serge Semin
On Sun, Mar 28, 2021 at 06:59:26PM -0700, Brad Larson wrote: > This GPIO driver is for the Pensando Elba SoC which > provides control of four chip selects on two SPI busses. > > Signed-off-by: Brad Larson > --- > drivers/gpio/Kconfig | 6 ++ > drivers/gpio/Makefile | 1 +

Re: [PATCH v2 01/13] gpio: Add Elba SoC gpio driver for spi cs control

2021-03-29 Thread Linus Walleij
On Mon, Mar 29, 2021 at 3:59 AM Brad Larson wrote: > This GPIO driver is for the Pensando Elba SoC which > provides control of four chip selects on two SPI busses. > > Signed-off-by: Brad Larson You have not addressed mine nor Andy's comments on v1. Go back, read and reply, and rewrite.

Re: [PATCH v2 01/13] gpio: Add Elba SoC gpio driver for spi cs control

2021-03-29 Thread Andy Shevchenko
On Mon, Mar 29, 2021 at 5:01 AM Brad Larson wrote: > > This GPIO driver is for the Pensando Elba SoC which > provides control of four chip selects on two SPI busses. Same comments as per v1. NAK from me until we get settled in that discussion. ... > +MODULE_LICENSE("GPL v2"); >

[PATCH v2 01/13] gpio: Add Elba SoC gpio driver for spi cs control

2021-03-28 Thread Brad Larson
This GPIO driver is for the Pensando Elba SoC which provides control of four chip selects on two SPI busses. Signed-off-by: Brad Larson --- drivers/gpio/Kconfig | 6 ++ drivers/gpio/Makefile | 1 + drivers/gpio/gpio-elba-spics.c | 114 + 3