Re: [PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2

2017-06-23 Thread Maxime Ripard
Hi, On Tue, Jun 13, 2017 at 06:05:57PM +0800, Chen-Yu Tsai wrote: > > That's not true. DE1's can output to several TCONs (or rather, TCONs > > can select multiple engines as their input). The A31 for example is in > > this case. > > Actually that's not true. The TCON is bound to the backend. I

Re: [PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2

2017-06-23 Thread Maxime Ripard
Hi, On Tue, Jun 13, 2017 at 06:05:57PM +0800, Chen-Yu Tsai wrote: > > That's not true. DE1's can output to several TCONs (or rather, TCONs > > can select multiple engines as their input). The A31 for example is in > > this case. > > Actually that's not true. The TCON is bound to the backend. I

Re: [PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2

2017-06-13 Thread Chen-Yu Tsai
On Tue, Jun 13, 2017 at 5:43 PM, Maxime Ripard wrote: > On Sat, Jun 10, 2017 at 10:57:28PM +0800, icen...@aosc.io wrote: >> 在 2017-06-09 22:46,Maxime Ripard 写道: >> > On Thu, Jun 08, 2017 at 01:01:53PM +0800, icen...@aosc.io wrote: >> > > 在 2017-06-07 22:38,Maxime

Re: [PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2

2017-06-13 Thread Chen-Yu Tsai
On Tue, Jun 13, 2017 at 5:43 PM, Maxime Ripard wrote: > On Sat, Jun 10, 2017 at 10:57:28PM +0800, icen...@aosc.io wrote: >> 在 2017-06-09 22:46,Maxime Ripard 写道: >> > On Thu, Jun 08, 2017 at 01:01:53PM +0800, icen...@aosc.io wrote: >> > > 在 2017-06-07 22:38,Maxime Ripard 写道: >> > > > On Wed, Jun

Re: [PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2

2017-06-13 Thread Maxime Ripard
On Sat, Jun 10, 2017 at 11:16:35PM +0800, icen...@aosc.io wrote: > 在 2017-06-10 22:57,icen...@aosc.io 写道: > > 在 2017-06-09 22:46,Maxime Ripard 写道: > > > On Thu, Jun 08, 2017 at 01:01:53PM +0800, icen...@aosc.io wrote: > > > > 在 2017-06-07 22:38,Maxime Ripard 写道: > > > > > On Wed, Jun 07, 2017 at

Re: [PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2

2017-06-13 Thread Maxime Ripard
On Sat, Jun 10, 2017 at 11:16:35PM +0800, icen...@aosc.io wrote: > 在 2017-06-10 22:57,icen...@aosc.io 写道: > > 在 2017-06-09 22:46,Maxime Ripard 写道: > > > On Thu, Jun 08, 2017 at 01:01:53PM +0800, icen...@aosc.io wrote: > > > > 在 2017-06-07 22:38,Maxime Ripard 写道: > > > > > On Wed, Jun 07, 2017 at

Re: [PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2

2017-06-13 Thread Maxime Ripard
On Sat, Jun 10, 2017 at 10:57:28PM +0800, icen...@aosc.io wrote: > 在 2017-06-09 22:46,Maxime Ripard 写道: > > On Thu, Jun 08, 2017 at 01:01:53PM +0800, icen...@aosc.io wrote: > > > 在 2017-06-07 22:38,Maxime Ripard 写道: > > > > On Wed, Jun 07, 2017 at 06:01:02PM +0800, Icenowy Zheng wrote: > > > > >

Re: [PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2

2017-06-13 Thread Maxime Ripard
On Sat, Jun 10, 2017 at 10:57:28PM +0800, icen...@aosc.io wrote: > 在 2017-06-09 22:46,Maxime Ripard 写道: > > On Thu, Jun 08, 2017 at 01:01:53PM +0800, icen...@aosc.io wrote: > > > 在 2017-06-07 22:38,Maxime Ripard 写道: > > > > On Wed, Jun 07, 2017 at 06:01:02PM +0800, Icenowy Zheng wrote: > > > > >

Re: [PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2

2017-06-10 Thread icenowy
在 2017-06-10 22:57,icen...@aosc.io 写道: 在 2017-06-09 22:46,Maxime Ripard 写道: On Thu, Jun 08, 2017 at 01:01:53PM +0800, icen...@aosc.io wrote: 在 2017-06-07 22:38,Maxime Ripard 写道: > On Wed, Jun 07, 2017 at 06:01:02PM +0800, Icenowy Zheng wrote: > > >I have no idea what this is supposed to be

Re: [PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2

2017-06-10 Thread icenowy
在 2017-06-10 22:57,icen...@aosc.io 写道: 在 2017-06-09 22:46,Maxime Ripard 写道: On Thu, Jun 08, 2017 at 01:01:53PM +0800, icen...@aosc.io wrote: 在 2017-06-07 22:38,Maxime Ripard 写道: > On Wed, Jun 07, 2017 at 06:01:02PM +0800, Icenowy Zheng wrote: > > >I have no idea what this is supposed to be

Re: [PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2

2017-06-10 Thread icenowy
在 2017-06-09 22:46,Maxime Ripard 写道: On Thu, Jun 08, 2017 at 01:01:53PM +0800, icen...@aosc.io wrote: 在 2017-06-07 22:38,Maxime Ripard 写道: > On Wed, Jun 07, 2017 at 06:01:02PM +0800, Icenowy Zheng wrote: > > >I have no idea what this is supposed to be doing either. > > > > > >I might be wrong,

Re: [PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2

2017-06-10 Thread icenowy
在 2017-06-09 22:46,Maxime Ripard 写道: On Thu, Jun 08, 2017 at 01:01:53PM +0800, icen...@aosc.io wrote: 在 2017-06-07 22:38,Maxime Ripard 写道: > On Wed, Jun 07, 2017 at 06:01:02PM +0800, Icenowy Zheng wrote: > > >I have no idea what this is supposed to be doing either. > > > > > >I might be wrong,

Re: [PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2

2017-06-09 Thread Maxime Ripard
On Thu, Jun 08, 2017 at 01:01:53PM +0800, icen...@aosc.io wrote: > 在 2017-06-07 22:38,Maxime Ripard 写道: > > On Wed, Jun 07, 2017 at 06:01:02PM +0800, Icenowy Zheng wrote: > > > >I have no idea what this is supposed to be doing either. > > > > > > > >I might be wrong, but I really feel like there's

Re: [PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2

2017-06-09 Thread Maxime Ripard
On Thu, Jun 08, 2017 at 01:01:53PM +0800, icen...@aosc.io wrote: > 在 2017-06-07 22:38,Maxime Ripard 写道: > > On Wed, Jun 07, 2017 at 06:01:02PM +0800, Icenowy Zheng wrote: > > > >I have no idea what this is supposed to be doing either. > > > > > > > >I might be wrong, but I really feel like there's

Re: [PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2

2017-06-09 Thread Maxime Ripard
Hi Jernej, On Wed, Jun 07, 2017 at 08:15:12PM +0200, Jernej Škrabec wrote: > Hi! > > Dne sreda, 07. junij 2017 ob 16:38:27 CEST je Maxime Ripard napisal(a): > > On Wed, Jun 07, 2017 at 06:01:02PM +0800, Icenowy Zheng wrote: > > > >I have no idea what this is supposed to be doing either. > > > >

Re: [PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2

2017-06-09 Thread Maxime Ripard
Hi Jernej, On Wed, Jun 07, 2017 at 08:15:12PM +0200, Jernej Škrabec wrote: > Hi! > > Dne sreda, 07. junij 2017 ob 16:38:27 CEST je Maxime Ripard napisal(a): > > On Wed, Jun 07, 2017 at 06:01:02PM +0800, Icenowy Zheng wrote: > > > >I have no idea what this is supposed to be doing either. > > > >

Re: [PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2

2017-06-07 Thread icenowy
在 2017-06-07 22:38,Maxime Ripard 写道: On Wed, Jun 07, 2017 at 06:01:02PM +0800, Icenowy Zheng wrote: >I have no idea what this is supposed to be doing either. > >I might be wrong, but I really feel like there's a big mismatch >between your commit log, and what you actually implement. > >In your

Re: [PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2

2017-06-07 Thread icenowy
在 2017-06-07 22:38,Maxime Ripard 写道: On Wed, Jun 07, 2017 at 06:01:02PM +0800, Icenowy Zheng wrote: >I have no idea what this is supposed to be doing either. > >I might be wrong, but I really feel like there's a big mismatch >between your commit log, and what you actually implement. > >In your

Re: [PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2

2017-06-07 Thread Jernej Škrabec
Hi! Dne sreda, 07. junij 2017 ob 16:38:27 CEST je Maxime Ripard napisal(a): > On Wed, Jun 07, 2017 at 06:01:02PM +0800, Icenowy Zheng wrote: > > >I have no idea what this is supposed to be doing either. > > > > > >I might be wrong, but I really feel like there's a big mismatch > > >between your

Re: [PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2

2017-06-07 Thread Jernej Škrabec
Hi! Dne sreda, 07. junij 2017 ob 16:38:27 CEST je Maxime Ripard napisal(a): > On Wed, Jun 07, 2017 at 06:01:02PM +0800, Icenowy Zheng wrote: > > >I have no idea what this is supposed to be doing either. > > > > > >I might be wrong, but I really feel like there's a big mismatch > > >between your

Re: [PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2

2017-06-07 Thread Maxime Ripard
On Wed, Jun 07, 2017 at 06:01:02PM +0800, Icenowy Zheng wrote: > >I have no idea what this is supposed to be doing either. > > > >I might be wrong, but I really feel like there's a big mismatch > >between your commit log, and what you actually implement. > > > >In your commit log, you should

Re: [PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2

2017-06-07 Thread Maxime Ripard
On Wed, Jun 07, 2017 at 06:01:02PM +0800, Icenowy Zheng wrote: > >I have no idea what this is supposed to be doing either. > > > >I might be wrong, but I really feel like there's a big mismatch > >between your commit log, and what you actually implement. > > > >In your commit log, you should

Re: [PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2

2017-06-07 Thread Icenowy Zheng
于 2017年6月7日 GMT+08:00 下午5:35:12, Maxime Ripard 写到: >On Mon, Jun 05, 2017 at 12:01:41AM +0800, Icenowy Zheng wrote: >> Some SoC's DE2 has two mixers. Defaultly the mixer0 is connected to >> tcon0 and mixer1 is connected to tcon1; however by setting a bit >> the

Re: [PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2

2017-06-07 Thread Icenowy Zheng
于 2017年6月7日 GMT+08:00 下午5:35:12, Maxime Ripard 写到: >On Mon, Jun 05, 2017 at 12:01:41AM +0800, Icenowy Zheng wrote: >> Some SoC's DE2 has two mixers. Defaultly the mixer0 is connected to >> tcon0 and mixer1 is connected to tcon1; however by setting a bit >> the connection can be swapped. >> >>

Re: [PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2

2017-06-07 Thread Icenowy Zheng
于 2017年6月7日 GMT+08:00 下午5:35:12, Maxime Ripard 写到: >On Mon, Jun 05, 2017 at 12:01:41AM +0800, Icenowy Zheng wrote: >> Some SoC's DE2 has two mixers. Defaultly the mixer0 is connected to >> tcon0 and mixer1 is connected to tcon1; however by setting a bit >> the

Re: [PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2

2017-06-07 Thread Icenowy Zheng
于 2017年6月7日 GMT+08:00 下午5:35:12, Maxime Ripard 写到: >On Mon, Jun 05, 2017 at 12:01:41AM +0800, Icenowy Zheng wrote: >> Some SoC's DE2 has two mixers. Defaultly the mixer0 is connected to >> tcon0 and mixer1 is connected to tcon1; however by setting a bit >> the connection can be swapped. >> >>

Re: [PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2

2017-06-07 Thread Maxime Ripard
On Mon, Jun 05, 2017 at 12:01:41AM +0800, Icenowy Zheng wrote: > Some SoC's DE2 has two mixers. Defaultly the mixer0 is connected to > tcon0 and mixer1 is connected to tcon1; however by setting a bit > the connection can be swapped. > > As we now hardcode the default connection, ignore the bonus

Re: [PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2

2017-06-07 Thread Maxime Ripard
On Mon, Jun 05, 2017 at 12:01:41AM +0800, Icenowy Zheng wrote: > Some SoC's DE2 has two mixers. Defaultly the mixer0 is connected to > tcon0 and mixer1 is connected to tcon1; however by setting a bit > the connection can be swapped. > > As we now hardcode the default connection, ignore the bonus

[PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2

2017-06-04 Thread Icenowy Zheng
Some SoC's DE2 has two mixers. Defaultly the mixer0 is connected to tcon0 and mixer1 is connected to tcon1; however by setting a bit the connection can be swapped. As we now hardcode the default connection, ignore the bonus endpoint for the mixer's output and the TCON's input, as they stands for

[PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2

2017-06-04 Thread Icenowy Zheng
Some SoC's DE2 has two mixers. Defaultly the mixer0 is connected to tcon0 and mixer1 is connected to tcon1; however by setting a bit the connection can be swapped. As we now hardcode the default connection, ignore the bonus endpoint for the mixer's output and the TCON's input, as they stands for