Re: [PATCH v2 06/20] ppp: slight optimization of addr compare

2013-12-24 Thread Sergei Shtylyov
Hello. On 24-12-2013 20:35, Joe Perches wrote: [] diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c [] @@ -131,12 +131,13 @@ static inline struct pppoe_net *pppoe_pernet(struct net *net) static inline int cmp_2_addr(struct pppoe_addr *a, struct pppoe_addr *b) { -

Re: [PATCH v2 06/20] ppp: slight optimization of addr compare

2013-12-24 Thread Joe Perches
On Tue, 2013-12-24 at 20:24 +0400, Sergei Shtylyov wrote: > On 24-12-2013 15:28, Ding Tianhong wrote: [] > > diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c [] > > @@ -131,12 +131,13 @@ static inline struct pppoe_net *pppoe_pernet(struct > > net *net) > > > > static inline int

Re: [PATCH v2 06/20] ppp: slight optimization of addr compare

2013-12-24 Thread Sergei Shtylyov
Hello. On 24-12-2013 15:28, Ding Tianhong wrote: Use possibly more efficient ether_addr_equal to instead of memcmp. Cc: Michal Ostrowski Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Ding Tianhong --- drivers/net/ppp/pppoe.c | 5 +++-- 1 file changed, 3

[PATCH v2 06/20] ppp: slight optimization of addr compare

2013-12-24 Thread Ding Tianhong
Use possibly more efficient ether_addr_equal to instead of memcmp. Cc: Michal Ostrowski Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Ding Tianhong --- drivers/net/ppp/pppoe.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH v2 06/20] ppp: slight optimization of addr compare

2013-12-24 Thread Ding Tianhong
Use possibly more efficient ether_addr_equal to instead of memcmp. Cc: Michal Ostrowski mostr...@earthlink.net Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Ding Tianhong dingtianh...@huawei.com --- drivers/net/ppp/pppoe.c | 5 +++-- 1 file changed, 3 insertions(+),

Re: [PATCH v2 06/20] ppp: slight optimization of addr compare

2013-12-24 Thread Sergei Shtylyov
Hello. On 24-12-2013 15:28, Ding Tianhong wrote: Use possibly more efficient ether_addr_equal to instead of memcmp. Cc: Michal Ostrowski mostr...@earthlink.net Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Ding Tianhong dingtianh...@huawei.com ---

Re: [PATCH v2 06/20] ppp: slight optimization of addr compare

2013-12-24 Thread Joe Perches
On Tue, 2013-12-24 at 20:24 +0400, Sergei Shtylyov wrote: On 24-12-2013 15:28, Ding Tianhong wrote: [] diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c [] @@ -131,12 +131,13 @@ static inline struct pppoe_net *pppoe_pernet(struct net *net) static inline int

Re: [PATCH v2 06/20] ppp: slight optimization of addr compare

2013-12-24 Thread Sergei Shtylyov
Hello. On 24-12-2013 20:35, Joe Perches wrote: [] diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c [] @@ -131,12 +131,13 @@ static inline struct pppoe_net *pppoe_pernet(struct net *net) static inline int cmp_2_addr(struct pppoe_addr *a, struct pppoe_addr *b) { -