Re: [PATCH v2 1/2] lib/vsprintf.c: Simplify uuid_string()

2016-06-05 Thread George Spelvin
r >From andriy.shevche...@linux.intel.com Sun Jun 05 14:21:40 2016 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,421,1459839600"; d="scan'208";a="969274163" Subject: Re: [PATCH v2 1/2] lib/vsprintf.c: Simplify uuid_string() From: Andy Shevchenko <andriy.sh

Re: [PATCH v2 1/2] lib/vsprintf.c: Simplify uuid_string()

2016-06-05 Thread George Spelvin
r >From andriy.shevche...@linux.intel.com Sun Jun 05 14:21:40 2016 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,421,1459839600"; d="scan'208";a="969274163" Subject: Re: [PATCH v2 1/2] lib/vsprintf.c: Simplify uuid_string() From: Andy Shevchenko To: George

Re: [PATCH v2 1/2] lib/vsprintf.c: Simplify uuid_string()

2016-06-05 Thread Andy Shevchenko
On Sat, 2016-06-04 at 01:14 -0400, George Spelvin wrote: > Rather than have a second pass to upcase the buffer, just make the > hex lookup table a variable. > > Removing the conditional branch from the inner loop is also a > speedup, but since this is not hot code, the important factor > it

Re: [PATCH v2 1/2] lib/vsprintf.c: Simplify uuid_string()

2016-06-05 Thread Andy Shevchenko
On Sat, 2016-06-04 at 01:14 -0400, George Spelvin wrote: > Rather than have a second pass to upcase the buffer, just make the > hex lookup table a variable. > > Removing the conditional branch from the inner loop is also a > speedup, but since this is not hot code, the important factor > it

[PATCH v2 1/2] lib/vsprintf.c: Simplify uuid_string()

2016-06-03 Thread George Spelvin
Rather than have a second pass to upcase the buffer, just make the hex lookup table a variable. Removing the conditional branch from the inner loop is also a speedup, but since this is not hot code, the important factor it shrinks both source and compiled forms: Before After Delta

[PATCH v2 1/2] lib/vsprintf.c: Simplify uuid_string()

2016-06-03 Thread George Spelvin
Rather than have a second pass to upcase the buffer, just make the hex lookup table a variable. Removing the conditional branch from the inner loop is also a speedup, but since this is not hot code, the important factor it shrinks both source and compiled forms: Before After Delta